<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="PL" link="blue" vlink="purple"> <div class="WordSection1"> Resending to group.<o:p></o:p> <a name="_MailEndCompose"><o:p> </o:p></a> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <a name="_____replyseparator"></a>From: Wu, Hao A Sent: Monday, June 10, 2019 5:18 AM To: Albecki, Mateusz <mateusz.albecki@intel.com> Subject: RE: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol<o:p></o:p> </div> </div> <o:p> </o:p> Hello Mateusz,<o:p></o:p> <o:p> </o:p> Thanks for the patch series and sorry for the delayed response.<o:p></o:p> <o:p> </o:p> One question first, I did not see the patches being sent to the mailing list<o:p></o:p> 'devel@edk2.groups.io'. We have recently switched to this new mailing list back<o:p></o:p> to early April, the old one 'edk2-devel@lists.01.org' is no longer being used.<o:p></o:p> <o:p> </o:p> In case that you have not registered the new list, you can sign up at:<o:p></o:p> <a href="https://edk2.groups.io/g/devel">https://edk2.groups.io/g/devel</a><o:p></o:p> or email:<o:p></o:p> <a href="mailto:devel+subscribe@edk2.groups.io">devel+subscribe@edk2.groups.io</a><o:p></o:p> to get registered in the new mailing list.<o:p></o:p> <o:p> </o:p> Or you can send me the patch files and I will help to send them to the mailing list.<o:p></o:p> <o:p> </o:p> <o:p> </o:p> Below are some general level feedbacks (Other patch-specific feedbacks will be replied in other mails):<o:p></o:p> <![if !supportLists]>· <![endif]>Could you help to add the below Bugzilla tracker reference in the commit log message?<o:p></o:p> <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=1882">https://bugzilla.tianocore.org/show_bug.cgi?id=1882</a><o:p></o:p> <o:p> </o:p> <![if !supportLists]>· <![endif]>Could you help to run the script ‘BaseTools/Scripts/PatchCheck.py’ and resolve its report on the commit log format issues?<o:p></o:p> Checking git commit: 6e3f64aeb4<o:p></o:p> The commit message format is not valid:<o:p></o:p> * Contributed-under! (Note: this must be removed by the code contributor!)<o:p></o:p> * Add quotes (") around name with a comma: Albecki, Mateusz<o:p></o:p> * Email format is invalid: <a href="mailto:hao.a.wu@intel.com"> hao.a.wu@intel.com</a><o:p></o:p> * Line 15 of commit message is too long.<o:p></o:p> <a href="https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format">https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format</a><o:p></o:p> The code passed all checks.<o:p></o:p> <o:p> </o:p> Checking git commit: 91595ae911<o:p></o:p> The commit message format is not valid:<o:p></o:p> * Contributed-under! (Note: this must be removed by the code contributor!)<o:p></o:p> * Add quotes (") around name with a comma: Albecki, Mateusz<o:p></o:p> * Email format is invalid: <a href="mailto:hao.a.wu@intel.com"> hao.a.wu@intel.com</a><o:p></o:p> <a href="https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format">https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format</a><o:p></o:p> The code passed all checks.<o:p></o:p> <o:p> </o:p> <![if !supportLists]>· <![endif]>Could you help to resolve the typo ‘Prefered’ to ‘Preferred’ in the naming of some variables?<o:p></o:p> <o:p> </o:p> <![if !supportLists]>· <![endif]>Could you help to use lowercase ‘static’ (instead of using the uppercase one) for the new functions?<o:p></o:p> <o:p> </o:p> <o:p> </o:p> Also, I only verified the build of the patch series. Please grant me some time<o:p></o:p> to verify on the HW on my side. Maybe your updated patches arrive first and I<o:p></o:p> will then verify the update ones.<o:p></o:p> <o:p> </o:p> <o:p> </o:p> Best Regards,<o:p></o:p> Hao Wu<o:p></o:p> <o:p> </o:p> > -----Original Message-----<o:p></o:p> > From: Albecki, Mateusz<o:p></o:p> > Sent: Monday, June 03, 2019 7:34 PM<o:p></o:p> > Cc: Albecki, Mateusz; Wu, Hao A<o:p></o:p> > Subject: [PATCH 0/2] Add GetOperatingParam notify phase to<o:p></o:p> > SdMmcOverride protocol<o:p></o:p> > <o:p></o:p> > To allow platform greater control over the bus settings for SD card and<o:p></o:p> > eMMC card<o:p></o:p> > we have added a new notify phase to SdMmcOverrideProtocol called<o:p></o:p> > GetOperatingParam.<o:p></o:p> > This phase is signaled before SD card/eMMC initialization and allows platform<o:p></o:p> > to tweak<o:p></o:p> > the values in new structure called<o:p></o:p> > EDKII_SD_MMC_OPERATING_PARAMETERS which allows to configure<o:p></o:p> > bus width, clock frequency and driver strength. Other bus parameters can be<o:p></o:p> > configured by<o:p></o:p> > overriding host controller capabilities.<o:p></o:p> > <o:p></o:p> > Tests:<o:p></o:p> > - OS boot from eMMC without SdMmcOverride protocol installed<o:p></o:p> > - OS boot from eMMC with SdMmcOverride installed and clock frequency<o:p></o:p> > lowered to 100MHz in HS200<o:p></o:p> > - OS boot from eMMC with driver strength changed to Type1<o:p></o:p> > - SD card enumeration in UEFI shell on default speed and high speed(non<o:p></o:p> > UHS-I) with SdMmcOverride installed and UHS-I disabled in capability<o:p></o:p> > <o:p></o:p> > <o:p></o:p> > Cc: <a href="mailto:hao.a.wu@intel.com"> hao.a.wu@intel.com</a><o:p></o:p> > <o:p></o:p> > Albecki, Mateusz (2):<o:p></o:p> > MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase<o:p></o:p> > MdeModulePkg/SdMmcHcDxe: Implement revision 3 of<o:p></o:p> > SdMmcOverrideProtocol<o:p></o:p> > <o:p></o:p> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 522<o:p></o:p> > +++++++++++++++------<o:p></o:p> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 381<o:p></o:p> > ++++++++++++---<o:p></o:p> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 52 +-<o:p></o:p> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 18 +-<o:p></o:p> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 8 +-<o:p></o:p> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 8 +-<o:p></o:p> > MdeModulePkg/Include/Protocol/SdMmcOverride.h | 58 ++-<o:p></o:p> > 7 files changed, 802 insertions(+), 245 deletions(-)<o:p></o:p> > <o:p></o:p> > --<o:p></o:p> > 2.14.1.windows.1<o:p></o:p> <o:p> </o:p> </div> </div> --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. S&#322owackiego 173 | 80-298 Gda&#324sk | S&#261d Rejonowy Gda&#324sk P&#243&#322noc | VII Wydzia&#322 Gospodarczy Krajowego Rejestru S&#261dowego - KRS 101882 | NIP 957-07-52-316 | Kapita&#322 zak&#322adowy 200.000 PLN. <span style="font-size:8.0pt;font-family:"Arial Narrow","sans-serif"; mso-fareast-font-family:"Times New Roman";mso-bidi-font-family:Arial; color:#595959;mso-ansi-language:EN-US;mso-fareast-language:EN-US;mso-bidi-language: AR-SA">Ta wiadomo&#347&#263 wraz z za&#322&#261cznikami jest przeznaczona dla okre&#347lonego adresata i mo&#380e zawiera&#263 informacje poufne. W razie przypadkowego otrzymania tej wiadomo&#347ci, prosimy o powiadomienie nadawcy oraz trwa&#322e jej usuni&#281cie; jakiekolwiek przegl&#261danie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.<o:p></o:p> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/42365">View/Reply Online (#42365)</a> | | <a target="_blank" href="https://groups.io/mt/32052424/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>