<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:black;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">Hi Jian:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black"> Patch is good to me. Just one comment for coding style<o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:9.6pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">If
</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">(AlgInfo->HashAll (FvBuffer, (UINTN)FvInfo[FvIndex].Length, FvHashValue) == FALSE)<o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:9.6pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal" style="text-indent:9.6pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">Is it better to be
<span style="background:silver;mso-highlight:silver">if (!AlgInfo->HashAll (FvBuffer, (UINTN)FvInfo[FvIndex].Length, FvHashValue) )</span> ?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Wang, Jian J
<br>
<b>Sent:</b> Wednesday, June 26, 2019 1:34 PM<br>
<b>To:</b> Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io<br>
<b>Cc:</b> Zhang, Chao B <chao.b.zhang@intel.com>; Hernandez Beltran, Jorge <jorge.hernandez.beltran@intel.com>; Han, Harry <harry.han@intel.com><br>
<b>Subject:</b> RE: [PATCH v4 0/3] Common OBB verification feature<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">Thanks Jiewen. I'll add it with a few code style corrections.</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><br>
<br>
<span style="color:black">Anyone else has any comments?</span><br>
<br>
<span style="color:black">Regards,</span><br>
<span style="color:black">Jian</span><br>
<br>
<span style="color:purple">> -----Original Message-----</span><br>
<span style="color:purple">> From: Yao, Jiewen</span><br>
<span style="color:purple">> Sent: Tuesday, June 25, 2019 10:09 PM</span><br>
<span style="color:purple">> To: Wang, Jian J <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a></span><br>
<span style="color:purple">> Cc: Zhang, Chao B <<a href="mailto:chao.b.zhang@intel.com">chao.b.zhang@intel.com</a>>; Hernandez Beltran, Jorge</span><br>
<span style="color:purple">> <<a href="mailto:jorge.hernandez.beltran@intel.com">jorge.hernandez.beltran@intel.com</a>>; Han, Harry <<a href="mailto:harry.han@intel.com">harry.han@intel.com</a>></span><br>
<span style="color:purple">> Subject: RE: [PATCH v4 0/3] Common OBB verification feature</span><br>
<span style="color:purple">> </span><br>
<span style="color:purple">> Thanks Jian. Comment below:</span><br>
<span style="color:purple">> </span><br>
<span style="color:purple">> 1) My previous comment 8 is NOT addressed.</span><br>
<span style="color:purple">> </span><br>
<span style="color:purple">> Please add assert for "StoredHashFvPpi->FvNumber".</span><br>
<span style="color:purple">> if (!EFI_ERROR(Status) && StoredHashFvPpi != NULL && StoredHashFvPpi-</span><br>
<span style="color:blue">> >FvNumber > 0) {</span><br>
<span style="color:purple">> </span><br>
<span style="color:purple">> With that fixed, reviewed-by: <a href="mailto:Jiewen.yao@intel.com">Jiewen.yao@intel.com</a></span><br>
<span style="color:purple">> </span><br>
<span style="color:purple">> </span><br>
<span style="color:purple">> Thank you</span><br>
<span style="color:purple">> Yao Jiewen</span><br>
<span style="color:purple">> </span><br>
<span style="color:purple">> </span><br>
<span style="color:blue">> > -----Original Message-----</span><br>
<span style="color:blue">> > From: Wang, Jian J</span><br>
<span style="color:blue">> > Sent: Thursday, June 20, 2019 9:59 AM</span><br>
<span style="color:blue">> > To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a></span><br>
<span style="color:blue">> > Cc: Zhang, Chao B <<a href="mailto:chao.b.zhang@intel.com">chao.b.zhang@intel.com</a>>; Yao, Jiewen</span><br>
<span style="color:blue">> > <<a href="mailto:jiewen.yao@intel.com">jiewen.yao@intel.com</a>>; Hernandez Beltran, Jorge</span><br>
<span style="color:blue">> > <<a href="mailto:jorge.hernandez.beltran@intel.com">jorge.hernandez.beltran@intel.com</a>>; Han, Harry <<a href="mailto:harry.han@intel.com">harry.han@intel.com</a>></span><br>
<span style="color:blue">> > Subject: [PATCH v4 0/3] Common OBB verification feature</span><br>
<span style="color:blue">> ></span><br>
<span style="color:green">> > >V4: change FV_HASH_FLAG_BOOT_MODE definition</span><br>
<span style="color:blue">> ></span><br>
<span style="color:green">> > >V3: update per Jiewen's comments</span><br>
<span style="color:blue">> ></span><br>
<span style="color:green">> > >V2: fix parameter description error found by ECC</span><br>
<span style="color:blue">> ></span><br>
<span style="color:blue">> > <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=1617">https://bugzilla.tianocore.org/show_bug.cgi?id=1617</a></span><br>
<span style="color:blue">> ></span><br>
<span style="color:blue">> > Cc: Chao Zhang <<a href="mailto:chao.b.zhang@intel.com">chao.b.zhang@intel.com</a>></span><br>
<span style="color:blue">> > Cc: Jiewen Yao <<a href="mailto:jiewen.yao@intel.com">jiewen.yao@intel.com</a>></span><br>
<span style="color:blue">> > Cc: "Hernandez Beltran, Jorge" <<a href="mailto:jorge.hernandez.beltran@intel.com">jorge.hernandez.beltran@intel.com</a>></span><br>
<span style="color:blue">> > Cc: Harry Han <<a href="mailto:harry.han@intel.com">harry.han@intel.com</a>></span><br>
<span style="color:blue">> ></span><br>
<span style="color:blue">> > Jian J Wang (3):</span><br>
<span style="color:blue">> > SecurityPkg: add definitions for OBB verification</span><br>
<span style="color:blue">> > SecurityPkg/FvReportPei: implement a common FV verifier and reporter</span><br>
<span style="color:blue">> > SecurityPkg: add FvReportPei.inf in dsc for build validation</span><br>
<span style="color:blue">> ></span><br>
<span style="color:blue">> > SecurityPkg/FvReportPei/FvReportPei.c | 416</span><br>
<span style="color:blue">> > ++++++++++++++++++</span><br>
<span style="color:blue">> > SecurityPkg/FvReportPei/FvReportPei.h | 122 +++++</span><br>
<span style="color:blue">> > SecurityPkg/FvReportPei/FvReportPei.inf | 57 +++</span><br>
<span style="color:blue">> > SecurityPkg/FvReportPei/FvReportPei.uni | 14 +</span><br>
<span style="color:blue">> > .../FvReportPei/FvReportPeiPeiExtra.uni | 12 +</span><br>
<span style="color:blue">> > .../Ppi/FirmwareVolumeInfoStoredHashFv.h | 62 +++</span><br>
<span style="color:blue">> > SecurityPkg/SecurityPkg.dec | 9 +</span><br>
<span style="color:blue">> > SecurityPkg/SecurityPkg.dsc | 5 +</span><br>
<span style="color:blue">> > 8 files changed, 697 insertions(+)</span><br>
<span style="color:blue">> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.c</span><br>
<span style="color:blue">> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.h</span><br>
<span style="color:blue">> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.inf</span><br>
<span style="color:blue">> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.uni</span><br>
<span style="color:blue">> > create mode 100644 SecurityPkg/FvReportPei/FvReportPeiPeiExtra.uni</span><br>
<span style="color:blue">> > create mode 100644</span><br>
<span style="color:blue">> > SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h</span><br>
<span style="color:blue">> ></span><br>
<span style="color:blue">> > --</span><br>
<span style="color:blue">> > 2.17.1.windows.2</span><o:p></o:p></span></p>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/42874">View/Reply Online (#42874)</a> |
|
<a target="_blank" href="https://groups.io/mt/32139876/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>