<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="ProgId" content="Word.Document"> <meta name="Generator" content="Microsoft Word 14"> <meta name="Originator" content="Microsoft Word 14"> <link rel="File-List" href="cid:filelist.xml@01D52DCC.84D09C60"><style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="tab-interval:.5in"> <div class="WordSection1"> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D">Hello Marcin,<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D">I just realized that the series added 2 new bus modes (SdMmcSdDs and SdMmcSdHs) for 3.3V signaling SD card:<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D">Judging from your log:<o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span class="gmail-m-3630679886195089348spelle">SdCardSetBusMode</span>: Target bus mode: bus timing = 1, bus width = 4, clock <span class="gmail-m-3630679886195089348spelle">freq</span>[MHz] = 50, driver strength = 255<o:p></o:p></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D">which “bus timing = 1” means SdMmcSdHs (3.3V High Speed mode) is selected by the SdMmcPciHcDxe driver.<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D">So I have attached a patch to handle the 2 added bus modes in Silicon/Marvell/Drivers/SdMmc/XenonDxe/.<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D">Or you can get the patch at </span><a href="https://github.com/hwu25/edk2-platforms/tree/Marvell_XenonDxe">https://github.com/hwu25/edk2-platforms/tree/Marvell_XenonDxe</a><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D"><o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D">Please help to see if this solve your issue, thanks in advance.<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D;mso-no-proof:yes">Best Regards,<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D;mso-no-proof:yes">Hao Wu<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";mso-bidi-font-family:"Times New Roman";color:#1F497D"><o:p> </o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-font-family:"Times New Roman"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-font-family:"Times New Roman""> Marcin Wojtas [mailto:mw@semihalf.com] <br> <b>Sent:</b> Friday, June 28, 2019 3:42 PM<br> <b>To:</b> Wu, Hao A<br> <b>Cc:</b> Albecki, Mateusz; Sumit Garg; Ard Biesheuvel; edk2-devel-groups-io<br> <b>Subject:</b> Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">Hi Hao,<o:p></o:p></p> </div> <p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">pt., 28 cze 2019 o 09:23 Wu, Hao A <<a href="mailto:hao.a.wu@intel.com">hao.a.wu@intel.com</a>> napisał(a):<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;mso-border-left-alt:solid #CCCCCC .75pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hello Marcin,</span><o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Do you mean by only reverting as below:</span><o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">- <span class="gmail-m-3630679886195089348spelle">SdMmcCmdBlk.CommandArgument</span> = (<span class="gmail-m-3630679886195089348spelle">AccessMode</span> & 0xF) | ((<span class="gmail-m-3630679886195089348spelle">CommandSystem</span> & 0xF) << 4) | \<o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">- ((DriverStrength & 0xF) << 8) | ((<span class="gmail-m-3630679886195089348spelle">PowerLimit</span> & 0xF) << 12) | \<o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">+ <span class="gmail-m-3630679886195089348spelle">SdMmcCmdBlk.CommandArgument</span> = (<span class="gmail-m-3630679886195089348spelle">AccessMode</span> & 0xF) | ((<span class="gmail-m-3630679886195089348spelle">PowerLimit</span> & 0xF) << 4) | \^M<o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">+ ((DriverStrength & 0xF) << 8) | ((DriverStrength & 0xF) << 12) | \^M<o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <span class="gmail-m-3630679886195089348spelle">ModeValue</span>;<o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">All your devices work fine?</span><o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Since the origin code is clearly not correct (<span class="gmail-m-3630679886195089348spelle">DriveStrength</span> used 2 times,</span><o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">the offset of <span class="gmail-m-3630679886195089348spelle">PowerLimit</span> is not 4, should be 12 according to SD spec).</span><o:p></o:p></p> </div> </div> </blockquote> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">Ok, just rechecked. It doesn't help for my 1 problematic case. Anyway for the next time I think it may be worth to split some improvements out of such big patches.<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">I won't be able to debug my board until second week of July (at best), so in order not to block you please go ahead with merging (the most important board (MacchiatoBin) seems not suffer any regression).<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">Best regards,<o:p></o:p></p> </div> <div> <p class="MsoNormal">Marcin<o:p></o:p></p> </div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;mso-border-left-alt:solid #CCCCCC .75pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Best Regards,</span><o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hao Wu</span><o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Marcin Wojtas [mailto:<a href="mailto:mw@semihalf.com" target="_blank">mw@semihalf.com</a>] <br> <b>Sent:</b> Friday, June 28, 2019 2:33 PM<br> <b>To:</b> Wu, Hao A; Albecki, Mateusz<br> <b>Cc:</b> Sumit Garg; Ard Biesheuvel; edk2-devel-groups-io<br> <b>Subject:</b> Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/<span class="gmail-m-3630679886195089348spelle">SdMmcHcDxe</span>: Implement revision 3 of <span class="gmail-m-3630679886195089348spelle">SdMmcOverrideProtocol</span></span><o:p></o:p></p> </div> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <div> <div> <div> <div> <div> <div> <div> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Hi,<o:p></o:p></p> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">I was almost happily sending you email with 'tested-by' information, but I checked 3 boards:<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Board 1 (out of tree): SD - OK, MMC - OK<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Board 2: (Armada80x0McBin): SD - OK, MMC - OK<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Board 3: (Armada70x0Db): SD - problems, MMC - OK<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">In the latter case I get stall and booting takes around 3 minutes.<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Without "MdeModulePkg/<span class="gmail-m-3630679886195089348spelle">SdMmcHcDxe</span>: Implement revision 3 of <span class="gmail-m-3630679886195089348spelle">SdMmcOverrideProtocol</span>" patch it works as before.<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">I enabled debugs, and in theory everything seems fine, the DriverStrength is set to EDKII_SD_MMC_DRIVER_STRENGTH_IGNORE.<o:p></o:p></p> </div> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span class="gmail-m-3630679886195089348spelle">SdCardIdentification</span>: Found a SD device at slot [0]<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span class="gmail-m-3630679886195089348spelle">SdCardSetBusMode</span>: Target bus mode: bus timing = 1, bus width = 4, clock <span class="gmail-m-3630679886195089348spelle">freq</span>[MHz] = 50, driver strength = 255<o:p></o:p></p> </div> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">However right after <span class="gmail-m-3630679886195089348spelle">Csd</span> register dump the booting stalls until printing following and continuing:<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span class="gmail-m-3630679886195089348spelle">FatOpenDevice</span>: read of <span class="gmail-m-3630679886195089348spelle">part_lba</span> failed Time out<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">This is absent from the prints I dumped from vanilla kernel. Despite I currently really have no time to additional debug, I checked and with following diff, everything works as before:<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">--- a/MdeModulePkg/Bus/<span class="gmail-m-3630679886195089348spelle">Pci</span>/SdMmcPciHcDxe/<span class="gmail-m-3630679886195089348spelle">SdDevice.c</span><o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">+++ b/MdeModulePkg/Bus/<span class="gmail-m-3630679886195089348spelle">Pci</span>/SdMmcPciHcDxe/<span class="gmail-m-3630679886195089348spelle">SdDevice.c</span><o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">@@ -536,8 +536,8 @@ <span class="gmail-m-3630679886195089348spelle">SdCardSwitch</span> (<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <span class="gmail-m-3630679886195089348spelle">AccessMode</span> = 0xF;<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> }<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">- <span class="gmail-m-3630679886195089348spelle">SdMmcCmdBlk.CommandArgument</span> = (<span class="gmail-m-3630679886195089348spelle">AccessMode</span> & 0xF) | ((<span class="gmail-m-3630679886195089348spelle">CommandSystem</span> & 0xF) << 4) | \<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">- ((DriverStrength & 0xF) << 8) | ((<span class="gmail-m-3630679886195089348spelle">PowerLimit</span> & 0xF) << 12) | \<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">+ <span class="gmail-m-3630679886195089348spelle">SdMmcCmdBlk.CommandArgument</span> = (<span class="gmail-m-3630679886195089348spelle">AccessMode</span> & 0xF) | ((<span class="gmail-m-3630679886195089348spelle">PowerLimit</span> & 0xF) << 4) | \^M<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">+ ((DriverStrength & 0xF) << 8) | ((DriverStrength & 0xF) << 12) | \^M<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <span class="gmail-m-3630679886195089348spelle">ModeValue</span>;<o:p></o:p></p> </div> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Above is restoring <span class="gmail-m-3630679886195089348spelle">SdMmcCmdBlk.CommandArgument</span> to the state from before the patch in question. Now the question - why the layout of the command changed? <span class="gmail-m-3630679886195089348spelle">CommandSystem</span> was unused before, and <span class="gmail-m-3630679886195089348spelle">PowerLimit</span> changed its position. Is this change really related to the rest of the patch? What is the justification?<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Best regards,<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Marcin<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">pt., 28 <span class="gmail-m-3630679886195089348spelle">cze</span> 2019 o 02:57 Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" target="_blank">hao.a.wu@intel.com</a>> <span class="gmail-m-3630679886195089348spelle">napisał</span>(a):<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt"> <p class="MsoNormal" style="mso-margin-top-alt:auto;margin-bottom:12.0pt">> -----Original Message-----<br> > From: Sumit Garg [mailto:<a href="mailto:sumit.garg@linaro.org" target="_blank">sumit.garg@linaro.org</a>]<br> > Sent: Thursday, June 27, 2019 9:39 PM<br> > To: Ard Biesheuvel<br> > Cc: edk2-devel-groups-io; Wu, Hao A; Marcin Wojtas; Albecki, Mateusz<br> > Subject: Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/<span class="gmail-m-3630679886195089348spelle">SdMmcHcDxe</span>:<br> > Implement revision 3 of <span class="gmail-m-3630679886195089348spelle">SdMmcOverrideProtocol</span><br> > <br> > On Thu, 27 Jun 2019 at 13:40, Ard Biesheuvel <<a href="mailto:ard.biesheuvel@linaro.org" target="_blank">ard.biesheuvel@linaro.org</a>><br> > wrote:<br> > ><br> > > (+ Sumit)<br> > ><br> > > On Thu, 27 Jun 2019 at 08:29, Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" target="_blank">hao.a.wu@intel.com</a>> wrote:<br> > > ><br> > > > > -----Original Message-----<br> > > > > From: Marcin Wojtas [mailto:<a href="mailto:mw@semihalf.com" target="_blank">mw@semihalf.com</a>]<br> > > > > Sent: Thursday, June 27, 2019 2:25 PM<br> > > > > To: Albecki, Mateusz<br> > > > > Cc: edk2-devel-groups-io; Wu, Hao A<br> > > > > Subject: Re: [edk2-devel] [PATCH v4 0/2]<br> > MdeModulePkg/<span class="gmail-m-3630679886195089348spelle">SdMmcHcDxe</span>:<br> > > > > Implement revision 3 of <span class="gmail-m-3630679886195089348spelle">SdMmcOverrideProtocol</span><br> > > > ><br> > > > > Hi Mateusz,<br> > > > ><br> > > > > Can you please push those patches somewhere (<span class="gmail-m-3630679886195089348spelle">github</span>?) so that I can<br> > > > > easily do a quick check for regression?<br> > > > ><br> > > > > Thanks,<br> > > > > Marcin<br> > > ><br> > > ><br> > > > Hello Marcin,<br> > > ><br> > > > I have just pushed the series at:<br> > > > <a href="https://github.com/hwu25/edk2/tree/sdmmc_override_extend_v4" target="_blank"> https://github.com/hwu25/edk2/tree/sdmmc_override_extend_v4</a><br> > > ><br> > > > Please help to check.<br> > > ><br> > ><br> > > I have <span class="gmail-m-3630679886195089348spelle">cc'ed</span> my colleague Sumit, who has kindly agreed to regression<br> > > test this branch on <span class="gmail-m-3630679886195089348spelle">Socionext</span> <span class="gmail-m-3630679886195089348spelle">SynQuacer</span>, which also uses the SD/MMC<br> > > override infrastructure.<br> > ><br> > > Sumit, please reply here with your results. And thanks again!<br> > <br> > I did picked this patch-set and applied on top of edk2 master branch.<br> > It works well on <span class="gmail-m-3630679886195089348spelle">SynQuacer</span> with eMMC device enumerated properly and<br> > all three eMMC partitions are visible:<br> > <br> > BLK4: Alias(s):<br> > <span class="gmail-m-3630679886195089348spelle">VenHw</span>(0D51905B-B77E-452A-A2C0-<br> > ECA0CC8D514A,000030520000000000)/eMMC(0x<br> > 0)/Ctrl(0x0)<br> > BLK5: Alias(s):<br> > <span class="gmail-m-3630679886195089348spelle">VenHw</span>(0D51905B-B77E-452A-A2C0-<br> > ECA0CC8D514A,000030520000000000)/eMMC(0x<br> > 0)/Ctrl(0x1)<br> > BLK6: Alias(s):<br> > <span class="gmail-m-3630679886195089348spelle">VenHw</span>(0D51905B-B77E-452A-A2C0-<br> > ECA0CC8D514A,000030520000000000)/eMMC(0x<br> > 0)/Ctrl(0x2)<br> > <br> > Shell> devices<br> > <snip><br> > E9 D - - 1 1 0 <span class="gmail-m-3630679886195089348spelle">VenHw</span>(0D51905B-B77E-452A-A2C0-<br> > ECA0CC8D514A,0000305200000000<br> > 00)/eMMC(0x0)/Ctrl(0x0)<br> > EA D - - 1 1 0 <span class="gmail-m-3630679886195089348spelle">VenHw</span>(0D51905B-B77E-452A-A2C0-<br> > ECA0CC8D514A,0000305200000000<br> > 00)/eMMC(0x0)/Ctrl(0x1)<br> > EB D - - 1 1 0 <span class="gmail-m-3630679886195089348spelle">VenHw</span>(0D51905B-B77E-452A-A2C0-<br> > ECA0CC8D514A,0000305200000000<br> > 00)/eMMC(0x0)/Ctrl(0x2)<br> > <br> > So you can add following:<br> > <br> > Regression-tested-by: Sumit Garg <<a href="mailto:sumit.garg@linaro.org" target="_blank">sumit.garg@linaro.org</a>><br> <br> <br> Thanks a lot for the testing.<br> <br> Best Regards,<br> Hao Wu<br> <br> <br> > <br> > -Sumit<br> <br> <o:p></o:p></p> </blockquote> </div> </div> </div> </div> </blockquote> </div> </div> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/42995">View/Reply Online (#42995)</a> | | <a target="_blank" href="https://groups.io/mt/32214570/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>