<div id="contentDescription" style="line-height:1.5;text-align:justify;text-justify:inter-ideograph">
<div id="contentDescription" style="line-height:1.5;text-align:justify;text-justify:inter-ideograph">
<div>Hi,</div><div><br></div><div> I think the license of FCE is not correct(Should be BSD-2-Clause-Patent). And the logic for ARCH("ifndef ARCH") can be deleted.</div><div><br></div><div> I deleted the ARCH related lines and it did built. </div><div><br></div><div>Best Regards,</div><div>Hiber</div><div><br></div><div> </div>
<div><br></div>
<div class="NETEASEMAILMASTERLOCALSIGNATURE" contenteditable="false">
<div id="imail_signature"></div>
</div>
<div class="J-reply" style="background-color:#f2f2f2;color:black;padding-top:6px;padding-bottom:6px;border-radius:3px;-moz-border-radius:3px;-webkit-border-radius:3px;margin-top:45px;margin-bottom:20px;"><div style="font-size:14px;line-height:1.5;word-break:break-all;margin-left:10px;margin-right:10px">On <span class="mail-date">07/05/2019 18:34</span>, <a class="mail-to" style="text-decoration:none;color:#2a97ff;" href="mailto:leif.lindholm@linaro.org">Leif Lindholm</a> wrote: </div></div><blockquote id="ntes-iosmail-quote" style="margin:0">Commit 3c59d94637ad ("BaseTools/FCE: Add a tool FCE") added a new tool
<br>that is always built. Pre-existing tools locate the makefile includes
<br>with relative paths, but FCE uses EDK_TOOLS_PATH, adding a new dependency
<br>on having sourced edksetup.sh before building BaseTools.
<br>
<br>Change FCE GNUmakefile to match other tools.
<br>
<br>Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
<br>---
<br>
<br>This broke our CI setup, so I'd appreciate if it could be merged quickly.
<br>
<br> BaseTools/Source/C/FCE/GNUmakefile | 2 +-
<br> 1 file changed, 1 insertion(+), 1 deletion(-)
<br>
<br>diff --git a/BaseTools/Source/C/FCE/GNUmakefile b/BaseTools/Source/C/FCE/GNUmakefile
<br>index 3e1b6a85e2..7a7e1ef4b8 100644
<br>--- a/BaseTools/Source/C/FCE/GNUmakefile
<br>+++ b/BaseTools/Source/C/FCE/GNUmakefile
<br>@@ -42,7 +42,7 @@ endif
<br> export ARCH
<br> export HOST_ARCH=$(ARCH)
<br>
<br>-MAKEROOT ?= $(EDK_TOOLS_PATH)/Source/C
<br>+MAKEROOT ?= ..
<br>
<br> APPNAME = FCE
<br>
<br>--
<br>2.11.0
<br>
<br>
<br>
<br></blockquote>
</div>
</div>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/43350">View/Reply Online (#43350)</a> |
|
<a target="_blank" href="https://groups.io/mt/32316137/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>