<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:SimSun;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:SimSun;}
span.mail-date
{mso-style-name:mail-date;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks for your catch. Yes. This is an issue. I will send the patch to clean it.
<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D">For this patch, the change is good. Reviewed-by: Liming Gao <liming.gao@intel.com><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> devel@edk2.groups.io [mailto:devel@edk2.groups.io]
<b>On Behalf Of </b>Hiber He<br>
<b>Sent:</b> Friday, July 5, 2019 7:26 PM<br>
<b>To:</b> devel <devel@edk2.groups.io>; leif.lindholm <leif.lindholm@linaro.org><br>
<b>Subject:</b> Re: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span lang="EN-US">Hi,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span lang="EN-US"> I think the license of FCE is not correct(Should be BSD-2-Clause-Patent). And the logic for ARCH("ifndef ARCH") can be deleted.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span lang="EN-US"> I deleted the ARCH related lines and it did built. <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span lang="EN-US">Best Regards,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span lang="EN-US">Hiber<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span lang="EN-US"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<div style="margin-top:33.75pt;margin-bottom:15.0pt;border-radius:3px;-moz-border-radius:3px;-webkit-border-radius:3px">
<div style="margin-left:7.5pt;margin-right:7.5pt">
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph;background:#F2F2F2;word-break:break-all">
<span lang="EN-US" style="font-size:10.5pt;color:black">On <span class="mail-date">
07/05/2019 18:34</span>, <a href="mailto:leif.lindholm@linaro.org"><span style="color:#2A97FF;text-decoration:none">Leif Lindholm</span></a> wrote:
<o:p></o:p></span></p>
</div>
</div>
<blockquote id="ntes-iosmail-quote">
<p class="MsoNormal" style="margin-bottom:12.0pt;text-align:justify;text-justify:inter-ideograph">
<span lang="EN-US">Commit 3c59d94637ad ("BaseTools/FCE: Add a tool FCE") added a new tool
<br>
that is always built. Pre-existing tools locate the makefile includes <br>
with relative paths, but FCE uses EDK_TOOLS_PATH, adding a new dependency <br>
on having sourced edksetup.sh before building BaseTools. <br>
<br>
Change FCE GNUmakefile to match other tools. <br>
<br>
Signed-off-by: Leif Lindholm <<a href="mailto:leif.lindholm@linaro.org">leif.lindholm@linaro.org</a>>
<br>
--- <br>
<br>
This broke our CI setup, so I'd appreciate if it could be merged quickly. <br>
<br>
BaseTools/Source/C/FCE/GNUmakefile | 2 +- <br>
1 file changed, 1 insertion(+), 1 deletion(-) <br>
<br>
diff --git a/BaseTools/Source/C/FCE/GNUmakefile b/BaseTools/Source/C/FCE/GNUmakefile
<br>
index 3e1b6a85e2..7a7e1ef4b8 100644 <br>
--- a/BaseTools/Source/C/FCE/GNUmakefile <br>
+++ b/BaseTools/Source/C/FCE/GNUmakefile <br>
@@ -42,7 +42,7 @@ endif <br>
export ARCH <br>
export HOST_ARCH=$(ARCH) <br>
<br>
-MAKEROOT ?= $(EDK_TOOLS_PATH)/Source/C <br>
+MAKEROOT ?= .. <br>
<br>
APPNAME = FCE <br>
<br>
-- <br>
2.11.0 <br>
<br>
<br>
<o:p></o:p></span></p>
</blockquote>
<div>
<p class="MsoNormal"></o:p></span></p>
</div>
</div>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/43356">View/Reply Online (#43356)</a> |
|
<a target="_blank" href="https://groups.io/mt/32316137/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>