<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Tested-by: Andrew Fish <<a href="mailto:afish@apple.com" class="">afish@apple.com</a>><div class=""> </div><div class="">I tested the XCODE builds of the emulator and made sure that source level debugging worked probably for builds that generate symbols. </div><div class=""> </div><div class="">Thanks,</div><div class=""> </div><div class="">Andrew Fish <div> <blockquote type="cite" class=""><div class="">On Aug 16, 2019, at 8:09 AM, Michael D Kinney <<a href="mailto:michael.d.kinney@intel.com" class="">michael.d.kinney@intel.com</a>> wrote:</div> <div class=""><div class="">Jordan, It is not a typo. Andrew generated the XCODE specific changes, so they have been tested by him. I have also reviewed and tested the XCODE changes and verified that all 6 combinations build and boot to shell (IA32/X64 for RELEASE/DEBUG/NOOPT). Since they are all related to making EmulatorPkg work, we decided to fold them into the same patch set that was already being reviewed. I also verified build and boot to shell for 6 combinations on GCC5 (IA32/X64 for RELEASE/DEBUG/NOOPT) and the 12 combinations of VS2015/VS2017, IA323/X64, RELEASE/DEBUG/NOOPT. I have been working on some CI experiments using Azure Pipelines. Here is a pointer to the build logs for all the combinations listed above. <a href="https://dev.azure.com/mikekinney/edk2-ci/_build/results?buildId=312" class="">https://dev.azure.com/mikekinney/edk2-ci/_build/results?buildId=312</a> Mike <blockquote type="cite" class="">-----Original Message----- From: Justen, Jordan L Sent: Friday, August 16, 2019 12:41 AM To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io Cc: Ni, Ray <ray.ni@intel.com>; Andrew Fish <afish@apple.com> Subject: Re: [Patch V4 06/10] EmulatorPkg: Fix XCODE5 lldb issues On 2019-08-15 19:14:33, Michael D Kinney wrote: <blockquote type="cite" class="">Fix scripts to support lldb symbolic debugging when </blockquote>using XCODE5 tool <blockquote type="cite" class="">chain. Cc: Jordan Justen <jordan.l.justen@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Signed-off-by: Andrew Fish <afish@apple.com> </blockquote> Is this a Cc/Signed-off-by typo? (See also, patches 7- 10). This makes me wonder if you are taking advantage of the git commit -s switch to add your Signed-off-by. Also, I'm wondering if you are taking advantage of git- send-email automatically Cc'ing the addresses you listed in the commit message. (I thought it Cc'd for the author and Cc tags, but I wasn't sure about the Signed-off-by tag, and yet I see Andrew was Cc'd.) There's a couple long lines below. You could use \ at the end of the line to split the .sh line. I think the cd can be a separate command in a shell script. (Not in make) I hope someone that uses the XCODE toolchain could review/check the XCODE patches. -Jordan <blockquote type="cite" class="">--- EmulatorPkg/Unix/lldbefi.py | 8 +++++--- EmulatorPkg/build.sh | 17 ++--------------- 2 files changed, 7 insertions(+), 18 deletions(-) diff --git a/EmulatorPkg/Unix/lldbefi.py </blockquote>b/EmulatorPkg/Unix/lldbefi.py <blockquote type="cite" class="">index 218326b8cb..099192d8b5 100755 --- a/EmulatorPkg/Unix/lldbefi.py +++ b/EmulatorPkg/Unix/lldbefi.py @@ -346,6 +346,7 @@ def TypePrintFormating(debugger): debugger.HandleCommand("type summary add CHAR8 - </blockquote>-python-function lldbefi.CHAR8_TypeSummary") <blockquote type="cite" class=""> debugger.HandleCommand('type summary add --regex </blockquote>"CHAR8 <blockquote type="cite" class="">\[[0-9]+\]" --python-function </blockquote>lldbefi.CHAR8_TypeSummary') <blockquote type="cite" class=""> + debugger.HandleCommand('setting set frame-format </blockquote>"frame <blockquote type="cite" class="">+ #${frame.index}: ${frame.pc}{ + </blockquote>${module.file.basename}{:${function.name}()${function.p c-offset}}}{ <blockquote type="cite" class="">+ at ${line.file.fullpath}:${line.number}}\n"') gEmulatorBreakWorkaroundNeeded = True @@ -381,15 +382,16 @@ def </blockquote>LoadEmulatorEfiSymbols(frame, bp_loc , internal_dict): <blockquote type="cite" class=""> Error = lldb.SBError() FileNamePtr = frame.FindVariable </blockquote>("FileName").GetValueAsUnsigned() <blockquote type="cite" class=""> FileNameLen = frame.FindVariable ("FileNameLength").GetValueAsUnsigned() + FileName = </blockquote>frame.thread.process.ReadCStringFromMemory (FileNamePtr, FileNameLen, Error) <blockquote type="cite" class=""> if not Error.Success(): print "!ReadCStringFromMemory() did not find </blockquote>a %d byte C string at %x" % (FileNameLen, FileNamePtr) <blockquote type="cite" class=""> # make breakpoint command contiue - frame.GetThread().GetProcess().Continue() + return False debugger = frame.thread.process.target.debugger if frame.FindVariable </blockquote>("AddSymbolFlag").GetValueAsUnsigned() == 1: <blockquote type="cite" class="">- LoadAddress = frame.FindVariable </blockquote>("LoadAddress").GetValueAsUnsigned() <blockquote type="cite" class="">+ LoadAddress = frame.FindVariable + ("LoadAddress").GetValueAsUnsigned() - 0x240 debugger.HandleCommand ("target modules add </blockquote>%s" % FileName) <blockquote type="cite" class=""> print "target modules load --slid 0x%x %s" % </blockquote>(LoadAddress, <blockquote type="cite" class="">FileName) @@ -405,7 +407,7 @@ def </blockquote>LoadEmulatorEfiSymbols(frame, bp_loc , internal_dict): <blockquote type="cite" class=""> print "!lldb.target.RemoveModule </blockquote>(%s) FAILED" % <blockquote type="cite" class="">SBModule # make breakpoint command contiue - frame.thread.process.Continue() + return False def GuidToCStructStr (guid, Name=False): # diff --git a/EmulatorPkg/build.sh </blockquote>b/EmulatorPkg/build.sh index <blockquote type="cite" class="">60056e1b6c..35912a7775 100755 --- a/EmulatorPkg/build.sh +++ b/EmulatorPkg/build.sh @@ -209,21 +209,8 @@ fi if [[ "$RUN_EMULATOR" == "yes" ]]; then case `uname` in Darwin*) - # - # On Darwin we can't use dlopen, so we have to </blockquote>load the real PE/COFF images. <blockquote type="cite" class="">- # This .gdbinit script sets a breakpoint that </blockquote>loads symbols for the PE/COFFEE <blockquote type="cite" class="">- # images that get loaded in Host - # - if [[ "$CLANG_VER" == *-ccc-host-triple* ]] - then - # only older versions of Xcode support -ccc- </blockquote>host-tripe, for newer versions <blockquote type="cite" class="">- # it is -target - cp $WORKSPACE/EmulatorPkg/Unix/lldbefi.py </blockquote>"$BUILD_OUTPUT_DIR/${BUILDTARGET}_$TARGET_TOOLS/$PROCES SOR" <blockquote type="cite" class="">- cd $BUILD_ROOT_ARCH; /usr/bin/lldb --source </blockquote>$WORKSPACE/EmulatorPkg/Unix/lldbinit Host <blockquote type="cite" class="">- exit $? - else - cp $WORKSPACE/EmulatorPkg/Unix/.gdbinit </blockquote>"$BUILD_OUTPUT_DIR/${BUILDTARGET}_$TARGET_TOOLS/$PROCES SOR" <blockquote type="cite" class="">- fi + cd $BUILD_ROOT_ARCH; /usr/bin/lldb -o "command </blockquote>script import $WORKSPACE/EmulatorPkg/Unix/lldbefi.py" - o 'script lldb.debugger.SetAsync(True)' -o "run" ./Host <blockquote type="cite" class="">+ exit $? ;; esac -- 2.21.0.windows.1 </blockquote></blockquote> </div></div></blockquote></div> </div></body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/45837">View/Reply Online (#45837)</a> | | <a target="_blank" href="https://groups.io/mt/32894351/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>