<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Trebuchet MS";
panose-1:2 11 6 3 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi Liming, <o:p></o:p></p>
<p class="MsoNormal">per your recommendation,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the below [PATCH v2] and the commit can be found in:
<a href="mailto:git@github.com:JayRaghuram/edk2.git">git@github.com:JayRaghuram/edk2.git</a> (<a href="https://github.com/JayRaghuram/edk2">https://github.com/JayRaghuram/edk2</a>)<o:p></o:p></p>
<p class="MsoNormal">REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2138<o:p></o:p></p>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="100%" align="center">
</div>
<p class="MsoNormal">From 95c48454d6d14cb7537dec98d58f7dc01efa644e Mon Sep 17 00:00:00 2001<o:p></o:p></p>
<p class="MsoNormal">Message-Id: <95c48454d6d14cb7537dec98d58f7dc01efa644e.1567095734.git.Jayanth_Raghuram@Dell.com><o:p></o:p></p>
<p class="MsoNormal">From: Jayanth Raghuram <Jayanth_Raghuram@Dell.com><o:p></o:p></p>
<p class="MsoNormal">Date: Thu, 29 Aug 2019 11:17:09 -0500<o:p></o:p></p>
<p class="MsoNormal">Subject: [PATCH v2] MdePkg/DxeHstiLib: Added checks to improve error handling.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2138<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Added checks for return parameters of GetSupportedTypes<o:p></o:p></p>
<p class="MsoNormal">function calls in InternalHstiFindAip to improve error handling.<o:p></o:p></p>
<p class="MsoNormal">An issue was observed on Dell Poweredge R740, where the Dell<o:p></o:p></p>
<p class="MsoNormal">PERC H740P controller UEFI driver returned InfoTypesBuffer = NULL,<o:p></o:p></p>
<p class="MsoNormal">InfoTypesBufferCount = 0 and caused an FreePool assert.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Signed-off-by: Jayanth Raghuram <Jayanth.Raghuram@Dell.com><o:p></o:p></p>
<p class="MsoNormal">Cc: Wei G Liu <Wei_G_Liu@Dell.com><o:p></o:p></p>
<p class="MsoNormal">---<o:p></o:p></p>
<p class="MsoNormal">MdePkg/Library/DxeHstiLib/HstiDxe.c | 2 +-<o:p></o:p></p>
<p class="MsoNormal">1 file changed, 1 insertion(+), 1 deletion(-)<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">diff --git a/MdePkg/Library/DxeHstiLib/HstiDxe.c b/MdePkg/Library/DxeHstiLib/HstiDxe.c<o:p></o:p></p>
<p class="MsoNormal">index 9466e3dcb3..4e1c67616b 100644<o:p></o:p></p>
<p class="MsoNormal">--- a/MdePkg/Library/DxeHstiLib/HstiDxe.c<o:p></o:p></p>
<p class="MsoNormal">+++ b/MdePkg/Library/DxeHstiLib/HstiDxe.c<o:p></o:p></p>
<p class="MsoNormal">@@ -77,7 +77,7 @@ InternalHstiFindAip (<o:p></o:p></p>
<p class="MsoNormal"> &InfoTypesBuffer,<o:p></o:p></p>
<p class="MsoNormal"> &InfoTypesBufferCount<o:p></o:p></p>
<p class="MsoNormal"> );<o:p></o:p></p>
<p class="MsoNormal">- if (EFI_ERROR (Status)) {<o:p></o:p></p>
<p class="MsoNormal">+ if (EFI_ERROR (Status) || (InfoTypesBuffer == NULL) || (InfoTypesBufferCount == 0)) {<o:p></o:p></p>
<p class="MsoNormal"> continue;<o:p></o:p></p>
<p class="MsoNormal"> }<o:p></o:p></p>
<p class="MsoNormal"><o:p></o:p></p>
<p class="MsoNormal">-- <o:p></o:p></p>
<p class="MsoNormal">2.19.1.windows.1<o:p></o:p></p>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="100%" align="center">
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Jayanth Raghuram<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><b><span lang="NO-BOK" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#007CB9">Dell</span></b><b><span lang="NO-BOK" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:gray">EMC</span></b><b><span lang="NO-BOK" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#007CB9">
</span></b><b><span lang="NO-BOK" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#1F497D">|
</span></b><span style="font-size:8.0pt;font-family:"Trebuchet MS",sans-serif;color:#444444">Server Platform BIOS</span><span lang="NO-BOK" style="font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:8.0pt;font-family:"Trebuchet MS",sans-serif;color:#444444">office</span></b><span style="font-size:8.0pt;font-family:"Trebuchet MS",sans-serif;color:#AAAAAA">
</span><span style="font-size:8.0pt;font-family:"Trebuchet MS",sans-serif;color:#444444">+ 1 512 723 1470<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/46579">View/Reply Online (#46579)</a> |
|
<a target="_blank" href="https://groups.io/mt/33071679/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>