<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Trebuchet MS";
panose-1:2 11 6 3 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;color:#1F497D">Push @</span><span lang="EN-US" style="font-size:8.5pt;font-family:"Courier New"">17f8c9e97d770c74f84194576bcd97322fbed21e</span><span lang="EN-US" style="font-size:10.5pt;color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span lang="EN-US" style="font-size:10.5pt;color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span lang="EN-US">From:</span></b><span lang="EN-US"> devel@edk2.groups.io [mailto:devel@edk2.groups.io]
<b>On Behalf Of </b>Liming Gao<br>
<b>Sent:</b> Monday, September 2, 2019 12:15 PM<br>
<b>To:</b> devel@edk2.groups.io; Jayanth.Raghuram@dell.com<br>
<b>Subject:</b> Re: [edk2-devel] Subject: [PATCH v2] MdePkg/DxeHstiLib: Added checks to improve error handling.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;color:#1F497D">This change is good to me. Reviewed-by: Liming Gao <<a href="mailto:liming.gao@intel.com">liming.gao@intel.com</a>><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> <a href="mailto:devel@edk2.groups.io">
devel@edk2.groups.io</a> [<a href="mailto:devel@edk2.groups.io">mailto:devel@edk2.groups.io</a>]
<b>On Behalf Of </b><a href="mailto:Jayanth.Raghuram@dell.com">Jayanth.Raghuram@dell.com</a><br>
<b>Sent:</b> Friday, August 30, 2019 12:32 AM<br>
<b>To:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><br>
<b>Subject:</b> [edk2-devel] Subject: [PATCH v2] MdePkg/DxeHstiLib: Added checks to improve error handling.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Hi Liming, <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">per your recommendation,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Please review the below [PATCH v2] and the commit can be found in:
<a href="mailto:git@github.com:JayRaghuram/edk2.git">git@github.com:JayRaghuram/edk2.git</a> (<a href="https://github.com/JayRaghuram/edk2">https://github.com/JayRaghuram/edk2</a>)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2138<o:p></o:p></span></p>
<div class="MsoNormal" align="center" style="text-align:center"><span lang="EN-US">
<hr size="2" width="100%" align="center">
</span></div>
<p class="MsoNormal"><span lang="EN-US">From 95c48454d6d14cb7537dec98d58f7dc01efa644e Mon Sep 17 00:00:00 2001<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Message-Id: <<a href="mailto:95c48454d6d14cb7537dec98d58f7dc01efa644e.1567095734.git.Jayanth_Raghuram@Dell.com">95c48454d6d14cb7537dec98d58f7dc01efa644e.1567095734.git.Jayanth_Raghuram@Dell.com</a>><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">From: Jayanth Raghuram <<a href="mailto:Jayanth_Raghuram@Dell.com">Jayanth_Raghuram@Dell.com</a>><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Date: Thu, 29 Aug 2019 11:17:09 -0500<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Subject: [PATCH v2] MdePkg/DxeHstiLib: Added checks to improve error handling.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2138<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Added checks for return parameters of GetSupportedTypes<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">function calls in InternalHstiFindAip to improve error handling.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">An issue was observed on Dell Poweredge R740, where the Dell<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">PERC H740P controller UEFI driver returned InfoTypesBuffer = NULL,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">InfoTypesBufferCount = 0 and caused an FreePool assert.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Signed-off-by: Jayanth Raghuram <<a href="mailto:Jayanth.Raghuram@Dell.com">Jayanth.Raghuram@Dell.com</a>><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Cc: Wei G Liu <<a href="mailto:Wei_G_Liu@Dell.com">Wei_G_Liu@Dell.com</a>><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">---<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">MdePkg/Library/DxeHstiLib/HstiDxe.c | 2 +-<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">1 file changed, 1 insertion(+), 1 deletion(-)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">diff --git a/MdePkg/Library/DxeHstiLib/HstiDxe.c b/MdePkg/Library/DxeHstiLib/HstiDxe.c<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">index 9466e3dcb3..4e1c67616b 100644<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">--- a/MdePkg/Library/DxeHstiLib/HstiDxe.c<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+++ b/MdePkg/Library/DxeHstiLib/HstiDxe.c<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">@@ -77,7 +77,7 @@ InternalHstiFindAip (<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> &InfoTypesBuffer,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> &InfoTypesBufferCount<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> );<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- if (EFI_ERROR (Status)) {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ if (EFI_ERROR (Status) || (InfoTypesBuffer == NULL) || (InfoTypesBufferCount == 0)) {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> continue;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">-- <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">2.19.1.windows.1<o:p></o:p></span></p>
<div class="MsoNormal" align="center" style="text-align:center"><span lang="EN-US">
<hr size="2" width="100%" align="center">
</span></div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Jayanth Raghuram<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><b><span lang="NO-BOK" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#007CB9">Dell</span></b><b><span lang="NO-BOK" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:gray">EMC</span></b><b><span lang="NO-BOK" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#007CB9">
</span></b><b><span lang="NO-BOK" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#1F497D">|
</span></b><span lang="EN-US" style="font-size:8.0pt;font-family:"Trebuchet MS",sans-serif;color:#444444">Server Platform BIOS</span><span lang="NO-BOK" style="font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:8.0pt;font-family:"Trebuchet MS",sans-serif;color:#444444">office</span></b><span lang="EN-US" style="font-size:8.0pt;font-family:"Trebuchet MS",sans-serif;color:#AAAAAA">
</span><span lang="EN-US" style="font-size:8.0pt;font-family:"Trebuchet MS",sans-serif;color:#444444">+ 1 512 723 1470<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"></o:p></span></p>
</div>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/46680">View/Reply Online (#46680)</a> |
|
<a target="_blank" href="https://groups.io/mt/33071679/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>