<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72"> <div class="WordSection1"> <a name="_MailEndCompose">Hi Derek,<o:p></o:p></a> Thank you to raise this issue. We will fix it and add back the --hash original functionality.<o:p></o:p> <o:p> </o:p> <div> <o:p> </o:p> Thanks<o:p></o:p> Steven<o:p></o:p> </div> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> <a name="_____replyseparator"></a>From: Lin, Derek (HPS SW) [mailto:derek.lin2@hpe.com] Sent: Friday, September 20, 2019 2:54 PM To: devel@edk2.groups.io Cc: Feng, Bob C <bob.c.feng@intel.com>; Shi, Steven <steven.shi@intel.com> Subject: BaseTools --hash malfunction after migrate from stable201905 to stable201908<o:p></o:p> </div> </div> <o:p> </o:p> Hi BaseTools experts,<o:p></o:p> <o:p> </o:p> We saw the clean build performance improvement after updating from edk2-stable201905 to edk2-stable201908, which is promising.<o:p></o:p> But we found the incremental build time increase 25%~35%, which is not good.<o:p></o:p> <o:p> </o:p> We’re building server platform. And we use --hash to speed up incremental build as described in <a href="https://github.com/BobCF/edk2/wiki/Incremental-Build">https://github.com/BobCF/edk2/wiki/Incremental-Build</a><o:p></o:p> After upgrading to edk2-stable201908, none of AutoGen is skipped when I did an incremental build without any code change.<o:p></o:p> <o:p> </o:p> Dig into the issue, it is caused by commit <a href="https://github.com/tianocore/edk2/commit/0e7e7a264cd80ab71ea0f9e9da2d0617d4b539c4"> https://github.com/tianocore/edk2/commit/0e7e7a264cd80ab71ea0f9e9da2d0617d4b539c4</a><o:p></o:p> From the code change logic, it seems like it require both --hash and --binary-source to perform cache based incremental build. However, when we only have --hash in build flag, it is not functional.<o:p></o:p> <o:p> </o:p> <o:p> </o:p> Here’s a build time log retrieved from -y report.log.<o:p></o:p> <o:p> </o:p> 201905 incremental | 201908 incremental | 201905 clean | 201908 clean <o:p></o:p> Build Duration: 00:03:44 00:04:40 00:07:12 00:06:19<o:p></o:p> AutoGen Duration: 00:02:40 00:03:15 00:04:28 00:03:09<o:p></o:p> Make Duration: 00:00:36 00:00:39 00:01:21 00:01:34<o:p></o:p> GenFds Duration: 00:00:27 00:00:28 00:01:22 00:01:18 <o:p></o:p> <o:p> </o:p> We could see the AutoGen Duration has almost no change between clean and incremental build in 201908.<o:p></o:p> <o:p> </o:p> Could we fix this? <o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Derek<o:p></o:p> <o:p> </o:p> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/47809">View/Reply Online (#47809)</a> | | <a target="_blank" href="https://groups.io/mt/34227864/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>