<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body dir="auto">
Jason, Agreed - though that image you sent was challenging for these old eyes. Black on dark grey? Ack!<br>
<br>
<div dir="ltr" id="AppleMailSignature">
<div><span style="background-color: rgba(255, 255, 255, 0);">Thanks,</span></div>
<div class=""><span style="background-color: rgba(255, 255, 255, 0);">Michael A. Rothman</span></div>
<div class=""><span style="background-color: rgba(255, 255, 255, 0);">---------------------------------------------------------------</span></div>
<div><span style="background-color: rgba(255, 255, 255, 0);">Let no excuse be a barrier to your success.</span></div>
</div>
<div dir="ltr"><br>
On Sep 30, 2019, at 1:48 PM, "<a href="mailto:jason.spottswood@hpe.com">jason.spottswood@hpe.com</a>" <<a href="mailto:jason.spottswood@hpe.com">jason.spottswood@hpe.com</a>> wrote:<br>
<br>
</div>
<blockquote type="cite">
<div dir="ltr">In EsrtFmp.c, function CreateEsrtEntry, line 196, the code asserts if the FMP image hardware instance matches that of an existing instance. This is fine if the hardware instance is supported. The field is optional though. In the UEFI spec,
"a zero hardware instance means the FMP provider is not able to determine a unique hardware instance number or a hardware instance number is not needed." The code below needs to also check if the hardware instance is supported (by comparing it to zero) before
checking it against existing entries.<br>
<br>
<div style="font-family: Consolas; font-size: 14pt; color: #e0e2e4; background-color: #293134;">
<pre><span style="color: #000000;"> //
// Check to see of FmpImageInfoBuf GUID/HardwareInstance is unique
//
for (Index = 0; Index < *NumberOfDescriptors; Index++) {
if (<span style="font-weight: bolder;">CompareGuid</span> (&HardwareInstances[Index].ImageTypeGuid, &FmpImageInfoBuf->ImageTypeId)) {
if (HardwareInstances[Index].HardwareInstance == FmpHardwareInstance) {
<span style="font-weight: bolder;">DEBUG</span> ((DEBUG_ERROR, "EsrtFmpDxe: Duplicate firmware image descriptor with GUID %g HardwareInstance:0x%x\n", &FmpImageInfoBuf->ImageTypeId, FmpHardwareInstance));
<span style="font-weight: bolder;">ASSERT</span> (
!<span style="font-weight: bolder;">CompareGuid</span> (&HardwareInstances[Index].ImageTypeGuid, &FmpImageInfoBuf->ImageTypeId) ||
HardwareInstances[Index].HardwareInstance != FmpHardwareInstance
);
return EFI_UNSUPPORTED;
}
}
}
</span></pre>
</div>
</div>
</blockquote>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/48313">View/Reply Online (#48313)</a> |
|
<a target="_blank" href="https://groups.io/mt/34350126/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>