<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72"> <div class="WordSection1"> I attached a patch witch change that is needed in EDK2 code as it is described.<o:p></o:p> <o:p> </o:p> PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !!<o:p></o:p> <o:p> </o:p> Issue is UINT16 LtrMechanism<o:p></o:p> There is 2 instead of 1.<o:p></o:p> - UINT16 LtrMechanism : 2;<o:p></o:p> + UINT16 LtrMechanism : 1;<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <o:p> </o:p> <div> Daniel Banaszek<o:p></o:p> BIOS Engineer – IGK1-245<o:p></o:p> Intel Server UEFI Firmware Development Team<o:p></o:p> ______________________________________________________________________________<o:p></o:p> </div> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <a name="_____replyseparator"></a>From: Ni, Ray <ray.ni@intel.com> Sent: Monday, 2 December, 2019 15:45 To: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com> Cc: Gao, Liming <liming.gao@intel.com> Subject: RE: ASAP Issue in PciExpress21.h<o:p></o:p> </div> </div> <o:p> </o:p> Daniel,<o:p></o:p> thank you for finding such a critical issue.<o:p></o:p> Can you please submit an open source patch for this?<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Ray<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Banaszek, Daniel Pawel <<a href="mailto:daniel.pawel.banaszek@intel.com">daniel.pawel.banaszek@intel.com</a>> Sent: Monday, December 2, 2019 6:54 PM To: Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>> Subject: ASAP Issue in PciExpress21.h<o:p></o:p> </div> </div> <o:p> </o:p> Hi<o:p></o:p> There I an issue in <o:p></o:p> MdePkg/Include/IndustryStandard/PciExpress21.h<o:p></o:p> <o:p> </o:p> PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !!<o:p></o:p> <o:p> </o:p> Issue is UINT16 LtrMechanism<o:p></o:p> There is 2 instead of 1.<o:p></o:p> - UINT16 LtrMechanism : 2;<o:p></o:p> + UINT16 LtrMechanism : 1;<o:p></o:p> <o:p> </o:p> Who can commit the change?<o:p></o:p> <o:p> </o:p> Thanks<o:p></o:p> Daniel Banaszek<o:p></o:p> BIOS Engineer – IGK1-245<o:p></o:p> Intel Server UEFI Firmware Development Team<o:p></o:p> Intel Technology Poland Sp. z o.o.<o:p></o:p> <o:p> </o:p> </div> </div> </div> --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. S&#322owackiego 173 | 80-298 Gda&#324sk | S&#261d Rejonowy Gda&#324sk P&#243&#322noc | VII Wydzia&#322 Gospodarczy Krajowego Rejestru S&#261dowego - KRS 101882 | NIP 957-07-52-316 | Kapita&#322 zak&#322adowy 200.000 PLN. <span style="font-size:8.0pt;font-family:"Arial Narrow","sans-serif"; mso-fareast-font-family:"Times New Roman";mso-bidi-font-family:Arial; color:#595959;mso-ansi-language:EN-US;mso-fareast-language:EN-US;mso-bidi-language: AR-SA">Ta wiadomo&#347&#263 wraz z za&#322&#261cznikami jest przeznaczona dla okre&#347lonego adresata i mo&#380e zawiera&#263 informacje poufne. W razie przypadkowego otrzymania tej wiadomo&#347ci, prosimy o powiadomienie nadawcy oraz trwa&#322e jej usuni&#281cie; jakiekolwiek przegl&#261danie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.<o:p></o:p> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/52360">View/Reply Online (#52360)</a> | | <a target="_blank" href="https://groups.io/mt/68796847/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>