<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal">Vitaly:<o:p></o:p></p> <p class="MsoNormal"> With this change, X64 GCC and CLANG tool chain will use below VA_START definition. <o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">#define VA_START(Marker, Parameter) __builtin_ms_va_start (Marker, Parameter)<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Thanks<o:p></o:p></p> <p class="MsoNormal">Liming<o:p></o:p></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> devel@edk2.groups.io <devel@edk2.groups.io> <b> On Behalf Of </b>Vitaly Cheptsov via Groups.Io<br> <b>Sent:</b> Wednesday, February 12, 2020 4:08 PM<br> <b>To:</b> Liu, Zhiguang <zhiguang.liu@intel.com><br> <b>Cc:</b> devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Shi, Steven <steven.shi@intel.com><br> <b>Subject:</b> Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Liu,<o:p></o:p></p> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">Thanks for explanation, it does make sense now. As for no need to -DNO_MSABI_VA_FUNCS I agree, but it will not make much difference, because from what I understand the VA_ARG implementation is chosen based on EFIAPI presence when generic __builtin’s are used.<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">Best,<o:p></o:p></p> </div> <div> <p class="MsoNormal">Vitaly<o:p></o:p></p> <div> <p class="MsoNormal"><br> <br> <o:p></o:p></p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <p class="MsoNormal">12 февр. 2020 г., в 04:38, Liu, Zhiguang <<a href="mailto:zhiguang.liu@intel.com">zhiguang.liu@intel.com</a>> написал(а):<o:p></o:p></p> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">Hi Vitaly,<o:p></o:p></p> </div> <div> <p class="MsoNormal">After your patch to Switch to GNU mode for CLANGPDB, the build option -DNO_MSABI_VA_FUNCS is not required. I will send another patch to remove it.<o:p></o:p></p> </div> <div> <p class="MsoNormal">And for you question, this is a patch set that resolves BZ 2415, and the second patch<span class="apple-converted-space"> </span><span style="font-size:9.0pt;font-family:Consolas;color:#444D56;background:white">21821933aea284cd3dfea6994bd4b83bd9739fc9<span class="apple-converted-space"> </span></span>has direct influence to CLANG38.<o:p></o:p></p> </div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> <div> <p class="MsoNormal">Thanks<o:p></o:p></p> </div> <div> <p class="MsoNormal">Zhiguang<o:p></o:p></p> </div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <div> <p class="MsoNormal"><b>From:</b><span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><span class="apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a>><span class="apple-converted-space"> </span><b>On Behalf Of<span class="apple-converted-space"> </span></b>Vitaly Cheptsov via Groups.Io<br> <b>Sent:</b><span class="apple-converted-space"> </span>Tuesday, February 11, 2020 3:09 PM<br> <b>To:</b><span class="apple-converted-space"> </span>Gao, Liming <<a href="mailto:liming.gao@intel.com"><span style="color:purple">liming.gao@intel.com</span></a>>; Liu, Zhiguang <<a href="mailto:zhiguang.liu@intel.com"><span style="color:purple">zhiguang.liu@intel.com</span></a>>; Shi, Steven <<a href="mailto:steven.shi@intel.com"><span style="color:purple">steven.shi@intel.com</span></a>><br> <b>Cc:</b><span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><br> <b>Subject:</b><span class="apple-converted-space"> </span>Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB<o:p></o:p></p> </div> </div> </div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> <div> <p class="MsoNormal">Liming,<o:p></o:p></p> </div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">Done. As a side note, I am not positive how can 7990438f1437f47990a8890dee51978cb8dbc25c[1] resolve BZ 2415[2]. The bug was about CLANG38, and the toolchain updated was CLANGPDB. While it makes sense to update CLANGPDB with this flag to stay clean (it will not make a difference for clang in GNU mode), CLANGPDB has nothing to do to CLANG38.<o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">Best wishes,<o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">Vitaly<o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">[1] <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=2415"><span style="color:purple">https://bugzilla.tianocore.org/show_bug.cgi?id=2415</span></a><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">[2]<span class="apple-converted-space"> </span><a href="https://github.com/tianocore/edk2/commit/7990438f1437f47990a8890dee51978cb8dbc25c"><span style="color:purple">https://github.com/tianocore/edk2/commit/7990438f1437f47990a8890dee51978cb8dbc25c</span></a><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <div> <p class="MsoNormal"><br> <br> <br> <o:p></o:p></p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal">11 февр. 2020 г., в 09:02, Gao, Liming <<a href="mailto:liming.gao@intel.com"><span style="color:purple">liming.gao@intel.com</span></a>> написал(а):<o:p></o:p></p> </div> </div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> <div> <div> <div> <p class="MsoNormal">Vitaly:<o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"> Can you update this patch based on the latest edk2 trunk? I will catch it for edk2 Q1 stable tag.<o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">Thanks<o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">Liming<o:p></o:p></p> </div> </div> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <div> <div> <p class="MsoNormal"><b>From:</b><span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><span class="apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a>><span class="apple-converted-space"> </span><b>On Behalf Of<span class="apple-converted-space"> </span></b>Liming Gao<br> <b>Sent:</b><span class="apple-converted-space"> </span>Tuesday, February 11, 2020 1:34 PM<br> <b>To:</b><span class="apple-converted-space"> </span>vit9696 <<a href="mailto:vit9696@protonmail.com"><span style="color:purple">vit9696@protonmail.com</span></a>>;<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><br> <b>Subject:</b><span class="apple-converted-space"> </span>Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB<o:p></o:p></p> </div> </div> </div> </div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">Reviewed-by: Liming Gao <<a href="mailto:liming.gao@intel.com"><span style="color:purple">liming.gao@intel.com</span></a>><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <div> <div> <p class="MsoNormal"><b>From:</b><span class="apple-converted-space"> </span>vit9696 <<a href="mailto:vit9696@protonmail.com"><span style="color:purple">vit9696@protonmail.com</span></a>><span class="apple-converted-space"> </span><br> <b>Sent:</b><span class="apple-converted-space"> </span>Tuesday, February 11, 2020 3:23 AM<br> <b>To:</b><span class="apple-converted-space"> </span>Gao, Liming <<a href="mailto:liming.gao@intel.com"><span style="color:purple">liming.gao@intel.com</span></a>>;<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><br> <b>Subject:</b><span class="apple-converted-space"> </span>RE: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB<o:p></o:p></p> </div> </div> </div> </div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <div> <div> <p class="MsoNormal">Liming,<o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal">We did run several of our projects based on EDK II in X64 mode, DEBUG, RELEASE, NOOPT. Noticed no change from XCODE5.<o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal">We also tried building several EDK builtin packages like CryptoPkg, MdePkg, MdeModulePkg.<o:p></o:p></p> </div> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> </div> <div> <div> <p class="MsoNormal">Best wishes,<o:p></o:p></p> </div> </div> <div> <div> <div> <p class="MsoNormal">Vitaly<o:p></o:p></p> </div> </div> <div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> </div> <div> <div> <p class="MsoNormal">В пн, февр. 10, 2020 в 16:47, Gao, Liming <<a href="mailto:liming.gao@intel.com"><span style="color:purple">liming.gao@intel.com</span></a>> пишет:<o:p></o:p></p> </div> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <p class="MsoNormal" style="margin-bottom:12.0pt">Vitaly:<br> This change is good. Can you your test for it? I verify this patch for Ovmf platform on Windows. It can make ovmf pass build with CLANGPDB.<br> <br> Thanks<br> Liming<br> > -----Original Message-----<br> > From:<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><span class="apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a>> On Behalf Of Vitaly Cheptsov via Groups.Io<br> > Sent: Monday, February 10, 2020 6:59 PM<br> > To:<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><br> > Subject: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB<br> ><br> > REF:<span class="apple-converted-space"> </span><a href="https://bugzilla.tianocore.org/show_bug.cgi?id=2397"><span style="color:purple">https://bugzilla.tianocore.org/show_bug.cgi?id=2397</span></a><br> ><br> > Signed-off-by: Vitaly Cheptsov <<a href="mailto:vit9696@protonmail.com"><span style="color:purple">vit9696@protonmail.com</span></a>><br> > ---<br> > BaseTools/Conf/tools_def.template | 6 +++---<br> > 1 file changed, 3 insertions(+), 3 deletions(-)<br> ><br> > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template<br> > index feee2bbf16..6bf6c5768e 100755<br> > --- a/BaseTools/Conf/tools_def.template<br> > +++ b/BaseTools/Conf/tools_def.template<br> > @@ -2755,11 +2755,11 @@ RELEASE_CLANG38_AARCH64_DLINK_FLAGS = DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl<br> > DEFINE CLANGPDB_IA32_PREFIX = ENV(CLANG_BIN)<br> > DEFINE CLANGPDB_X64_PREFIX = ENV(CLANG_BIN)<br> ><br> > -DEFINE CLANGPDB_IA32_TARGET = -target i686-unknown-windows<br> > -DEFINE CLANGPDB_X64_TARGET = -target x86_64-unknown-windows<br> > +DEFINE CLANGPDB_IA32_TARGET = -target i686-unknown-windows-gnu<br> > +DEFINE CLANGPDB_X64_TARGET = -target x86_64-unknown-windows-gnu<br> ><br> > DEFINE CLANGPDB_WARNING_OVERRIDES = -Wno-parentheses-equality -Wno-tautological-compare -Wno-tautological-constant-out-<br> > of-range-compare -Wno-empty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option -Wno-microsoft-enum-<br> > forward-reference<br> > -DEFINE CLANGPDB_ALL_CC_FLAGS = DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB_WARNING_OVERRIDES) -fno-stack-protector -<br> > mms-bitfields -Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas -Wno-incompatible-library-redeclaration -fno-<br> > asynchronous-unwind-tables -mno-implicit-float -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -<br> > funsigned-char -fno-ms-extensions -Wno-null-dereference -fms-compatibility -mno-stack-arg-probe<br> > +DEFINE CLANGPDB_ALL_CC_FLAGS = DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB_WARNING_OVERRIDES) -fno-stack-protector -<br> > fno-asynchronous-unwind-tables -funsigned-char -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -Wno-<br> > address -Wno-shift-negative-value -Wno-unknown-pragmas -Wno-incompatible-library-redeclaration -Wno-null-dereference -mno-<br> > implicit-float -mms-bitfields -mno-stack-arg-probe -nostdlib -nostdlibinc<br> ><br> > ###########################<br> > # CLANGPDB IA32 definitions<br> > --<br> > 2.21.1 (Apple Git-122.3)<br> ><br> ><br> > -=-=-=-=-=-=<br> ><span class="apple-converted-space"> </span><a href="http://groups.io/"><span style="color:purple">Groups.io</span></a><span class="apple-converted-space"> </span>Links: You receive all messages sent to this group.<br> ><br> > View/Reply Online (#54130):<span class="apple-converted-space"> </span><a href="https://edk2.groups.io/g/devel/message/54130"><span style="color:purple">https://edk2.groups.io/g/devel/message/54130</span></a><br> > Mute This Topic:<span class="apple-converted-space"> </span><a href="https://groups.io/mt/71134286/1759384"><span style="color:purple">https://groups.io/mt/71134286/1759384</span></a><br> > Group Owner:<span class="apple-converted-space"> </span><a href="mailto:devel+owner@edk2.groups.io"><span style="color:purple">devel+owner@edk2.groups.io</span></a><br> > Unsubscribe:<span class="apple-converted-space"> </span><a href="https://edk2.groups.io/g/devel/unsub"><span style="color:purple">https://edk2.groups.io/g/devel/unsub</span></a><span class="apple-converted-space"> </span>[<a href="mailto:liming.gao@intel.com"><span style="color:purple">liming.gao@intel.com</span></a>]<br> > -=-=-=-=-=-=<o:p></o:p></p> </blockquote> <div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> </div> </div> </div> </div> </blockquote> </div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> </div> </blockquote> </div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal"></o:p></span></p> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/54296">View/Reply Online (#54296)</a> | | <a target="_blank" href="https://groups.io/mt/71134286/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>