<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">- Bret<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Michael D Kinney <michael.d.kinney@intel.com><br>
<b>Sent:</b> Monday, February 10, 2020 10:43:32 AM<br>
<b>To:</b> devel@edk2.groups.io <devel@edk2.groups.io><br>
<b>Cc:</b> Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com><br>
<b>Subject:</b> [EXTERNAL] [Patch] UnitTestFrameworkPkg/UnitTestLib: Fix XCODE parenthesis issues</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText"><a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2512&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C27b6bd3a84b64d456eec08d7ae5922fa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637169570173423344&sdata=%2BfnZ0QzM%2Fu1zVdS69ZUyxIkngUjdvpZo8I93SKLqeh8%3D&reserved=0">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2512&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C27b6bd3a84b64d456eec08d7ae5922fa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637169570173423344&sdata=%2BfnZ0QzM%2Fu1zVdS69ZUyxIkngUjdvpZo8I93SKLqeh8%3D&reserved=0</a><br>
<br>
Remove extra sets of parenthesis that generate warnings on XCODE5<br>
builds.<br>
<br>
Cc: Sean Brogan <sean.brogan@microsoft.com><br>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com><br>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com><br>
---<br>
UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c | 6 +++---<br>
UnitTestFrameworkPkg/Library/UnitTestLib/Log.c | 2 +-<br>
2 files changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c<br>
index dd85b84b08..c327ba88f1 100644<br>
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c<br>
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c<br>
@@ -247,7 +247,7 @@ UnitTestAssertEqual (<br>
IN CONST CHAR8 *DescriptionB<br>
)<br>
{<br>
- if ((ValueA != ValueB)) {<br>
+ if (ValueA != ValueB) {<br>
UnitTestLogFailure (<br>
FAILURETYPE_ASSERTEQUAL,<br>
"%a::%d Value %a != %a (%d != %d)!\n",<br>
@@ -365,7 +365,7 @@ UnitTestAssertNotEqual (<br>
IN CONST CHAR8 *DescriptionB<br>
)<br>
{<br>
- if ((ValueA == ValueB)) {<br>
+ if (ValueA == ValueB) {<br>
UnitTestLogFailure (<br>
FAILURETYPE_ASSERTNOTEQUAL,<br>
"%a::%d Value %a == %a (%d == %d)!\n",<br>
@@ -420,7 +420,7 @@ UnitTestAssertStatusEqual (<br>
IN CONST CHAR8 *Description<br>
)<br>
{<br>
- if ((Status != Expected)) {<br>
+ if (Status != Expected) {<br>
UnitTestLogFailure (<br>
FAILURETYPE_ASSERTSTATUSEQUAL,<br>
"%a::%d Status '%a' is %r, should be %r!\n",<br>
diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c b/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c<br>
index 78df086a28..ac4e229b40 100644<br>
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c<br>
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c<br>
@@ -136,7 +136,7 @@ UnitTestLogInit (<br>
return;<br>
}<br>
<br>
- if((Buffer != NULL) && (BufferSize > 0) && ((BufferSize <= UNIT_TEST_MAX_LOG_BUFFER))) {<br>
+ if((Buffer != NULL) && (BufferSize > 0) && (BufferSize <= UNIT_TEST_MAX_LOG_BUFFER)) {<br>
CopyMem (Test->Log, Buffer, BufferSize);<br>
}<br>
}<br>
-- <br>
2.21.0.windows.1<br>
<br>
</div>
</span></font></div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/54660">View/Reply Online (#54660)</a> |
|
<a target="_blank" href="https://groups.io/mt/71412829/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>