<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72"> <div class="WordSection1"> Liming,<o:p></o:p> <o:p> </o:p> Please help to provide comments for this mail. It break the open board now<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Eric<o:p></o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Luo, Heng Sent: Tuesday, March 31, 2020 9:25 AM To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com> Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path<o:p></o:p> </div> </div> <o:p> </o:p> Hi Liming, I will apply the change below if you agree to we treat a folder that contains ".dec" and "dsc" files as a package directory: diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index b9ad980510..bb25699ed8 100644 --- a/Platform/Intel/build_bios.py +++ b/Platform/Intel/build_bios.py @@ -16,6 +16,7 @@ imported functions from board directory import os import re import sys +import glob import signal import shutil import argparse @@ -123,7 +124,10 @@ def pre_build(build_config, build_type="DEBUG", silent=False, toolchain=None): # add all feature domains in WORKSPACE_FEATURES to package path for filename in os.listdir(config["WORKSPACE_FEATURES"]): filepath = os.path.join(config["WORKSPACE_FEATURES"], filename) - if os.path.isdir(filepath): + # feature domains folder does not contain dec or dsc file + if os.path.isdir(filepath) and \ + not glob.glob(os.path.join(filepath, "*.dec")) and \ + not glob.glob(os.path.join(filepath, "*.dsc")): config["PACKAGES_PATH"] += os.pathsep + filepath config["PACKAGES_PATH"] += os.pathsep + config["WORKSPACE_DRIVERS"] config["PACKAGES_PATH"] += os.pathsep + \ Best Regards Heng > -----Original Message----- > From: Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>> > Sent: Monday, March 30, 2020 5:01 PM > To: Luo, Heng <<a href="mailto:heng.luo@intel.com">heng.luo@intel.com</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> > Cc: Bi, Dandan <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>>; Gao, Liming <<a href="mailto:liming.gao@intel.com">liming.gao@intel.com</a>>; > Dong, Eric <<a href="mailto:eric.dong@intel.com">eric.dong@intel.com</a>> > Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to > package path > > > + # add all feature domains in WORKSPACE_FEATURES to package path > > + for filename in os.listdir(config["WORKSPACE_FEATURES"]): > > + filepath = os.path.join(config["WORKSPACE_FEATURES"], filename) > > + if os.path.isdir(filepath): > > + config["PACKAGES_PATH"] += os.pathsep + filepath > > Will this change include "AdvancedFeaturePkg" and "TemplateFeaturePkg" > folder as well? > > Can you please revise the patch to skip adding folders that contains package > contents to the PACKAGES_PATH? > > Liming, > What's the criteria of a package? Can we treat a folder that contains ".dec" > and "dsc" files as a package directory? > > Thanks, > Ray<o:p></o:p> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/56711">View/Reply Online (#56711)</a> | | <a target="_blank" href="https://groups.io/mt/72646657/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>