<div dir="ltr">Btw, the Raspberry Pi support has its own variant of MmcDxe and SD host drivers... the history behind that is that's the way it was in the original MSFT port circa 2016. When I had rebased that code to 2018 edk2 (still before Pete's work to upstream it here), the edk2 variant had significantly diverged from the MSFT changes, so the MSFT one was taken as is (and further evolved to fix issues around high-speed support).<div><br></div><div>It's still a goal to move away from all of that towards something generic. The Pi has two (sometimes 3) controllers - some are kinda-SDHCI (maybe possible with the Mde stack, if quirked via _SD_MMC_OVERRIDE_PROTOCOL), while the other is completely non-standard.</div><div><br></div><div>Mde doesn't have a non-SDHCI stack. That remains a gap...</div><div><br></div><div>A</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 29, 2020 at 11:36 AM Leif Lindholm <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">We keep seeing new users (and copies) of EmbeddedPkg:s MmcDxe, which<br>
while it predates the MdeModulePkg SD/(E)MMCsupport is in effect<br>
unmaintained and also duplicates core industry standard definitions.<br>
<br>
Since we now have GetMaintainers.py to parse Maintainers.txt for us,<br>
extend its functionality to warn about less supported code.<br>
<br>
Then as an indication of its unsuitability for reference (or use), set<br>
its Status flag in Maintainers.txt to Obsolete.<br>
<br>
Once this is done, follow up and do the same with the hardware drivers<br>
(not the software ones) still left in EmbeddedPkg/Drivers. They were<br>
added back when not using the UEFI driver model was still cool, or<br>
simply before edk2-platforms existed.<br>
They should move to edk2-platforms, but most of them require some<br>
level of rewriting before that.<br>
<br>
1/3 adds a warning printout to GetMaintainer.py<br>
<br>
2/3 obsoletes EmbeddedPkg/Universal/MmcDxe/<br>
<br>
3/3 obsoletes remaining hw drivers in EmbeddedPkg/Drivers<br>
Cc: Andrew Fish <<a href="mailto:afish@apple.com" target="_blank">afish@apple.com</a>><br>
<br>
Cc: Ard Biesheuvel <<a href="mailto:ard.biesheuvel@arm.com" target="_blank">ard.biesheuvel@arm.com</a>><br>
Cc: Bob Feng <<a href="mailto:bob.c.feng@intel.com" target="_blank">bob.c.feng@intel.com</a>><br>
Cc: Laszlo Ersek <<a href="mailto:lersek@redhat.com" target="_blank">lersek@redhat.com</a>><br>
Cc: Liming Gao <<a href="mailto:liming.gao@intel.com" target="_blank">liming.gao@intel.com</a>><br>
Cc: Michael D Kinney <<a href="mailto:michael.d.kinney@intel.com" target="_blank">michael.d.kinney@intel.com</a>><br>
<br>
Leif Lindholm (3):<br>
BaseTools: add handling for 'S:' flag to GetMaintainer.py<br>
Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete<br>
Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete<br>
<br>
BaseTools/Scripts/GetMaintainer.py | 4 ++++<br>
Maintainers.txt | 17 +++++++++++++++++<br>
2 files changed, 21 insertions(+)<br>
<br>
-- <br>
2.20.1<br>
<br>
<br>
<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature">A</div>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/58335">View/Reply Online (#58335)</a> |
|
<a target="_blank" href="https://groups.io/mt/73356717/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>