<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> I just looked into it, and I think that <span style="color: rgb(50, 49, 48); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important">AsciiStrCpyS() was the wrong function to call in this loop anyway. <span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; background-color: rgb(255, 255, 255); display: inline !important">AsciiStrCpyS() will fail without copying any characters.</span></span></div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <span style="color: rgb(50, 49, 48); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important"><span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; background-color: rgb(255, 255, 255); display: inline !important"><span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; background-color: rgb(255, 255, 255); display: inline !important">AsciiStrnCpyS() will perform the string "slicing"/"chunking" that the loop seems to expect.</span><br> </span></span></div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <span style="color: rgb(50, 49, 48); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important"><span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; background-color: rgb(255, 255, 255); display: inline !important"><span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; background-color: rgb(255, 255, 255); display: inline !important"><br> </span></span></span></div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <span style="color: rgb(50, 49, 48); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important"><span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; background-color: rgb(255, 255, 255); display: inline !important"><span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; background-color: rgb(255, 255, 255); display: inline !important">The bug stands and we should try to get that bug fix into the stable tag. Thanks!</span></span></span></div> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div id="Signature"> <div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif"> <p style="margin-top: 0px; margin-bottom: 0px;">- Bret </p> </div> </div> </div> <div> <div id="appendonsend"></div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> <br> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Laszlo Ersek <lersek@redhat.com><br> <b>Sent:</b> Monday, May 25, 2020 10:46 AM<br> <b>To:</b> Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.groups.io <devel@edk2.groups.io>; liming.gao <liming.gao@intel.com>; announce@edk2.groups.io <announce@edk2.groups.io><br> <b>Cc:</b> Leif Lindholm <leif@nuviainc.com>; afish@apple.com <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com><br> <b>Subject:</b> [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="PlainText">Hi Bret,<br> <br> On 05/22/20 17:11, Bret Barkelew wrote:<br> > We’d like to ask that this patch be considered for the stable tag:<br> > [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use AsciiStrnCpyS()<br> > <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2721&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C2698d0e553c04b47194c08d800d398b8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637260256091133309&sdata=MDKQ1CKq9%2B9AfPML0JxcND47UIcQUAibUSAVlfW5iZc%3D&reserved=0"> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2721&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C2698d0e553c04b47194c08d800d398b8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637260256091133309&sdata=MDKQ1CKq9%2B9AfPML0JxcND47UIcQUAibUSAVlfW5iZc%3D&reserved=0</a><br> > <br> > The patch was reviewed prior to the hard freeze date, and is a small change that affects new(ish) code that is not heavily utilized yet.<br> <br> does the original issue (reported in TianoCore#2721) persist with<br> TianoCore#2054 fixed?<br> <br> My understanding (from TianoCore#2721) is that the original<br> AsciiStrCpyS() call is not buggy, it just triggers a (per spec) error<br> condition in AsciiStrCpyS(). Previously, that would indeed trip an<br> ASSERT(), but AIUI that issue has been resolved generally with<br> TianoCore#2054.<br> <br> If the AsciiStrCpyS() call remains an issue with the ASSERT() removed,<br> then replacing the call with AsciiStrnCpyS() still seems like a bugfix<br> to me, not a "feature", so I think the patch is eligible for merging<br> during the HFF.<br> <br> Mike, can you please merge the patch (if it's still needed)?<br> <br> Thanks<br> Laszlo<br> <br> <br> > <br> > - Bret<br> > <br> > From: Liming Gao via groups.io<<a href="mailto:liming.gao=intel.com@groups.io">mailto:liming.gao=intel.com@groups.io</a>><br> > Sent: Friday, May 22, 2020 1:01 AM<br> > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; announce@edk2.groups.io<mailto:announce@edk2.groups.io><br> > Cc: Laszlo Ersek<<a href="mailto:lersek@redhat.com">mailto:lersek@redhat.com</a>>; Leif Lindholm<<a href="mailto:leif@nuviainc.com">mailto:leif@nuviainc.com</a>>; afish@apple.com<<a href="mailto:afish@apple.com">mailto:afish@apple.com</a>>; Kinney, Michael D<<a href="mailto:michael.d.kinney@intel.com">mailto:michael.d.kinney@intel.com</a>><br> > Subject: [EXTERNAL] [edk2-devel] Hard Feature Freeze starts now for edk2-stable202005<br> > <br> > Hi, all<br> > Today, we enter into Hard Feature Freeze phase until edk2-stable202005 tag is created at 2020-05-29. In this phase, there is no feature to be pushed. The critical bug fix is still allowed.<br> > <br> > If the patch is sent after Hard Feature Freeze, and plans to catch this stable tag, please add edk2-stable202005 key words in the patch title and BZ, and also cc to Tianocore Stewards, then Stewards can give the comments.<br> > <br> > Below is edk2-stable202005 tag planning.<br> > Date (00:00:00 UTC-8) Description<br> > 2020-03-04 Beginning of development<br> > 2020-05-08 Feature Planning Freeze<br> > 2020-05-15 Soft Feature Freeze<br> > 2020-05-22 Hard Feature Freeze<br> > 2020-05-29 Release<br> > <br> > Thanks<br> > Liming<br> > > <br> > <br> <br> </div> </span></font></div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/60302">View/Reply Online (#60302)</a> | | <a target="_blank" href="https://groups.io/mt/74488317/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>