<div dir="ltr"><div dir="ltr"><div dir="ltr">Hey Mike,</div><div dir="ltr"><br></div><div>1. I'll move it for v4. </div><div>2. I'll remove that, thanks!</div><div>3. I'll fix that as well, good spot. </div><div>4. It's mostly the same except for the different CrtWrappers</div><div>5. We need a host-specific CrtWrapper since the regular one has a bunch of conflicts with regular C98, but there are a few functions that since we're building no std mode of OpenSSL we still need to provide.</div><div>6. That would be my guess- this is largely based on the edk2-staging HBFA branch and I've had to reverse engineer some of the steps for generating the test data. I fixed the instructions.</div><div dir="ltr"><br clear="all"><div><div dir="ltr"><div dir="ltr">-Matthew Carlson</div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 14, 2020 at 7:53 PM Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" target="_blank">michael.d.kinney@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Matt,<br>
<br>
I think the BaseCryptLib unit tests may need some more work.<br>
<br>
1) The DSC file for host based tests is in the wrong directory.<br>
It should be in CryptoPkg/Test to match the MdePkg, MdeModulePkg<br>
and UnitTestFrameworkPkg location.<br>
<br>
2) CryptoPkg/CryptoPkg.dsc includes a reference to the host based<br>
library UnitTestHostBaseCryptLib.inf. This should only be <br>
listed in the host based DSC file.<br>
<br>
3) CryptoPkg\Library\BaseCryptLib\UnitTestHostBaseCryptLib.inf<br>
This file appears to only be for host based tests, but it <br>
lists compatibility with DXE_DRIVER DXE_CORE UEFI_APPLICATION UEFI_DRIVER<br>
and does not list HOST_APPLICATION as expected.<br>
<br>
4) Why do we need a new lib instance of the BaseCryptLib for<br>
host based unit testing. I would think we would want to perform<br>
unit tests on the BaseCryptLib instances that would actually be <br>
used in FW components. Can we update the unit tests to test<br>
the services provided in the Base, Pei, Runtime, and Smm <br>
instances of the BaseCryptLib?<br>
<br>
5) Why do we need a host based specific version of the CrtWrapper, <br>
UnitTestHostCrtWrapper.c? <br>
<br>
6) The file CryptoPkg/Test/UnitTest/Librray/BaseCryptLib/TestEKUCerts/<br>
ChainCreationInstructions.txt makes reference to a bintohex tool<br>
and putting the results in a file called AllTestSignatures.h.<br>
But I do not see this file in the patch. Are these instructions<br>
out of date?<br>
<br>
Thanks,<br>
<br>
Mike</blockquote></div></div></div>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/62637">View/Reply Online (#62637)</a> |
|
<a target="_blank" href="https://groups.io/mt/75505002/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>