<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 20, 2020, at 6:18 PM, Jiang, Guomin <<a href="mailto:guomin.jiang@intel.com" class="">guomin.jiang@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">I would like that add BaseTols/Scripts/ to the PATH.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Usually, I use ```set PATH=%PATH%;%WORKSPACE%\BaseTools\Scripts``` to add new directory to the environment variable.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">But I suggest that we should judge if the last character in PATH variable is ';' character and then add new directory.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Let me know what I can help you.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""></div></blockquote><div><br class=""></div><div>I’m thinking I could file a bugzilla to add BaseTools/Scripts/ to the path for edksetup.sh/edksetup.bat and then I can just contribute my Python git extension to BaseTools/Scripts</div><div><br class=""></div><div>As Laszlo pointed out there is generic value having BaseTools/Scripts/ in the path so I filed: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=2859" class="">https://bugzilla.tianocore.org/show_bug.cgi?id=2859</a></div><div><br class=""></div><div>Thanks,</div><div><br class=""></div><div>Andrew Fish</div><br class=""><blockquote type="cite" class=""><div class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-----Original Message-----<br class="">From:<span class="Apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" class="">devel@edk2.groups.io</a><span class="Apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io" class="">devel@edk2.groups.io</a>> On Behalf Of Laszlo<br class="">Ersek<br class="">Sent: Tuesday, July 21, 2020 3:55 AM<br class="">To: Andrew Fish <<a href="mailto:afish@apple.com" class="">afish@apple.com</a>>; edk2-devel-groups-io<br class=""><<a href="mailto:devel@edk2.groups.io" class="">devel@edk2.groups.io</a>><br class="">Subject: Re: [edk2-devel] File in the build question. I'm working on a smart git<br class="">grep<br class=""><br class="">On 07/18/20 22:23, Andrew Fish wrote:<br class=""><blockquote type="cite" class="">Wanted to see if people are OK with adding BaseTools/Scripts/ to the path<br class=""></blockquote>when you run `. edksetuip.sh` or edksetup.bat?<br class=""><blockquote type="cite" class=""><br class="">If we do that and I add BaseTools/Scripts/git-pgrep then it will show up as<br class=""></blockquote>an extended git command.<br class=""><blockquote type="cite" class=""><br class="">I was thinking over time we could add git-edk2* git commands to help<br class=""></blockquote>automate the process or maintainer workflow.<br class=""><blockquote type="cite" class=""><br class="">If people are OK with adding the path I can make a patch set to contribute<br class=""></blockquote>git-pgrep, but I need some help with how to add the new path to<br class="">edksetup.bat.<br class=""><br class="">To be honest, I think edksetup.sh should add BaseTools/Scripts/ to the PATH<br class="">environment variable anyway. I find it a bit awkward to run<br class=""><br class=""> python BaseTools/Scripts/GetMaintainer.py -l ...<br class=""><br class="">rather than just<br class=""><br class=""> GetMaintainer.py -l ...<br class=""><br class="">Thanks<br class="">Laszlo<br class=""><br class=""><br class=""></blockquote></div></blockquote></div><br class=""></body></html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/62935">View/Reply Online (#62935)</a> |
|
<a target="_blank" href="https://groups.io/mt/75533926/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>