<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">+Hao, Ray,<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">Hi Libo, thanks for your explanation.<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">So I think the patch is improvement for current logic.<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">Hi Hao and Ray,<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">Can you give some comments for the change.<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">Hi Jeremy,<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">It may be helpful for the ASSERT issue </span><a href="https://edk2.groups.io/g/devel/message/62651,can">https://edk2.groups.io/g/devel/message/62651,can</a> you try it?<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">Best Regards<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">Guomin<o:p></o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> devel@edk2.groups.io <devel@edk2.groups.io> <b>On Behalf Of </b>Feng Libo<br> <b>Sent:</b> Tuesday, August 11, 2020 5:50 PM<br> <b>To:</b> Jiang, Guomin <guomin.jiang@intel.com><br> <b>Cc:</b> devel@edk2.groups.io; jeremy.linton@arm.com<br> <b>Subject:</b> Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal"><span style="font-family:"Arial",sans-serif;color:black">Hello, Mr. Jiang,</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Arial",sans-serif;color:black">Thank for the review.</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Arial",sans-serif;color:black">The original enumeration steps in the function of UsbEnumerateNewDev of file UsbEnumer.c: 1 reset the port, 2 set the usb device address, 3 get the Max Packet Size, 4 get the full device descriptor. However, when plugging a USB PenDisk with </span><span style="font-family:"Helvetica",sans-serif;color:#333333">Innostor USB</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Helvetica",sans-serif;color:#333333">controller chip (VID=0x1F75, PID=0x917, USB3.1), the fourth step always fails, trace as below:</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Helvetica",sans-serif;color:#333333">========</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Helvetica",sans-serif;color:#333333">XhcCheckUrbResult: TRANSACTION_ERROR! Completecode = 4 XhcControlTransfer: error - Device Error, transfer - 40 UsbGetOneConfig: failed to get full descript Device Error UsbBuildDescTable: failed to get configure (index 0) UsbEnumerateNewDev: failed to build descriptor table - Device Error </span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Helvetica",sans-serif;color:#333333">=======</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Arial",sans-serif;color:black">The host controller need to get the full device descriptor, but this moment, the Pendisk device doesn't response any more. Then timeout. and UsbEnumerateNewDev complains : failed to build descriptor.</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Arial",sans-serif;color:black">We have three Pendisks from different manufacturers, all with </span><span style="font-family:"Helvetica",sans-serif;color:#333333">Innostor USB controller chip. they all can't be enumerated all. And we observed the problem on both Huawei KunPeng(</span><span lang="ZH-CN" style="color:#333333">华为鲲鹏）</span><span style="font-family:"Helvetica",sans-serif;color:#333333">and Loognson</span><span lang="ZH-CN" style="color:#333333">（龙芯）</span><span style="font-family:"Helvetica",sans-serif;color:#333333">platforms.</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Helvetica",sans-serif;color:#333333">The three Pendisks always fail the USB enumeration. Other USB 2.0 and USB 3.0 on hand can work well.</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Helvetica",sans-serif;color:#333333">With the patch, the three pendisks and other pendisks can all work well.</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Helvetica",sans-serif;color:#333333">THanks</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">--<o:p></o:p></span></p> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">Best Regards<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">Feng Libo<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">ZD Technology (Beijing) Co., Ltd<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"><br> </span><span lang="ZH-CN" style="font-size:10.5pt;color:black">发件人：</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">"Jiang, Guomin" <<a href="mailto:guomin.jiang@intel.com">guomin.jiang@intel.com</a>><br> </span><span lang="ZH-CN" style="font-size:10.5pt;color:black">发送日期：</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">2020-08-11 08:21:10<br> </span><span lang="ZH-CN" style="font-size:10.5pt;color:black">收件人：</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">"<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>" <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>,"Jiang, Guomin" <<a href="mailto:guomin.jiang@intel.com">guomin.jiang@intel.com</a>>,"<a href="mailto:lbfeng@zd-tech.com.cn">lbfeng@zd-tech.com.cn</a>" <<a href="mailto:lbfeng@zd-tech.com.cn">lbfeng@zd-tech.com.cn</a>><br> </span><span lang="ZH-CN" style="font-size:10.5pt;color:black">抄送人：</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">"<a href="mailto:jeremy.linton@arm.com">jeremy.linton@arm.com</a>" <<a href="mailto:jeremy.linton@arm.com">jeremy.linton@arm.com</a>><br> </span><span lang="ZH-CN" style="font-size:10.5pt;color:black">主题：</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">RE: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.<br> <br> <o:p></o:p></span></p> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">+Jeremy,<o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"> <o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">I review the patch and think it is reasonable, but I want to know some more detail information<o:p></o:p></span></p> <ol start="1" type="1"> <li class="MsoListParagraph" style="color:black;mso-list:l0 level1 lfo1"><span style="font-size:10.5pt;font-family:"Arial",sans-serif">Can you provide the detail debug log about USB?<o:p></o:p></span></li><li class="MsoListParagraph" style="color:black;mso-list:l0 level1 lfo1"><span style="font-size:10.5pt;font-family:"Arial",sans-serif">The symptom always can be seen or have fail rate?<o:p></o:p></span></li></ol> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"> <o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">Best Regards<o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">Guomin<o:p></o:p></span></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">From:</span></b><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> <b>On Behalf Of </b>Guomin Jiang<br> <b>Sent:</b> Thursday, August 6, 2020 12:29 PM<br> <b>To:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a href="mailto:lbfeng@zd-tech.com.cn"> lbfeng@zd-tech.com.cn</a><br> <b>Subject:</b> Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.<o:p></o:p></span></p> </div> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"> <o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">I will review it by next weekend(8/14).<o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"> <o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">Thanks.<o:p></o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">From:</span></b><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> <b>On Behalf Of </b>Feng Libo<br> <b>Sent:</b> Thursday, August 6, 2020 9:25 AM<br> <b>To:</b> Feng Libo <<a href="mailto:lbfeng@zd-tech.com.cn">lbfeng@zd-tech.com.cn</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><br> <b>Subject:</b> Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.<o:p></o:p></span></p> </div> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black"> <o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:black">Hello, <br> <br> could anyone review this PATCH?<br> <br> We encountered the USB enumeration problem and the patch is based on the Microsoft post as below.<br> <br> <a href="https://techcommunity.microsoft.com/t5/microsoft-usb-blog/how-does-usb-stack-enumerate-a-device/ba-p/270685#:~:text=%20How%20does%20USB%20stack%20enumerate%20a%20device%3F,a%20request%20for%20the%20USB%20Device...%20More%20">https://techcommunity.microsoft.com/t5/microsoft-usb-blog/how-does-usb-stack-enumerate-a-device/ba-p/270685#:~:text=%20How%20does%20USB%20stack%20enumerate%20a%20device%3F,a%20request%20for%20the%20USB%20Device...%20More%20</a><br> <br> Thanks<br> <br> Best Regards<br> <br> Feng Libo <o:p></o:p></span></p> </div> </div> </blockquote> </div> <div> <p class="MsoNormal"></o:p></span></p> </div> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/63982">View/Reply Online (#63982)</a> | | <a target="_blank" href="https://groups.io/mt/75608816/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>