<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Andrei Warkentin <andrey.warkentin@gmail.com></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Pete Batard <pete@akeo.ie><br>
<b>Sent:</b> Wednesday, August 26, 2020 6:23 PM<br>
<b>To:</b> Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; devel@edk2.groups.io <devel@edk2.groups.io><br>
<b>Cc:</b> Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Andrei Warkentin <awarkentin@vmware.com><br>
<b>Subject:</b> Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On 2020.08.27 00:20, Samer El-Haj-Mahmoud wrote:<br>
> Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding<br>
> extern module global, but did not remove the STATIC declaration, which<br>
> caused the build to break. Fix the build error by removing STATIC for<br>
> that module global variable.<br>
> <br>
> Cc: Leif Lindholm <leif@nuviainc.com><br>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com><br>
> Cc: Pete Batard <pete@akeo.ie><br>
> Cc: Andrei Warkentin <awarkentin@vmware.com><br>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com><br>
> ---<br>
> Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> <br>
> diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c<br>
> index ae4b2735820c..3eba98e5aa87 100644<br>
> --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c<br>
> +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c<br>
> @@ -87,7 +87,7 @@ DisplayBlt (<br>
> IN UINTN Delta OPTIONAL<br>
> );<br>
> <br>
> -STATIC EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {<br>
> +EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {<br>
> DriverSupported,<br>
> DriverStart,<br>
> DriverStop,<br>
> <br>
<br>
Reviewed-by: Pete Batard <pete@akeo.ie><br>
</div>
</span></font></div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/64672">View/Reply Online (#64672)</a> |
|
<a target="_blank" href="https://groups.io/mt/76440544/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>