<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal">Thanks Pete and Andrei. Should we count these as RB or AB for the patch?<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com><o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> devel@edk2.groups.io <devel@edk2.groups.io> <b> On Behalf Of </b>Andrei Warkentin via groups.io<br> <b>Sent:</b> Monday, September 21, 2020 4:01 PM<br> <b>To:</b> Pete Batard <pete@akeo.ie>; Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>; devel@edk2.groups.io<br> <b>Cc:</b> Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Leif Lindholm <leif@nuviainc.com><br> <b>Subject:</b> Re: [edk2-devel] [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black">Hi folks,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black">No objection at all. IIRC the original pin selection was driven by an article I read about using OpenOCD with Pi 3.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black">A<o:p></o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Pete Batard <<a href="mailto:pete@akeo.ie">pete@akeo.ie</a>><br> <b>Sent:</b> Tuesday, September 15, 2020 7:26 AM<br> <b>To:</b> Jeff Booher-Kaeding <<a href="mailto:jeff.booher-kaeding@arm.com">jeff.booher-kaeding@arm.com</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>><br> <b>Cc:</b> Ard Biesheuvel <<a href="mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com</a>>; Leif Lindholm <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>>; Andrei Warkentin <<a href="mailto:awarkentin@vmware.com">awarkentin@vmware.com</a>><br> <b>Subject:</b> Re: [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt">Copying Andrei on this, as the existing JTAG pinout is not technically <br> incorrect, since GPIO pin 4 can be used for TDI in ALT5 mode, and we are <br> using the relevant ALT mode in the existing code. See <br> <a href="https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsysprogs.com%2FVisualKernel%2Ftutorials%2Fraspberry%2Fjtagsetup%2F&data=02%7C01%7Cawarkentin%40vmware.com%7C1c1badf5e6f1433b44b508d859728a32%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637357695767996220&sdata=rGIzM4Io36gFJrAK%2F4xZs0fm0DpXVvamhOYYXfc09ek%3D&reserved=0">https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsysprogs.com%2FVisualKernel%2Ftutorials%2Fraspberry%2Fjtagsetup%2F&data=02%7C01%7Cawarkentin%40vmware.com%7C1c1badf5e6f1433b44b508d859728a32%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637357695767996220&sdata=rGIzM4Io36gFJrAK%2F4xZs0fm0DpXVvamhOYYXfc09ek%3D&reserved=0</a><br> <br> As far as I'm concerned, I think it makes sense to use the same ALT mode <br> and have all the JTAG pins grouped, but I'd like to confirm whether we <br> deliberately chose not to use GPIO 26 in order to leave it available for <br> some other purpose, before I approve this patch.<br> <br> If Andrei says he's okay with it, then I see no objection to this change.<br> <br> Regards,<br> <br> /Pete<br> <br> On 2020.09.14 22:32, Jeff Booher-Kaeding wrote:<br> > Updated the pinout to match the Pi4 datasheet, tested with the RPi4, Pi3 Datasheet has same pinout.<br> > <br> > Signed-off-by: Jeff Booher-Kaeding <<a href="mailto:Jeff.booher-kaeding@arm.com">Jeff.booher-kaeding@arm.com</a>><br> > <br> > Cc: Ard Biesheuvel <<a href="mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com</a>><br> > Cc: Leif Lindholm <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>><br> > Cc: Pete Batard <<a href="mailto:pete@akeo.ie">pete@akeo.ie</a>><br> > ---<br> > Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 6 +++---<br> > 1 file changed, 3 insertions(+), 3 deletions(-)<br> > <br> > diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c<br> > index ac1004fe1836..6e793efb8227 100644<br> > --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c<br> > +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c<br> > @@ -502,7 +502,7 @@ ApplyVariables (<br> > * 1 VREF N/A 1<br> > <br> > * 3 nTRST GPIO22 ALT4 15<br> > <br> > * 4 GND N/A 9<br> > <br> > - * 5 TDI GPIO4 ALT5 7<br> > <br> > + * 5 TDI GPIO26 ALT4 37<br> > <br> > * 7 TMS GPIO27 ALT4 13<br> > <br> > * 9 TCK GPIO25 ALT4 22<br> > <br> > * 11 RTCK GPIO23 ALT4 16<br> > <br> > @@ -510,14 +510,14 @@ ApplyVariables (<br> > */<br> > <br> > if (PcdGet32 (PcdDebugEnableJTAG)) {<br> > <br> > GpioPinFuncSet (22, GPIO_FSEL_ALT4);<br> > <br> > - GpioPinFuncSet (4, GPIO_FSEL_ALT5);<br> > <br> > + GpioPinFuncSet (26, GPIO_FSEL_ALT4);<br> > <br> > GpioPinFuncSet (27, GPIO_FSEL_ALT4);<br> > <br> > GpioPinFuncSet (25, GPIO_FSEL_ALT4);<br> > <br> > GpioPinFuncSet (23, GPIO_FSEL_ALT4);<br> > <br> > GpioPinFuncSet (24, GPIO_FSEL_ALT4);<br> > <br> > } else {<br> > <br> > GpioPinFuncSet (22, GPIO_FSEL_INPUT);<br> > <br> > - GpioPinFuncSet (4, GPIO_FSEL_INPUT);<br> > <br> > + GpioPinFuncSet (26, GPIO_FSEL_INPUT);<br> > <br> > GpioPinFuncSet (27, GPIO_FSEL_INPUT);<br> > <br> > GpioPinFuncSet (25, GPIO_FSEL_INPUT);<br> > <br> > GpioPinFuncSet (23, GPIO_FSEL_INPUT);<br> > <o:p></o:p></p> </div> </div> <div> <p class="MsoNormal"></o:p></span></p> </div> </div> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/65728">View/Reply Online (#65728)</a> | | <a target="_blank" href="https://groups.io/mt/76854132/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>