<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-GB" link="blue" vlink="#954F72"> <div class="WordSection1"> Hi Bret, <o:p></o:p> <o:p> </o:p> Please find my response inline marked [SAMI].<o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> <o:p> </o:p> Sami Mujawar<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Bret Barkelew <Bret.Barkelew@microsoft.com> Sent: 05 October 2020 09:51 PM To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com> Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; leif@nuviainc.com; lersek@redhat.com; Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com> Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section<o:p></o:p> </div> </div> <o:p> </o:p> I’m assuming this is used across multiple packages?<o:p></o:p> [SAMI] This flag is also used in CryptoPkg\Library\OpensslLib. [/SAMI]<o:p></o:p> <o:p> </o:p> If so,<o:p></o:p> <o:p> </o:p> Reviewed-by: Bret Barkelew <<a href="mailto:bret.barkelew@microsoft.com">bret.barkelew@microsoft.com</a>><o:p></o:p> <o:p> </o:p> - Bret <o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: <a href="mailto:sami.mujawar=arm.com@groups.io">Sami Mujawar via groups.io</a> Sent: Friday, October 2, 2020 2:14 PM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> Cc: <a href="mailto:sami.mujawar@arm.com">Sami Mujawar</a>; <a href="mailto:ard.biesheuvel@arm.com"> ard.biesheuvel@arm.com</a>; <a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>; <a href="mailto:lersek@redhat.com">lersek@redhat.com</a>; <a href="mailto:Matteo.Carlini@arm.com"> Matteo.Carlini@arm.com</a>; <a href="mailto:Ben.Adderson@arm.com">Ben.Adderson@arm.com</a>; <a href="mailto:nd@arm.com">nd@arm.com</a> Subject: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section<o:p></o:p> </div> <o:p> </o:p> The EDKII Core CI reports spelling error for XIPFLAGS. The XIPFLAGS are typically used to specify XIP options to the compiler. e.g. GCC:*_*_*_CC_XIPFLAGS = -fno-jump-tables Add 'XIPFLAGS' to "words" section in cspell.base.yaml file to avoid spelling check error. Signed-off-by: Sami Mujawar <<a href="mailto:sami.mujawar@arm.com">sami.mujawar@arm.com</a>> Acked-by: Ard Biesheuvel <<a href="mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com</a>> --- Notes: v5: - No code changes, resending patch with v5 series. [Sami] Ref: <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F62162&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C09b7528fca35489670af08d867182f71%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637372700863446978&sdata=VZm3wyCHnm9oV1HTuripLVGwPxvrLtmuXTDJk68ueCo%3D&reserved=0"> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F62162&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C09b7528fca35489670af08d867182f71%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637372700863446978&sdata=VZm3wyCHnm9oV1HTuripLVGwPxvrLtmuXTDJk68ueCo%3D&reserved=0</a> .pytool/Plugin/SpellCheck/cspell.base.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml index 1ce5f6991104b83e41e769299b23cb3fa74c46e9..ad6f7ac06ad18efcd4ab9c2346356dfd6885d827 100644 --- a/.pytool/Plugin/SpellCheck/cspell.base.yaml +++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml @@ -178,5 +178,6 @@ "vcruntimed", "ucrtd", "msvcrtd", + "XIPFLAGS" ] } -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' <o:p></o:p> <o:p> </o:p> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/65913">View/Reply Online (#65913)</a> | | <a target="_blank" href="https://groups.io/mt/77328429/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>