<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.EmailStyle21
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Pushed via:<o:p></o:p></p>
<p class="MsoNormal">PR - <a href="https://github.com/tianocore/edk2/pull/987">https://github.com/tianocore/edk2/pull/987</a><o:p></o:p></p>
<p class="MsoNormal">Commit - c640186ec8aae6164123ee38de6409aed69eab12<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Best Regards,<o:p></o:p></p>
<p class="MsoNormal">Hao Wu<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b>From:</b> devel@edk2.groups.io <devel@edk2.groups.io> <b>
On Behalf Of </b>Jeff Brasen<br>
<b>Sent:</b> Tuesday, October 6, 2020 5:27 AM<br>
<b>To:</b> Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io<br>
<b>Cc:</b> Dong, Eric <eric.dong@intel.com><br>
<b>Subject:</b> Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Are we looking for any other reviews on this?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Jeff<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b>From:</b> Jeff Brasen <<a href="mailto:jbrasen@nvidia.com">jbrasen@nvidia.com</a>>
<br>
<b>Sent:</b> Tuesday, September 22, 2020 4:13 PM<br>
<b>To:</b> Bi, Dandan <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>>;
<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><br>
<b>Cc:</b> Dong, Eric <<a href="mailto:eric.dong@intel.com">eric.dong@intel.com</a>><br>
<b>Subject:</b> Re: [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">Thanks Dandan, are we waiting for any additional reviews on this change?<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div id="Signature">
<div>
<p>Thanks,<o:p></o:p></p>
<p>Jeff<o:p></o:p></p>
</div>
</div>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="98%" align="center">
</div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Bi, Dandan <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>><br>
<b>Sent:</b> Monday, September 14, 2020 8:15 AM<br>
<b>To:</b> Jeff Brasen <<a href="mailto:jbrasen@nvidia.com">jbrasen@nvidia.com</a>>;
<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>><br>
<b>Cc:</b> Dong, Eric <<a href="mailto:eric.dong@intel.com">eric.dong@intel.com</a>><br>
<b>Subject:</b> RE: [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string</span>
<o:p></o:p></p>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">External email: Use caution opening links or attachments<br>
<br>
<br>
Reviewed-by: Dandan Bi <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>><br>
<br>
<br>
Thanks,<br>
Dandan<br>
> -----Original Message-----<br>
> From: Jeff Brasen <<a href="mailto:jbrasen@nvidia.com">jbrasen@nvidia.com</a>><br>
> Sent: Saturday, September 12, 2020 1:09 AM<br>
> To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><br>
> Cc: Bi, Dandan <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>>; Dong, Eric <<a href="mailto:eric.dong@intel.com">eric.dong@intel.com</a>>;<br>
> Jeff Brasen <<a href="mailto:jbrasen@nvidia.com">jbrasen@nvidia.com</a>><br>
> Subject: [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string<br>
><br>
> Update function behavior to not modify the incoming string that is marked as<br>
> CONST in the prototype.<br>
><br>
> Signed-off-by: Jeff Brasen <<a href="mailto:jbrasen@nvidia.com">jbrasen@nvidia.com</a>><br>
> ---<br>
> .../Universal/HiiDatabaseDxe/ConfigRouting.c | 12 +++++++-----<br>
> 1 file changed, 7 insertions(+), 5 deletions(-)<br>
><br>
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c<br>
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c<br>
> index 2cad6d29f4..d492b769d5 100644<br>
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c<br>
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c<br>
> @@ -5497,7 +5497,6 @@ HiiBlockToConfig (<br>
> UINTN Index; UINT8 *TemBuffer; CHAR16<br>
> *TemString;- CHAR16 TemChar; TmpBuffer = NULL; @@ -<br>
> 5564,10 +5563,13 @@ HiiBlockToConfig (<br>
> // // Copy <ConfigHdr> and an additional '&' to <ConfigResp> //-<br>
> TemChar = *StringPtr;- *StringPtr = '\0';- AppendToMultiString(Config,<br>
> ConfigRequest);- *StringPtr = TemChar;+ TemString = AllocateCopyPool<br>
> (sizeof (CHAR16) * (StringPtr - ConfigRequest + 1), ConfigRequest);+ if<br>
> (TemString == NULL) {+ return EFI_OUT_OF_RESOURCES;+ }+<br>
> TemString[StringPtr - ConfigRequest] = '\0';+ AppendToMultiString(Config,<br>
> TemString);+ FreePool (TemString); // // Parse each <RequestElement> if<br>
> exists--<br>
> 2.25.1<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"></o:p></span></p>
</div>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/65961">View/Reply Online (#65961)</a> | | <a target="_blank" href="https://groups.io/mt/76784317/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>