<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> </head> <body> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="auto"> Thanks Maciej.</div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="auto"> Abner</div> <div id="ms-outlook-mobile-signature"> <div> </div> Get <a href="https://aka.ms/ghei36">Outlook for Android</a></div> <div id="id-4ffcdd94-81bc-4536-be40-c66c98d41a22" class="ms-outlook-mobile-reference-message"> <div style="font-family: sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg">From: Rabeda, Maciej <maciej.rabeda@linux.intel.com> Sent: Friday, October 9, 2020, 5:39 PM To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) Cc: Wu Jiaxin; Fu Siyuan; Wang, Nickle (HPS SW) Subject: Re: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset </div> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> <div class="PlainText">Merged: <a href="https://github.com/tianocore/edk2/commit/5df413119ec80cb462bf9c888ef5574f8ce8ae2e">https://github.com/tianocore/edk2/commit/5df413119ec80cb462bf9c888ef5574f8ce8ae2e</a> <a href="https://github.com/tianocore/edk2/pull/995">https://github.com/tianocore/edk2/pull/995</a> On 08-Oct-20 18:17, Maciej Rabeda wrote: > Hi Abner, > > Waiting for review on a different patch on NetworkPkg, else CI likely > fires in my face when I try to integrate yours. > > <a href="https://edk2.groups.io/g/devel/message/65833">https://edk2.groups.io/g/devel/message/65833</a> > > Thanks, > Maciej > > On 08-Oct-20 15:50, Abner Chang wrote: >> Hi Maciej, >> Could you please help to merge this patch? Thanks! >> Abner >> >>> -----Original Message----- >>> From: Rabeda, Maciej [<a href="mailto:maciej.rabeda@linux.intel.com">mailto:maciej.rabeda@linux.intel.com</a>] >>> Sent: Tuesday, September 29, 2020 9:47 PM >>> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; >>> devel@edk2.groups.io >>> Cc: Wu Jiaxin <jiaxin.wu@intel.com>; Fu Siyuan <siyuan.fu@intel.com>; >>> Wang, Nickle (HPS SW) <nickle.wang@hpe.com> >>> Subject: Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared >>> when reset >>> >>> Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com> >>> >>> On 28-Sep-20 08:29, Abner Chang wrote: >>>> BZ #2909, >>>> INVALID URI REMOVED >>>> e.org_show-5Fbug.cgi-3Fid- >>> 3D2909&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_ >>> SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=gVilLut38Vw51w0YX >>> bkL2XI7A >>>> ieZI7M- >>> u7_bYls4zQo&s=eavHqEkeSVmQnn5EYDmq9TnEyjp8MS3_hdpPDgG9hSY&e= >>>> When Http->Configure() is invoked with HttpConfigData set to NULL to >>>> reset the EFI HTTP instance, TLS child instance is destroyed but >>>> HttpInstance->TlsChildHandle is not set to NULL. After reconfiguring >>>> HTTP through Http->Configure() and sending the HTTP request to HTTPS >>>> URL, TLS child instance is not recreated because >>>> HttpInstance->TlsChildHandle is not NULL. >>>> >>>> Signed-off-by: Abner Chang <abner.chang@hpe.com> >>>> >>>> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com> >>>> Cc: Wu Jiaxin <jiaxin.wu@intel.com> >>>> Cc: Fu Siyuan <siyuan.fu@intel.com> >>>> Cc: Nickle Wang <nickle.wang@hpe.com> >>>> --- >>>> NetworkPkg/HttpDxe/HttpProto.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/NetworkPkg/HttpDxe/HttpProto.c >>>> b/NetworkPkg/HttpDxe/HttpProto.c index 3c7c6ff9f0c..afc7db5a726 >>> 100644 >>>> --- a/NetworkPkg/HttpDxe/HttpProto.c >>>> +++ b/NetworkPkg/HttpDxe/HttpProto.c >>>> @@ -873,6 +873,7 @@ HttpCleanProtocol ( >>>> // Destroy the TLS instance. >>>> // >>>> HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, >>>> HttpInstance->TlsChildHandle); >>>> + HttpInstance->TlsChildHandle = NULL; >>>> } >>>> >>>> if (HttpInstance->Tcp4ChildHandle != NULL) { >> >> >> >> >> > > > > > > </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/66061">View/Reply Online (#66061)</a> | | <a target="_blank" href="https://groups.io/mt/77169386/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>