<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Try removing the extra line between SPDX and ##.</p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">- Bret<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="border:none;padding:0in"><b>From: </b><a href="mailto:abner.chang@hpe.com">Chang, Abner (HPS SW/FW Technologist)</a><br>
<b>Sent: </b>Thursday, October 15, 2020 9:32 AM<br>
<b>To: </b><a href="mailto:Bret.Barkelew@microsoft.com">Bret Barkelew</a>; <a href="mailto:devel@edk2.groups.io">
devel@edk2.groups.io</a><br>
<b>Cc: </b><a href="mailto:sean.brogan@microsoft.com">Sean Brogan</a><br>
<b>Subject: </b>[EXTERNAL] RE: CI test on copyright</p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">## @file<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"># Implementation of EFI REST JSON Structure Protocol.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">#<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"># (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"># SPDX-License-Identifier: BSD-2-Clause-Patent<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">#<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">##<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Or you can check the PR,<o:p></o:p></span></p>
<p class="MsoNormal"><a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F1019&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C76b2a39f7041477ec48508d87127ed6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637383763585626301%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8pY6rGL6Z65oTSCyUGOA%2BsjmQSiwbbQiVJ%2B9LJhGAAM%3D&reserved=0">https://github.com/tianocore/edk2/pull/1019</a><span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Abner<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Bret Barkelew [mailto:Bret.Barkelew@microsoft.com]
<br>
<b>Sent:</b> Friday, October 16, 2020 12:24 AM<br>
<b>To:</b> Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io<br>
<b>Cc:</b> Sean Brogan <sean.brogan@microsoft.com><br>
<b>Subject:</b> RE: CI test on copyright<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Can you share the entire copyright header? In my experience, Its actually complaining about one of the # or /* tags.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">- Bret<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From: </b><a href="mailto:abner.chang@hpe.com">Chang, Abner (HPS SW/FW Technologist)</a><br>
<b>Sent: </b>Thursday, October 15, 2020 9:21 AM<br>
<b>To: </b><a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><br>
<b>Cc: </b><a href="mailto:Bret.Barkelew@microsoft.com">Bret Barkelew</a>; <a href="mailto:sean.brogan@microsoft.com">
Sean Brogan</a><br>
<b>Subject: </b>[EXTERNAL] CI test on copyright<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Sean and Bret,<o:p></o:p></p>
<p class="MsoNormal">I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,<o:p></o:p></p>
<p class="MsoNormal" style="background:white"><i><span style="font-size:10.0pt;font-family:"Courier New";color:#004080">(C) Copyright 2020 Hewlett Packard Enterprise Development LP</span></i><b><span style="font-size:10.0pt;font-family:"Courier New";color:#404040"><</span></b><b><span style="font-size:10.0pt;font-family:"Courier New";color:#00305C">BR</span></b><b><span style="font-size:10.0pt;font-family:"Courier New";color:#404040">><o:p></o:p></span></b></p>
<p class="MsoNormal" style="background:white"><b><span style="font-size:10.0pt;font-family:"Courier New";color:#404040"><o:p> </o:p></span></b></p>
<p class="MsoNormal" style="background:white"><b><span style="font-size:10.0pt;font-family:"Courier New";color:#404040"><img border="0" width="638" height="189" style="width:6.6488in;height:1.9642in" id="Picture_x0020_3" src="cid:image001.png@01D6A353.D58FEA40"></span></b><b><span style="font-size:10.0pt;font-family:"Courier New";color:#404040"><o:p></o:p></span></b></p>
<p class="MsoNormal" style="background:white"><b><span style="font-size:10.0pt;font-family:"Courier New";color:#404040"><o:p> </o:p></span></b></p>
<p class="MsoNormal" style="background:white"><b><span style="font-size:10.0pt;font-family:"Courier New";color:#404040"><o:p> </o:p></span></b></p>
<p class="MsoNormal" style="background:white"><span style="color:black">The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.</span><span style="font-size:10.0pt;font-family:"Courier New";color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><i><span style="font-size:10.0pt;font-family:"Courier New";color:#004080">Copyright (C) 2020 Hewlett Packard Enterprise Development LP</span></i><b><span style="font-size:10.0pt;font-family:"Courier New";color:#404040"><</span></b><b><span style="font-size:10.0pt;font-family:"Courier New";color:#00305C">BR</span></b><b><span style="font-size:10.0pt;font-family:"Courier New";color:#404040">></span></b><span style="font-size:10.0pt;font-family:"Courier New";color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Any idea on this?<o:p></o:p></p>
<p class="MsoNormal">Abner<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/66278">View/Reply Online (#66278)</a> | | <a target="_blank" href="https://groups.io/mt/77531759/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>