<div dir="ltr"><div>hi Sami,</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 5 Nov 2020 at 16:04, Sami Mujawar <<a href="mailto:Sami.Mujawar@arm.com">Sami.Mujawar@arm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Sughosh,<br>
<br>
Thank you for this patch.<br>
<br>
Please see my response inline marked [SAMI].<br></blockquote><div><br></div><div>Thanks for your review comments. I will incorporate the comments in the v2 series. Will wait for a few more days for any other review comments on the patch series.</div><div><br></div><div>-sughosh</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Regards,<br>
<br>
Sami Mujawar<br>
<br>
-----Original Message-----<br>
From: Sughosh Ganu <<a href="mailto:sughosh.ganu@linaro.org" target="_blank">sughosh.ganu@linaro.org</a>> <br>
Sent: 21 October 2020 12:32 PM<br>
To: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a><br>
Cc: Ard Biesheuvel <<a href="mailto:Ard.Biesheuvel@arm.com" target="_blank">Ard.Biesheuvel@arm.com</a>>; Sami Mujawar <<a href="mailto:Sami.Mujawar@arm.com" target="_blank">Sami.Mujawar@arm.com</a>>; Jiewen Yao <<a href="mailto:jiewen.yao@intel.com" target="_blank">jiewen.yao@intel.com</a>>; Achin Gupta <<a href="mailto:Achin.Gupta@arm.com" target="_blank">Achin.Gupta@arm.com</a>><br>
Subject: [PATCH v1 01/12] ArmPkg/IndustryStandard: Add barebones FF-A header<br>
<br>
From: Achin Gupta <<a href="mailto:achin.gupta@arm.com" target="_blank">achin.gupta@arm.com</a>><br>
<br>
This patch adds a rudimentary header file with defines for FF-A ABIs<br>
that will be used as the transport between S-EL0 and the SPM<br>
<br>
Signed-off-by: Achin Gupta <<a href="mailto:achin.gupta@arm.com" target="_blank">achin.gupta@arm.com</a>><br>
---<br>
 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 16 ++++++++++++++++<br>
 1 file changed, 16 insertions(+)<br>
<br>
diff --git a/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h<br>
new file mode 100644<br>
index 0000000000..a8914085de<br>
--- /dev/null<br>
+++ b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h<br>
@@ -0,0 +1,16 @@<br>
+/** @file<br>
[SAMI] Please add file description, see section 5.2.3.1 of EDKII coding standard specification (<a href="https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/52_spacing" rel="noreferrer" target="_blank">https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/52_spacing</a>)<br>
[/SAMI]<br>
+*<br>
+*  Copyright (c) 2020, ARM Limited. All rights reserved.<br>
+*<br>
+*  SPDX-License-Identifier: BSD-2-Clause-Patent<br>
[SAMI] Add reference to the specification, see section 5.2.3.5 of EDKII coding standard specification.<br>
[/SAMI]<br>
+*<br>
+**/<br>
+<br>
+#ifndef __ARM_FFA_SVC_H__<br>
+#define __ARM_FFA_SVC_H__<br>
[SAMI] Make include guard compliant with EDKII coding standard, see section 5.3.5 (<a href="https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/53_include_files" rel="noreferrer" target="_blank">https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/53_include_files</a>)<br>
[/SAMI]<br>
+<br>
+#define ARM_SVC_ID_FFA_VERSION_AARCH32                  0x84000063<br>
+#define ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ_AARCH64      0xC400006F<br>
+#define ARM_SVC_ID_FFA_MSG_SEND_DIRECT_RESP_AARCH64     0xC4000070<br>
+<br>
+#endif<br>
-- <br>
2.17.1<br>
<br>
</blockquote></div></div>


 <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p>   You receive all messages sent to this group.    <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/67088">View/Reply Online (#67088)</a> |    |  <a target="_blank" href="https://groups.io/mt/77703647/1813853">Mute This Topic</a>  | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>    <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |  <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>  [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>