<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi EDK2 Dev,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">We met a system hang issue recently and after investigation, it was caused by invalid data returned by “InternalImageHandleToFvHandle” of DxeServicesLib.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">We call GetSectionFromAnyFv-> InternalImageHandleToFvHandle to get handle.
<o:p></o:p></p>
<p class="MsoNormal">But InternalImageHandleToFvHandle cannot locate LoadedImageProtocol (This is expected). The returned status is “Invalid Parameter” and “<span style="background:lime;mso-highlight:lime">LoadedImage</span>” pointer is NULL.<o:p></o:p></p>
<p class="MsoNormal">The problem is InternalImageHandleToFvHandle does not check returned status or “<span style="background:lime;mso-highlight:lime">LoadedImage</span>” pointer, just return “LoadedImage->DeviceHandle”.<o:p></o:p></p>
<p class="MsoNormal">Since “<span style="background:lime;mso-highlight:lime">LoadedImage</span>” pointer is NULL, “LoadedImage->DeviceHandle” is invalid handle (random data, but not NULL) which cause system hang.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I think InternalImageHandleToFvHandle should check returned status or “LoadedImage” pointer. If it is failed, just return NULL, not any random data.
<o:p></o:p></p>
<p class="MsoNormal"><img width="440" height="272" style="width:4.5833in;height:2.8333in" id="Picture_x0020_2" src="cid:image001.jpg@01D6B9DF.9634B310"><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#0070C0">Best Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#0070C0">Rick Cai<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/67528">View/Reply Online (#67528)</a> | | <a target="_blank" href="https://groups.io/mt/78233251/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>