<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Leif,</div>
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
I got these from <a href="https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md" id="LPlnk">https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md</a></div>
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
A</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Leif Lindholm via groups.io <leif=nuviainc.com@groups.io><br>
<b>Sent:</b> Tuesday, November 17, 2020 10:02 AM<br>
<b>To:</b> Andrei Warkentin <andrey.warkentin@gmail.com><br>
<b>Cc:</b> devel@edk2.groups.io <devel@edk2.groups.io>; ard.biesheuvel@arm.com <ard.biesheuvel@arm.com>; pete@akeo.ie <pete@akeo.ie>; philmd@redhat.com <philmd@redhat.com><br>
<b>Subject:</b> Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi Andrei,<br>
<br>
On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote:<br>
> Like the Pi 4B, the 3GB/4GB choices apply to it as well.<br>
> <br>
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com><br>
<br>
Patch looks straghtforward enough, but ideally I'd like someone to<br>
chime in with tested-by. That hasn't happened so far - are these<br>
documented anywhere I could easily sanity check myself?<br>
<br>
/<br>
    Leif<br>
<br>
> ---<br>
>  Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++++<br>
>  1 file changed, 6 insertions(+)<br>
> <br>
> diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c<br>
> index 5302ccd8..ade91c9f 100644<br>
> --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c<br>
> +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c<br>
> @@ -596,6 +596,10 @@ RpiFirmwareGetModelName (<br>
>      return "Raspberry Pi Compute Module 3+";<br>
>    case 0x11:<br>
>      return "Raspberry Pi 4 Model B";<br>
> +  case 0x13:<br>
> +    return "Raspberry Pi 400";<br>
> +  case 0x14:<br>
> +    return "Raspberry Pi Compute Module 4";<br>
>    default:<br>
>      return "Unknown Raspberry Pi Model";<br>
>    }<br>
> @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily (<br>
>        *ModelFamily = 3;<br>
>        break;<br>
>    case 0x11:          // Raspberry Pi 4 Model B<br>
> +  case 0x13:          // Raspberry Pi 400<br>
> +  case 0x14:          // Raspberry Pi Computer Module 4<br>
>        *ModelFamily = 4;<br>
>        break;<br>
>    default:<br>
> -- <br>
> 2.20.1<br>
> <br>
<br>
<br>
<br>
<br>
<br>
</div>
</span></font></div>
</body>
</html>


 <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p>   You receive all messages sent to this group.    <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/67680">View/Reply Online (#67680)</a> |    |  <a target="_blank" href="https://groups.io/mt/78267546/1813853">Mute This Topic</a>  | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>    <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |  <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>  [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>