<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=gb2312"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style></style></head><body lang=ZH-CN link=blue vlink=purple style='word-wrap:break-word'><div class=WordSection1>Andrei:<o:p></o:p> If you know the broken platforms, you can also contribute the patch to fix them. <o:p></o:p><o:p> </o:p> For this patch, it has passed the code review. The comment is to update the commit message with below.<o:p></o:p><o:p> </o:p>Fixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect VariablePolicy business logic to VariableServices")<o:p></o:p><o:p> </o:p>Thanks<o:p></o:p>Liming<o:p></o:p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'>发件人: Andrei Warkentin <awarkentin@vmware.com> 发送时间: 2020年11月20日 3:53 收件人: Philippe Mathieu-Daudé <philmd@redhat.com>; Andrei Warkentin <andrey.warkentin@gmail.com>; devel@edk2.groups.io; Bret Barkelew <brbarkel@microsoft.com>; Dandan Bi <dandan.bi@intel.com>; Jian J Wang <jian.j.wang@intel.com>; pete@akeo.ie 抄送: ard.biesheuvel@arm.com; leif@nuviainc.com; Liming Gao <gaoliming@byosoft.com.cn> 主题: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again.<o:p></o:p></div></div><o:p> </o:p><div>Sorry, folks, is there anything actionable for me here to do?<o:p></o:p></div><div><o:p> </o:p></div><div>It does appear that all the other edk2-platforms are broken/affected as well.<o:p></o:p></div><div><o:p> </o:p></div><div>A<o:p></o:p></div><div class=MsoNormal align=center style='text-align:center'><hr size=2 width="98%" align=center></div><div id=divRplyFwdMsg>From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> on behalf of Pete Batard via groups.io <<a href="mailto:pete=akeo.ie@groups.io">pete=akeo.ie@groups.io</a>> Sent: Thursday, November 19, 2020 11:33 AM To: Philippe Mathieu-Daudé <<a href="mailto:philmd@redhat.com">philmd@redhat.com</a>>; Andrei Warkentin <<a href="mailto:andrey.warkentin@gmail.com">andrey.warkentin@gmail.com</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>; Bret Barkelew <<a href="mailto:brbarkel@microsoft.com">brbarkel@microsoft.com</a>>; Dandan Bi <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>>; Jian J Wang <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>> Cc: <a href="mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com</a> <<a href="mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com</a>>; <a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a> <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>>; Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>> Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. <o:p></o:p><div> <o:p></o:p></div></div><div><div>Hi Philippe, On 2020.11.19 17:28, Philippe Mathieu-Daudé wrote: > On 11/19/20 6:14 PM, Pete Batard wrote: >> For reference, this breakage was introduced with edk2 commit >> <a href="https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fcommit%2Fb6490426e3208de7d6cbd756276a02e4329cd85a&data=04%7C01%7Cawarkentin%40vmware.com%7C912c541f65924d5c6a6108d88cb139b8%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637414040092341605%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=K%2Fe45o3ZvD29UaHNFzCKLBMil8lJ1adSB2mRiC0uVy0%3D&reserved=0">https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fcommit%2Fb6490426e3208de7d6cbd756276a02e4329cd85a&data=04%7C01%7Cawarkentin%40vmware.com%7C912c541f65924d5c6a6108d88cb139b8%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637414040092341605%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=K%2Fe45o3ZvD29UaHNFzCKLBMil8lJ1adSB2mRiC0uVy0%3D&reserved=0</a> >> (MdeModulePkg: Connect VariablePolicy business logic to VariableServices). > > It is better if Andrei Cc the developers involved (Cc'ed them now). Good point. > >> >> It'll probably be worth adding a reference to it in the commit message >> during integration. > > This can be added before the S-o-b: > > Fixes: b6490426e320 ("MdeModulePkg: Connect VariablePolicy business > logic to VariableServices") Just going to nitpick that since we're patching in edk2-platforms and referencing an edk2 commit, we'll want: Fixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect VariablePolicy business logic to VariableServices") For GitHub to produce a clickable link. Regards, /Pete > >> >> With this: >> >> On 2020.11.19 00:01, Andrei Warkentin wrote: >>> Add VariablePolicyLib and its dependency. >>> >>> Testing: Pi 4 boot. >>> >>> Signed-off-by: Andrei Warkentin <<a href="mailto:andrey.warkentin@gmail.com">andrey.warkentin@gmail.com</a>> >>> --- >>> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ >>> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ >>> 2 files changed, 6 insertions(+) >>> >>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> index 325d7bdb..9408138d 100644 >>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> @@ -169,6 +169,8 @@ >>> >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >>> >>> !endif >>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >>> >>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>> [LibraryClasses.common.SEC] >>> @@ -218,6 +220,7 @@ >>> >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >>> >>> !if $(SECURE_BOOT_ENABLE) == TRUE >>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> index c994f56d..4e5a36ed 100644 >>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> @@ -169,6 +169,8 @@ >>> >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >>> >>> !endif >>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >>> >>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>> # >>> @@ -226,6 +228,7 @@ >>> >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >>> >>> !if $(SECURE_BOOT_ENABLE) == TRUE >>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> >> >> Reviewed-by: Pete Batard <<a href="mailto:pete@akeo.ie">pete@akeo.ie</a>> >> > <o:p></o:p></div></div></div></div></body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/67753">View/Reply Online (#67753)</a> | | <a target="_blank" href="https://groups.io/mt/78384493/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>