<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> <p class="MsoNormal">Reviewed-by: Samer El-Haj-Mahmoud <<a href="mailto:Samer.El-Haj-Mahmoud@arm.com">Samer.El-Haj-Mahmoud@arm.com</a>><o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> devel@edk2.groups.io <devel@edk2.groups.io> <b> On Behalf Of </b>Andrei Warkentin via groups.io<br> <b>Sent:</b> Wednesday, November 18, 2020 6:21 PM<br> <b>To:</b> Andrei Warkentin <andrey.warkentin@gmail.com>; devel@edk2.groups.io; leif@nuviainc.com<br> <b>Cc:</b> Ard Biesheuvel <Ard.Biesheuvel@arm.com>; pete@akeo.ie; philmd@redhat.com<br> <b>Subject:</b> Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black">Hi Leif,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black">I got these from <a href="https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md">https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md</a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black">A<o:p></o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> on behalf of Leif Lindholm via groups.io <<a href="mailto:leif=nuviainc.com@groups.io">leif=nuviainc.com@groups.io</a>><br> <b>Sent:</b> Tuesday, November 17, 2020 10:02 AM<br> <b>To:</b> Andrei Warkentin <<a href="mailto:andrey.warkentin@gmail.com">andrey.warkentin@gmail.com</a>><br> <b>Cc:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>; <a href="mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com</a> <<a href="mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com</a>>; <a href="mailto:pete@akeo.ie">pete@akeo.ie</a> <<a href="mailto:pete@akeo.ie">pete@akeo.ie</a>>; <a href="mailto:philmd@redhat.com">philmd@redhat.com</a> <<a href="mailto:philmd@redhat.com">philmd@redhat.com</a>><br> <b>Subject:</b> Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt">Hi Andrei,<br> <br> On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote:<br> > Like the Pi 4B, the 3GB/4GB choices apply to it as well.<br> > <br> > Signed-off-by: Andrei Warkentin <<a href="mailto:andrey.warkentin@gmail.com">andrey.warkentin@gmail.com</a>><br> <br> Patch looks straghtforward enough, but ideally I'd like someone to<br> chime in with tested-by. That hasn't happened so far - are these<br> documented anywhere I could easily sanity check myself?<br> <br> /<br> Leif<br> <br> > ---<br> > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++++<br> > 1 file changed, 6 insertions(+)<br> > <br> > diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c<br> > index 5302ccd8..ade91c9f 100644<br> > --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c<br> > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c<br> > @@ -596,6 +596,10 @@ RpiFirmwareGetModelName (<br> > return "Raspberry Pi Compute Module 3+";<br> > case 0x11:<br> > return "Raspberry Pi 4 Model B";<br> > + case 0x13:<br> > + return "Raspberry Pi 400";<br> > + case 0x14:<br> > + return "Raspberry Pi Compute Module 4";<br> > default:<br> > return "Unknown Raspberry Pi Model";<br> > }<br> > @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily (<br> > *ModelFamily = 3;<br> > break;<br> > case 0x11: // Raspberry Pi 4 Model B<br> > + case 0x13: // Raspberry Pi 400<br> > + case 0x14: // Raspberry Pi Computer Module 4<br> > *ModelFamily = 4;<br> > break;<br> > default:<br> > -- <br> > 2.20.1<br> > <br> <br> <br> <br> <br> <o:p></o:p></p> </div> </div> <div> <p class="MsoNormal"></o:p></span></p> </div> </div> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/67780">View/Reply Online (#67780)</a> | | <a target="_blank" href="https://groups.io/mt/78267546/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>