<div dir="ltr"><div>hi Sami,</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 23 Nov 2020 at 20:03, Sami Mujawar <<a href="mailto:Sami.Mujawar@arm.com">Sami.Mujawar@arm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Sughosh,<br>
<br>
I have completed reviewing this patch series.<br>
<br>
Please add some description in the commit message for the following patches. Otherwise patch 3 & 8 look good to me.<br>
[PATCH v1 08/12] StandaloneMmPkg: Use FF-A header file in Standalone MM Arm MMU library<br>
[PATCH v1 03/12] StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry point<br></blockquote><div><br></div><div>Thanks a lot for reviewing the patches. I will incorporate your review comments on all the patches, and send a V2.</div><div><br></div><div>-sughosh</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Regards,<br>
<br>
Sami Mujawar<br>
<br>
-----Original Message-----<br>
From: Sughosh Ganu <<a href="mailto:sughosh.ganu@linaro.org" target="_blank">sughosh.ganu@linaro.org</a>> <br>
Sent: 21 October 2020 12:32 PM<br>
To: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a><br>
Cc: Ard Biesheuvel <<a href="mailto:Ard.Biesheuvel@arm.com" target="_blank">Ard.Biesheuvel@arm.com</a>>; Sami Mujawar <<a href="mailto:Sami.Mujawar@arm.com" target="_blank">Sami.Mujawar@arm.com</a>>; Jiewen Yao <<a href="mailto:jiewen.yao@intel.com" target="_blank">jiewen.yao@intel.com</a>><br>
Subject: [PATCH v1 00/12] Add support for using FF-A calls<br>
<br>
Achin Gupta (8):<br>
ArmPkg/IndustryStandard: Add barebones FF-A header<br>
ArmPkg/ArmSvcLib: Return x4-x7 in output parameters<br>
StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry<br>
point<br>
StandaloneMmPkg: Add option to use FF-A calls for getting SPM version<br>
StandaloneMmPkg: Add option to use FF-A calls for communication with<br>
SPM<br>
StandaloneMmPkg: Use FF-A header file in Standalone MM Arm MMU library<br>
ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to get memory<br>
region's permissions<br>
ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to set memory<br>
region's permissions<br>
<br>
Ilias Apalodimas (2):<br>
MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase<br>
to Pcd<br>
StandaloneMmPkg: Allow sending FFA Direct Request message to<br>
StandaloneMm<br>
<br>
Sughosh Ganu (1):<br>
ArmPkg: Introduce support for PcdFfaEnable<br>
<br>
Sughossh Ganu (1):<br>
StandaloneMmPkg: Add the SPM version for FF-A<br>
<br>
ArmPkg/ArmPkg.dec | 3 +<br>
.../ArmMmuStandaloneMmLib.inf | 3 +<br>
.../RuntimeDxe/VariableStandaloneMm.inf | 6 +-<br>
.../StandaloneMmCoreEntryPoint.inf | 3 +<br>
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 16 +++<br>
.../AArch64/ArmMmuStandaloneMmLib.c | 53 +++++++--<br>
.../StandaloneMmCpu/AArch64/EventHandle.c | 4 +-<br>
.../AArch64/StandaloneMmCoreEntryPoint.c | 103 ++++++++++++++----<br>
ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S | 2 +<br>
9 files changed, 155 insertions(+), 38 deletions(-)<br>
create mode 100644 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h<br>
<br>
-- <br>
2.17.1<br>
<br>
<br>
</blockquote></div></div>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/67874">View/Reply Online (#67874)</a> | | <a target="_blank" href="https://groups.io/mt/77703646/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>