<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-2022-jp"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> Hi Arvin,<o:p></o:p> <o:p> </o:p> This patch is scheduled to be submitted in master today.<o:p></o:p> <o:p> </o:p> With Warm Regards, Edhay<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Chen, ArvinX <arvinx.chen@intel.com> Sent: 24 November 2020 11:17 To: devel@edk2.groups.io; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Jin, Eric <eric.jin@intel.com>; gaoliming@byosoft.com.cn; Chu, Maggie <maggie.chu@intel.com> Subject: $B2sJ$(B: [edk2-devel] [PATCH 2/2] uefi-sct/SctPkg: Correct BBTestEraseBlocks behavior (EFI_BLOCK_IO_PROTOCOL)<o:p></o:p> </div> </div> <o:p> </o:p> <div> Hi all,<o:p></o:p> </div> <div> <o:p> </o:p> </div> <div> If this patch is OK to you guys~ maybe we can submit it into master ^^<o:p></o:p> </div> <div> <o:p> </o:p> </div> <div> Thanks!<o:p></o:p> </div> <div> Arvin<o:p></o:p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> $B4s7o<T(B: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> $BBeI=(B Samer El-Haj-Mahmoud <<a href="mailto:samer.el-haj-mahmoud@arm.com">samer.el-haj-mahmoud@arm.com</a>> $B4s7oF|4|(B: 2020$BG/(B11$B7n(B17$BF|(B $B2<8a(B 09:53 $BZ@7o<T(B: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>; Chen, ArvinX <<a href="mailto:arvinx.chen@intel.com">arvinx.chen@intel.com</a>> $BI{K\(B: G Edhaya Chandran <<a href="mailto:Edhaya.Chandran@arm.com">Edhaya.Chandran@arm.com</a>>; Jin, Eric <<a href="mailto:eric.jin@intel.com">eric.jin@intel.com</a>>; <a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a> <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Chu, Maggie <<a href="mailto:maggie.chu@intel.com">maggie.chu@intel.com</a>>; Samer El-Haj-Mahmoud <<a href="mailto:Samer.El-Haj-Mahmoud@arm.com">Samer.El-Haj-Mahmoud@arm.com</a>> $B<g;](B: Re: [edk2-devel] [PATCH 2/2] uefi-sct/SctPkg: Correct BBTestEraseBlocks behavior (EFI_BLOCK_IO_PROTOCOL) <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> Thanks for the explanation.<o:p></o:p> <o:p></o:p> Reviewed-By: Samer El-Haj-Mahmoud <<a href="mailto:Samer.El-Haj-Mahmoud@arm.com">Samer.El-Haj-Mahmoud@arm.com</a>><o:p></o:p> <o:p></o:p> <o:p></o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> On Behalf Of Chen, ArvinX via groups.io Sent: Tuesday, November 17, 2020 12:51 AM To: Samer El-Haj-Mahmoud <<a href="mailto:Samer.El-Haj-Mahmoud@arm.com">Samer.El-Haj-Mahmoud@arm.com</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> Cc: G Edhaya Chandran <<a href="mailto:Edhaya.Chandran@arm.com">Edhaya.Chandran@arm.com</a>>; Jin, Eric <<a href="mailto:eric.jin@intel.com">eric.jin@intel.com</a>>; <a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>; Chu, Maggie <<a href="mailto:maggie.chu@intel.com">maggie.chu@intel.com</a>> Subject: $B2sJ$(B: [edk2-devel] [PATCH 2/2] uefi-sct/SctPkg: Correct BBTestEraseBlocks behavior (EFI_BLOCK_IO_PROTOCOL)<o:p></o:p> </div> </div> <o:p></o:p> <div> HI Samer,<o:p></o:p> </div> <div> <o:p></o:p> </div> <div> Sorry for the slow reply, In EMMC's case, it allowed storage firmware erase to "1" to be a valid behavior (please reference the spec of emmc JESD84-B51/6.6.9), so once verification team use kind of this device, the test case will always failed. To avoid this problem, I think this change is required.<o:p></o:p> </div> <div> <o:p></o:p> </div> <div> Thanks!!<o:p></o:p> </div> <div> Arvin<o:p></o:p> </div> <div> <div> <o:p></o:p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> $B4s7o<T(B: Samer El-Haj-Mahmoud <<a href="mailto:Samer.El-Haj-Mahmoud@arm.com">Samer.El-Haj-Mahmoud@arm.com</a>> $B4s7oF|4|(B: 2020$BG/(B11$B7n(B12$BF|(B $B>e8a(B 04:56 $BZ@7o<T(B: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>; Chen, ArvinX <<a href="mailto:arvinx.chen@intel.com">arvinx.chen@intel.com</a>> $BI{K\(B: G Edhaya Chandran <<a href="mailto:Edhaya.Chandran@arm.com">Edhaya.Chandran@arm.com</a>>; Jin, Eric <<a href="mailto:eric.jin@intel.com">eric.jin@intel.com</a>>; Samer El-Haj-Mahmoud <<a href="mailto:Samer.El-Haj-Mahmoud@arm.com">Samer.El-Haj-Mahmoud@arm.com</a>>; <a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a> <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>> $B<g;](B: RE: [edk2-devel] [PATCH 2/2] uefi-sct/SctPkg: Correct BBTestEraseBlocks behavior (EFI_BLOCK_IO_PROTOCOL) <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> Hi Chen, The UEFI Specification 2.8ErrataB (page 575) states that " It is the intention of the EraseBlocks() operation to be at least as performant as writing zeroes to each of the specified LBA locations while ensuring the equivalent security." So while not explicitly saying that Erase should "erase to 0", it implies that at least is the intention. Do we know that erasing to "1" is a valid behavior? > -----Original Message----- > From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> On Behalf Of Chen, > ArvinX via groups.io > Sent: Monday, November 2, 2020 5:00 AM > To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> > Cc: G Edhaya Chandran <<a href="mailto:Edhaya.Chandran@arm.com">Edhaya.Chandran@arm.com</a>>; Eric Jin > <<a href="mailto:eric.jin@intel.com">eric.jin@intel.com</a>> > Subject: [edk2-devel] [PATCH 2/2] uefi-sct/SctPkg: Correct > BBTestEraseBlocks behavior (EFI_BLOCK_IO_PROTOCOL) > > REF: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3022">https://bugzilla.tianocore.org/show_bug.cgi?id=3022</a> > > > > The storage device erase behavior may have two possibilities: > > 1.Write all data into "0" > > 2.Write all data into "1" > > but now tool behavior can only check case 1 (Write all data into "0"), > > so we need add the other case into SCT tool to correct the test behavior. > > > > Cc: G Edhaya Chandran <<a href="mailto:Edhaya.Chandran@arm.com">Edhaya.Chandran@arm.com</a>> > > Cc: Eric Jin <<a href="mailto:eric.jin@intel.com">eric.jin@intel.com</a>> > > Signed-off-by: ArvinX Chen <<a href="mailto:arvinx.chen@intel.com">arvinx.chen@intel.com</a>> > > --- > > .../BlackBoxTest/EraseBlockBBTestFunction.c | 55 +++++++++++++++---- > > 1 file changed, 43 insertions(+), 12 deletions(-) > > > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/EraseBlock/BlackBoxTest/EraseBlock > BBTestFunction.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/EraseBlock/BlackBoxTest/EraseBlock > BBTestFunction.c > > index cbf43e1d..dbbb70c6 100644 > > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/EraseBlock/BlackBoxTest/EraseBlock > BBTestFunction.c > > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/EraseBlock/BlackBoxTest/EraseBlock > BBTestFunction.c > > @@ -71,6 +71,7 @@ BBTestEraseBlocksFunctionTest ( > > UINT64 Index; > > UINTN Index1; > > UINTN Remainder; > > + UINT64 EraseCounter; > > > > EFI_ERASE_BLOCK_TOKEN Token; > > EFI_BLOCK_IO2_TOKEN BlockIo2Token; > > @@ -223,26 +224,41 @@ BBTestEraseBlocksFunctionTest ( > > // Read the data with 0, the first/last block should not be erased > > ReadStatus = BlockIo->ReadBlocks (BlockIo, MediaId, Lba, BufferSize, > (VOID*)Buffer2); > > if (ReadStatus == EFI_SUCCESS) { > > - for (Index1 = 0; Index1 < BlockSize; Index1++) { > > - if (Buffer2[Index1] != 0) { > > + for (Index1 = 0, EraseCounter = 0; Index1 < BlockSize; Index1++) { > > + if (Buffer2[Index1] != 0x00 && Buffer2[Index1] != 0xFF) { > > IsZero1 = FALSE; > > break; > > + } else if (Buffer2[Index1] == 0x00) { > > + EraseCounter++; > > } > > } > > + if (EraseCounter!=0 && EraseCounter!=BlockSize) { > > + IsZero1 = FALSE; > > + } > > > > - for (Index1 = BlockSize; Index1 < BufferSize - BlockSize; Index1++) { > > - if (Buffer2[Index1] != 0) { > > + for (Index1 = BlockSize, EraseCounter = 0; Index1 < BufferSize - > BlockSize; Index1++) { > > + if (Buffer2[Index1] != 0x00 && Buffer2[Index1] != 0xFF) { > > IsZero2 = FALSE; > > break; > > + } else if (Buffer2[Index1] == 0x00) { > > + EraseCounter++; > > } > > } > > + if (EraseCounter!=0 && EraseCounter!=(BufferSize - (BlockSize*2))) { > > + IsZero2 = FALSE; > > + } > > > > - for (Index1 = BufferSize - BlockSize; Index1 < BufferSize; Index1++) { > > - if (Buffer2[Index1] != 0) { > > + for (Index1 = BufferSize - BlockSize, EraseCounter = 0; Index1 < > BufferSize; Index1++) { > > + if (Buffer2[Index1] != 0x00 && Buffer2[Index1] != 0xFF) { > > IsZero3 = FALSE; > > break; > > + } else if (Buffer2[Index1] == 0x00) { > > + EraseCounter++; > > } > > } > > + if (EraseCounter!=0 && EraseCounter!=BlockSize) { > > + IsZero3 = FALSE; > > + } > > > > if ((EraseStatus == EFI_SUCCESS) && (IsZero1 == FALSE) && (IsZero2 == > TRUE) && ((IsZero3 == FALSE))) > > AssertionType = EFI_TEST_ASSERTION_PASSED; > > @@ -492,26 +508,41 @@ BlockIo2: > > // Read the data with 0, the first/last block should not be erased > > ReadStatus = BlockIo2->ReadBlocksEx (BlockIo2, MediaId, Lba, > &BlockIo2Token, BufferSize, (VOID*)Buffer2); > > if (ReadStatus == EFI_SUCCESS) { > > - for (Index1 = 0; Index1 < BlockSize; Index1++) { > > - if (Buffer2[Index1] != 0) { > > + for (Index1 = 0, EraseCounter = 0; Index1 < BlockSize; Index1++) { > > + if (Buffer2[Index1] != 0x00 && Buffer2[Index1] != 0xFF) { > > IsZero1 = FALSE; > > break; > > + } else if (Buffer2[Index1] == 0x00) { > > + EraseCounter++; > > } > > } > > + if (EraseCounter!=0 && EraseCounter!=BlockSize) { > > + IsZero1 = FALSE; > > + } > > > > - for (Index1 = BlockSize; Index1 < BufferSize - BlockSize; Index1++) { > > - if (Buffer2[Index1] != 0) { > > + for (Index1 = BlockSize, EraseCounter = 0; Index1 < BufferSize - > BlockSize; Index1++) { > > + if (Buffer2[Index1] != 0x00 && Buffer2[Index1] != 0xFF) { > > IsZero2 = FALSE; > > break; > > + } else if (Buffer2[Index1] == 0x00) { > > + EraseCounter++; > > } > > } > > + if (EraseCounter!=0 && EraseCounter!=(BufferSize - (BlockSize*2))) { > > + IsZero2 = FALSE; > > + } > > > > - for (Index1 = BufferSize - BlockSize; Index1 < BufferSize; Index1++) { > > - if (Buffer2[Index1] != 0) { > > + for (Index1 = BufferSize - BlockSize, EraseCounter = 0; Index1 < > BufferSize; Index1++) { > > + if (Buffer2[Index1] != 0x00 && Buffer2[Index1] != 0xFF) { > > IsZero3 = FALSE; > > break; > > + } else if (Buffer2[Index1] == 0x00) { > > + EraseCounter++; > > } > > } > > + if (EraseCounter!=0 && EraseCounter!=BlockSize) { > > + IsZero3 = FALSE; > > + } > > > > if ((EraseStatus == EFI_SUCCESS) && (IsZero1 == FALSE) && (IsZero2 == > TRUE) && ((IsZero3 == FALSE))) > > AssertionType = EFI_TEST_ASSERTION_PASSED; > > -- > > 2.26.2.windows.1 > > > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#66857): <a href="https://edk2.groups.io/g/devel/message/66857"> https://edk2.groups.io/g/devel/message/66857</a> > Mute This Topic: <a href="https://groups.io/mt/77977762/1945644">https://groups.io/mt/77977762/1945644</a> > Group Owner: <a href="mailto:devel+owner@edk2.groups.io">devel+owner@edk2.groups.io</a> > Unsubscribe: <a href="https://edk2.groups.io/g/devel/unsub">https://edk2.groups.io/g/devel/unsub</a> [samer.el-haj- > <a href="mailto:mahmoud@arm.com">mahmoud@arm.com</a>] > -=-=-=-=-=-= > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.<o:p></o:p> </div> </div> </div> </div> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. <o:p></o:p> <div> </o:p> </div> </div> </div> </div> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/67868">View/Reply Online (#67868)</a> | | <a target="_blank" href="https://groups.io/mt/78471961/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>