<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Segoe UI";
panose-1:2 11 5 2 4 2 4 2 2 3;}
/* Style Definitions */
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 129.75pt 72.0pt 129.7pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoPlainText">Hi Heinrich,<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"> This part is giving a build error, can you please check.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><a href="https://github.com/tianocore/edk2-test/commit/75c92b85bf9bb82a7049bf44f40a2741f963230c#diff-7f0df1676a2f898b39de5685efb7a296a7f08e5e5ccb4aaec0a5fdebea926727">https://github.com/tianocore/edk2-test/commit/75c92b85bf9bb82a7049bf44f40a2741f963230c#diff-7f0df1676a2f898b39de5685efb7a296a7f08e5e5ccb4aaec0a5fdebea926727</a><o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><img border="0" width="1560" height="153" style="width:16.2547in;height:1.5943in" id="Picture_x0020_1" src="cid:image001.jpg@01D6C323.F7844200"><o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#252423;background:white">/home/zubmoh01/Work/sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestCoverage.c: In function ‘DevicePathToTextConvertDeviceNodeToTextCoverageTest’:</span><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#252423"><br>
<span style="background:white">/home/zubmoh01/Work/sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestCoverage.c:1203:49: error: ‘MEDIA_OFFSET_DEVICE_PATH {aka struct <anonymous>}’ has no member named ‘Length’</span><br>
<span style="background:white"> ((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Length ==</span><br>
<span style="background:white"> ^~</span><br>
<span style="background:white">"aarch64-linux-gnu-gcc" -MMD -MF /home/zubmoh01/Work/sct/Build/UefiSct/RELEASE_GCC5/AARCH64/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/Dependency/CombinationImage2/CombinationImage2/OUTPUT/ProtocolDefinition.obj.deps
-g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common -ffunction-sections -fdata-sections -DSTRING_ARRAY_NAME=ImageServices_CombinationImage2Strings -g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing
-Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common -mlittle-endian -fno-short-enums -fverbose-asm -funsigned-char -ffunction-sections -fdata-sections -Wno-address -fno-asynchronous-unwind-tables -fno-unwind-tables -fno-pic -fno-pie -ffixed-x18
-mcmodel=small -flto -Wno-unused-but-set-variable -Wno-unused-const-variable -D EFIAARCH64 -D EFIAARCH64 -ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -Wno-error=unused-but-set-variable -Wno-error -DMDEPKG_NDEBUG -c -o<o:p></o:p></span></span></p>
<p class="MsoPlainText"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#252423;background:white"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#252423;background:white"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#252423;background:white"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#252423;background:white">With Warm Regards,<br>
Edhay<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#252423;background:white"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#252423;background:white"><o:p> </o:p></span></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">> -----Original Message-----</p>
<p class="MsoPlainText">> From: Heinrich Schuchardt <xypron.glpk@gmx.de></p>
<p class="MsoPlainText">> Sent: 24 November 2020 22:38</p>
<p class="MsoPlainText">> To: G Edhaya Chandran <Edhaya.Chandran@arm.com>; devel@edk2.groups.io</p>
<p class="MsoPlainText">> Subject: Re: [edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: NULL deref in</p>
<p class="MsoPlainText">> DevicePathToText test</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> On 11/24/20 5:33 PM, G Edhaya Chandran wrote:</p>
<p class="MsoPlainText">> > Hi Heinrich,</p>
<p class="MsoPlainText">> ></p>
<p class="MsoPlainText">> > Oh okay. Actually, I have already upstreamed this.</p>
<p class="MsoPlainText">> > I suggest, I will remove the debug SctPrint myself as part of another upstream.</p>
<p class="MsoPlainText">> ></p>
<p class="MsoPlainText">> > Is it okay?</p>
<p class="MsoPlainText">> ></p>
<p class="MsoPlainText">> > With Warm Regards,</p>
<p class="MsoPlainText">> > Edhay</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> Thanks for taking care.</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> Best regards</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> Heinrich</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> ></p>
<p class="MsoPlainText">> ></p>
<p class="MsoPlainText">> >> -----Original Message-----</p>
<p class="MsoPlainText">> >> From: Heinrich Schuchardt <<a href="mailto:xypron.glpk@gmx.de"><span style="color:windowtext;text-decoration:none">xypron.glpk@gmx.de</span></a>></p>
<p class="MsoPlainText">> >> Sent: 24 November 2020 21:57</p>
<p class="MsoPlainText">> >> To: G Edhaya Chandran <<a href="mailto:Edhaya.Chandran@arm.com"><span style="color:windowtext;text-decoration:none">Edhaya.Chandran@arm.com</span></a>>;</p>
<p class="MsoPlainText">> <a href="mailto:devel@edk2.groups.io"><span style="color:windowtext;text-decoration:none">devel@edk2.groups.io</span></a></p>
<p class="MsoPlainText">> >> Subject: Re: [edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: NULL deref in</p>
<p class="MsoPlainText">> >> DevicePathToText test</p>
<p class="MsoPlainText">> >></p>
<p class="MsoPlainText">> >> On 11/24/20 5:07 PM, G Edhaya Chandran wrote:</p>
<p class="MsoPlainText">> >>> Upstreamed by commit-id</p>
<p class="MsoPlainText">> >>> :</p>
<p class="MsoPlainText">> >>> <a href="https://github.com/tianocore/edk2-test/commit/75c92b85bf9bb82a7049bf">
<span style="color:windowtext;text-decoration:none">https://github.com/tianocore/edk2-test/commit/75c92b85bf9bb82a7049bf</span></a></p>
<p class="MsoPlainText">> >>> 44</p>
<p class="MsoPlainText">> >>> f40a2741f963230c</p>
<p class="MsoPlainText">> >>></p>
<p class="MsoPlainText">> >></p>
<p class="MsoPlainText">> >> Hello Edhaya,</p>
<p class="MsoPlainText">> >></p>
<p class="MsoPlainText">> >> it seems a SctPrint() statement slipped into the patch which was only</p>
<p class="MsoPlainText">> >> used for debugging.</p>
<p class="MsoPlainText">> >></p>
<p class="MsoPlainText">> >> Should I open a new issue? Or just send a patch removing the SctPrint</p>
<p class="MsoPlainText">> >> with reference to #3029?</p>
<p class="MsoPlainText">> >></p>
<p class="MsoPlainText">> >> Best regards</p>
<p class="MsoPlainText">> >></p>
<p class="MsoPlainText">> >> Heinrich</p>
<p class="MsoPlainText">> > IMPORTANT NOTICE: The contents of this email and any attachments are</p>
<p class="MsoPlainText">> confidential and may also be privileged. If you are not the intended recipient,</p>
<p class="MsoPlainText">> please notify the sender immediately and do not disclose the contents to any</p>
<p class="MsoPlainText">> other person, use it for any purpose, or store or copy the information in any</p>
<p class="MsoPlainText">> medium. Thank you.</p>
<p class="MsoPlainText">> ></p>
<p class="MsoPlainText"><o:p> </o:p></p>
</div>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose,
or store or copy the information in any medium. Thank you.
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/67939">View/Reply Online (#67939)</a> | | <a target="_blank" href="https://groups.io/mt/77896437/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>