<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr">As long as we do not write to a RAID array it will not cause any issues, and we do not. So I do not see an issue here.</div><div dir="ltr"><br></div><div dir="ltr">Vitaly</div><div dir="ltr"><br><blockquote type="cite">On 15 Dec 2020, at 22:00, Kinney, Michael D <michael.d.kinney@intel.com> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="ProgId" content="Word.Document"> <meta name="Generator" content="Microsoft Word 15"> <meta name="Originator" content="Microsoft Word 15"> <link rel="File-List" href="cid:filelist.xml@01D6D2D1.669E5A60"><link rel="Edit-Time-Data" href="cid:editdata.mso"><style></style> <div class="WordSection1"> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-fareast-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman"">What about platforms that are in RAID mode and have configured a RAID set.<span style="mso-spacerun:yes"> </span>Your suggested change could potentially corrupt data on those different systems.<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-fareast-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-fareast-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman"">Mike<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-fareast-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="mso-fareast-font-family:"Times New Roman"">From:</span></b><span style="mso-fareast-font-family:"Times New Roman""> Vitaly Cheptsov <cheptsov@ispras.ru> <br> <b>Sent:</b> Tuesday, December 15, 2020 10:56 AM<br> <b>To:</b> Kinney, Michael D <michael.d.kinney@intel.com><br> <b>Cc:</b> devel@edk2.groups.io; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Albecki, Mateusz <mateusz.albecki@intel.com>; Laszlo Ersek <lersek@redhat.com><br> <b>Subject:</b> Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Not correct, these systems do not have hard RAID support or anything alike. It is standard G45 from what I remember. I believe the vendor simply left the firmware supplier defaults or something alike as there is a way to use IDE mode but nothing for AHCI.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Vitaly<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><br style="mso-special-character:line-break"> <br style="mso-special-character:line-break"> <o:p></o:p></span></p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="mso-fareast-font-family:"Times New Roman"">On 15 Dec 2020, at 21:09, Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>> wrote:<o:p></o:p></span></p> </blockquote> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> <o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman"">So those types of systems must have a RAID enabled FW driver.<span style="mso-spacerun:yes"> </span>Right?<span style="mso-spacerun:yes"> </span>So the drives could be configured as a RAID set and using the patch you suggest below could corrupt data.</span><o:p></o:p></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman""> </span><o:p></o:p></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman"">It is difficult to support a change that could corrupt data.</span><o:p></o:p></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman""> </span><o:p></o:p></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman"">Mike</span><o:p></o:p></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman""> </span><o:p></o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal" style="mso-outline-level:1"><b><span style="mso-fareast-font-family:"Times New Roman"">From:</span></b><span style="mso-fareast-font-family:"Times New Roman""> Vitaly Cheptsov <<a href="mailto:cheptsov@ispras.ru">cheptsov@ispras.ru</a>> <br> <b>Sent:</b> Tuesday, December 15, 2020 9:44 AM<br> <b>To:</b> Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>><br> <b>Cc:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com">hao.a.wu@intel.com</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>>; Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com">mateusz.albecki@intel.com</a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com">lersek@redhat.com</a>><br> <b>Subject:</b> Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode</span><o:p></o:p></p> </div> </div> <p class="MsoNormal"> <o:p></o:p></p> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Unfortunately not. That is basically the issue. When there is a preference, it is possible to ask the user to set it. However, for certain Dell machines, we have an issue with, it is not possible to select AHCI mode in the firmware preferences, and these users end up with unconfigurable RAID.</span><o:p></o:p></p> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Best regards,</span><o:p></o:p></p> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Vitaly</span><o:p></o:p></p> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><br style="mso-special-character:line-break"> <br style="mso-special-character:line-break"> </span><o:p></o:p></p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">15 дек. 2020 г., в 20:41, Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>> написал(а):</span><o:p></o:p></p> </div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">But do the systems allow the user to configure the FW that runs earlier? <span class="apple-converted-space"> </span>Can you require to users to configure their platforms correctly?</span><o:p></o:p></p> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Thanks,</span><o:p></o:p></p> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Mike</span><o:p></o:p></p> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <div> <p class="MsoNormal" style="mso-outline-level:1"><b><span style="mso-fareast-font-family:"Times New Roman"">From:</span></b><span class="apple-converted-space"><span style="mso-fareast-font-family:"Times New Roman""> </span></span><span style="mso-fareast-font-family:"Times New Roman""><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><span class="apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a>><span class="apple-converted-space"> </span><b>On Behalf Of<span class="apple-converted-space"> </span></b>Vitaly Cheptsov<br> <b>Sent:</b><span class="apple-converted-space"> </span>Tuesday, December 15, 2020 9:34 AM<br> <b>To:</b><span class="apple-converted-space"> </span>Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com"><span style="color:purple">michael.d.kinney@intel.com</span></a>><br> <b>Cc:</b><span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com"><span style="color:purple">hao.a.wu@intel.com</span></a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com"><span style="color:purple">ray.ni@intel.com</span></a>>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com"><span style="color:purple">jian.j.wang@intel.com</span></a>>; Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com"><span style="color:purple">mateusz.albecki@intel.com</span></a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com"><span style="color:purple">lersek@redhat.com</span></a>><br> <b>Subject:</b><span class="apple-converted-space"> </span>Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode</span><o:p></o:p></p> </div> </div> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Hi Michael,</span><o:p></o:p></p> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">I believe Intel SATA controllers have non-standard lockdown bits, which do not let you reconfigure them as soon as the initialisation is over. Since we start much later (outside of the firmware), we can no longer control this.</span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Best regards,</span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Vitaly</span><o:p></o:p></p> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><br> <br style="mso-special-character:line-break"> <br style="mso-special-character:line-break"> </span><o:p></o:p></p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">15 дек. 2020 г., в 19:58, Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com"><span style="color:purple">michael.d.kinney@intel.com</span></a>> написал(а):</span><o:p></o:p></p> </div> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Hi Vitaly,</span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Can you please explain why the controller can not be configured in a non-RAID mode?</span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Thanks,</span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Mike</span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <div> <div> <p class="MsoNormal" style="mso-outline-level:1"><b><span style="mso-fareast-font-family:"Times New Roman"">From:</span></b><span class="apple-converted-space"><span style="mso-fareast-font-family:"Times New Roman""> </span></span><span style="mso-fareast-font-family:"Times New Roman""><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><span class="apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a>><span class="apple-converted-space"> </span><b>On Behalf Of<span class="apple-converted-space"> </span></b>Vitaly Cheptsov<br> <b>Sent:</b><span class="apple-converted-space"> </span>Tuesday, December 15, 2020 12:58 AM<br> <b>To:</b><span class="apple-converted-space"> </span>Wu, Hao A <<a href="mailto:hao.a.wu@intel.com"><span style="color:purple">hao.a.wu@intel.com</span></a>>;<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><br> <b>Cc:</b><span class="apple-converted-space"> </span>Ni, Ray <<a href="mailto:ray.ni@intel.com"><span style="color:purple">ray.ni@intel.com</span></a>>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com"><span style="color:purple">jian.j.wang@intel.com</span></a>>; Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com"><span style="color:purple">mateusz.albecki@intel.com</span></a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com"><span style="color:purple">lersek@redhat.com</span></a>>; Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com"><span style="color:purple">michael.d.kinney@intel.com</span></a>><br> <b>Subject:</b><span class="apple-converted-space"> </span>Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode</span><o:p></o:p></p> </div> </div> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Hello,</span><o:p></o:p></p> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">1. Could you help to change the BZ tracker <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3118"><span style="color:purple">https://bugzilla.tianocore.org/show_bug.cgi?id=3118</span></a> to a "Tiano Feature Requests"?<br> For me, it looks more like a feature request.</span><o:p></o:p></p> </div> </div> </blockquote> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Sure, done.</span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">2. Could you help to include 'AtaAtapiPassThru' in the BZ tracker subject for better reference?</span><o:p></o:p></p> </div> </div> </blockquote> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Also done.</span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">3. For Patch 2/2, is there any reason to clear the bits:<br> EFI_ATA_PASS_THRU_ATTRIBUTES_PHYSICAL<br> EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL<br> If the drives are intended to be used as non-RAID devices, I think both the ATTRIBUTES_PHYSICAL & ATTRIBUTES_LOGICAL should be set for the controller according to the UEFI Spec.</span><o:p></o:p></p> </div> </div> </blockquote> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">I am not quite positive why this was needed (the patch was prepared a few months ago), but I will make a comment in V2 when we test it on real hardware. I think it was required to take the right path in the driver.</span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">DuetPkg was removed from edk2.<br> If the change is specially for DUET use case, I am afraid we cannot accept this change.</span><o:p></o:p></p> </div> </div> </blockquote> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">This is not the DuetPkg from EDK II, but ours[1]. Thus your claim does not apply.</span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">I agree it would be better to configure the platform so the SATA controller is in its non-RAID mode.</span><o:p></o:p></p> </div> </div> </blockquote> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Agree, but in this case it is not feasible.</span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">If the controller is in RAID mode, then the OS that is booted may have a SATA RAID driver<br> that can configure the drives in RAID mode. Then, if the UEFI FW treats it as non RAID, it<br> may not be bootable, and configuration actions in UEFI may corrupt data on the RAID configured<br> drives. For this reason, I am not in favor of adding a PCD.</span><o:p></o:p></p> </div> </div> </blockquote> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Actually some operating systems have to introduce workarounds for this as well, and no, in this particular case the OS does not treat the drive as RAID either.</span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">If there are no other review comments besides the attributes, I will proceed with V2 in the coming days.</span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Best regards,</span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Vitaly</span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">[1] <a href="https://github.com/acidanthera/OpenCorePkg"><span style="color:purple">https://github.com/acidanthera/OpenCorePkg</span></a></span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> <div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><br> <br> <br style="mso-special-character:line-break"> <br style="mso-special-character:line-break"> </span><o:p></o:p></p> </div> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">15 дек. 2020 г., в 06:54, Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com"><span style="color:purple">michael.d.kinney@intel.com</span></a>> написал(а):</span><o:p></o:p></p> </div> </div> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> <div> <div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">I agree it would be better to configure the platform so the SATA controller is in its non-RAID mode.<br> <br> If the controller is in RAID mode, then the OS that is booted may have a SATA RAID driver<br> that can configure the drives in RAID mode. Then, if the UEFI FW treats it as non RAID, it<br> may not be bootable, and configuration actions in UEFI may corrupt data on the RAID configured<br> drives. For this reason, I am not in favor of adding a PCD.<br> <br> Mike<br> <br> <br> <br style="mso-special-character:line-break"> <br style="mso-special-character:line-break"> </span><o:p></o:p></p> </div> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal" style="mso-outline-level:1"><span style="mso-fareast-font-family:"Times New Roman"">-----Original Message-----<br> From:<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><span class="apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a>> On Behalf Of Wu, Hao A<br> Sent: Monday, December 14, 2020 5:53 PM<br> To: Ni, Ray <<a href="mailto:ray.ni@intel.com"><span style="color:purple">ray.ni@intel.com</span></a>>;<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a>;<span class="apple-converted-space"> </span><a href="mailto:cheptsov@ispras.ru"><span style="color:purple">cheptsov@ispras.ru</span></a><br> Cc: Wang, Jian J <<a href="mailto:jian.j.wang@intel.com"><span style="color:purple">jian.j.wang@intel.com</span></a>>; Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com"><span style="color:purple">mateusz.albecki@intel.com</span></a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com"><span style="color:purple">lersek@redhat.com</span></a>><br> Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode<br> <br> <br> <br style="mso-special-character:line-break"> <br style="mso-special-character:line-break"> </span><o:p></o:p></p> </div> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal" style="mso-outline-level:1"><span style="mso-fareast-font-family:"Times New Roman"">-----Original Message-----<br> From: Ni, Ray <<a href="mailto:ray.ni@intel.com"><span style="color:purple">ray.ni@intel.com</span></a>><br> Sent: Tuesday, December 15, 2020 9:45 AM<br> To:<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a>;<span class="apple-converted-space"> </span><a href="mailto:cheptsov@ispras.ru"><span style="color:purple">cheptsov@ispras.ru</span></a><br> Cc: Wang, Jian J <<a href="mailto:jian.j.wang@intel.com"><span style="color:purple">jian.j.wang@intel.com</span></a>>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com"><span style="color:purple">hao.a.wu@intel.com</span></a>>;<br> Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com"><span style="color:purple">mateusz.albecki@intel.com</span></a>>; Laszlo Ersek<br> <<a href="mailto:lersek@redhat.com"><span style="color:purple">lersek@redhat.com</span></a>><br> Subject: RE: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe:<br> Add support for drives in RAID mode<br> <br> DuetPkg was removed from edk2.<br> If the change is specially for DUET use case, I am afraid we cannot accept this<br> change.<br> <br> Hao,<br> Can this change benefit a general use case?</span><o:p></o:p></p> </div> </div> </blockquote> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><br> <br> Hello Ray,<br> <br> My understanding to the proposed PCD is that drives behind a RAID mode SATA controller can be configured to working in<br> non-RAID mode (acting like individual drives).<br> <br> As for the DuetPkg, below is a previous comment from Vitaly:<br> "there is no firmware preference for that (Hao: configure the controller to non-RAID mode). The firmware does not support<br> UEFI, and we are running through DuetPkg."<br> <br> Best Regards,<br> Hao Wu<br> <br> <br> <br> <br style="mso-special-character:line-break"> <br style="mso-special-character:line-break"> </span><o:p></o:p></p> </div> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><br> Thanks,<br> Ray<br> <br> <br> <br style="mso-special-character:line-break"> <br style="mso-special-character:line-break"> </span><o:p></o:p></p> </div> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal" style="mso-outline-level:1"><span style="mso-fareast-font-family:"Times New Roman"">-----Original Message-----<br> From:<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><span class="apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a>> On Behalf Of Vitaly<br> Cheptsov<br> Sent: Friday, December 11, 2020 5:25 PM<br> To:<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io"><span style="color:purple">devel@edk2.groups.io</span></a><br> Cc: Vitaly Cheptsov <<a href="mailto:cheptsov@ispras.ru"><span style="color:purple">cheptsov@ispras.ru</span></a>>; Wang, Jian J<br> <<a href="mailto:jian.j.wang@intel.com"><span style="color:purple">jian.j.wang@intel.com</span></a>>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com"><span style="color:purple">hao.a.wu@intel.com</span></a>>; Albecki,<br> Mateusz <<a href="mailto:mateusz.albecki@intel.com"><span style="color:purple">mateusz.albecki@intel.com</span></a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com"><span style="color:purple">lersek@redhat.com</span></a>><br> Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe:</span><o:p></o:p></p> </div> </div> </blockquote> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">Add<br> <br> <br style="mso-special-character:line-break"> <br style="mso-special-character:line-break"> </span><o:p></o:p></p> </div> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <p class="MsoNormal" style="margin-bottom:12.0pt">support for drives in RAID mode<br> <br> REF:<span class="apple-converted-space"> </span><a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3118"><span style="color:purple">https://bugzilla.tianocore.org/show_bug.cgi?id=3118</span></a><br> <br> This resolves the problem of using drivers connected to Intel G33<br> builtin SATA controller when run from DuetPkg when it can only be<br> configured in RAID mode through the firmware settings.<br> <br> Cc: Jian J Wang <<a href="mailto:jian.j.wang@intel.com"><span style="color:purple">jian.j.wang@intel.com</span></a>><br> Cc: Hao A Wu <<a href="mailto:hao.a.wu@intel.com"><span style="color:purple">hao.a.wu@intel.com</span></a>><br> Cc: Mateusz Albecki <<a href="mailto:mateusz.albecki@intel.com"><span style="color:purple">mateusz.albecki@intel.com</span></a>><br> Cc: Laszlo Ersek <<a href="mailto:lersek@redhat.com"><span style="color:purple">lersek@redhat.com</span></a>><br> Signed-off-by: Vitaly Cheptsov <<a href="mailto:cheptsov@ispras.ru"><span style="color:purple">cheptsov@ispras.ru</span></a>><br> ---<br> MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c | 4 ++--<br> 1 file changed, 2 insertions(+), 2 deletions(-)<br> <br> diff --git a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c<br> b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c<br> index ab06e2833c..301335c967 100644<br> --- a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c<br> +++ b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c<br> @@ -324,7 +324,7 @@ SataControllerSupported (<br> return EFI_UNSUPPORTED;<br> }<br> <br> - if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData)) {<br> + if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData) ||<br> + IS_PCI_RAID (&PciData)) {<br> return EFI_SUCCESS;<br> }<br> <br> @@ -465,7 +465,7 @@ SataControllerStart (<br> if (IS_PCI_IDE (&PciData)) {<br> Private->IdeInit.ChannelCount = IDE_MAX_CHANNEL;<br> Private->DeviceCount = IDE_MAX_DEVICES;<br> - } else if (IS_PCI_SATADPA (&PciData)) {<br> + } else if (IS_PCI_SATADPA (&PciData) || IS_PCI_RAID (&PciData)) {<br> //<br> // Read Ports Implemented(PI) to calculate max port number (0 based).<br> //<br> --<br> 2.24.3 (Apple Git-128)<br> <br> <br> <br> -=-=-=-=-=-=<br> <a href="http://groups.io/"><span style="color:purple">Groups.io</span></a><span class="apple-converted-space"> </span>Links: You receive all messages sent to this group.<br> View/Reply Online (#68707):<br> <a href="https://edk2.groups.io/g/devel/message/68707"><span style="color:purple">https://edk2.groups.io/g/devel/message/68707</span></a><br> Mute This Topic:<span class="apple-converted-space"> </span><a href="https://groups.io/mt/78875596/1712937"><span style="color:purple">https://groups.io/mt/78875596/1712937</span></a><br> Group Owner:<span class="apple-converted-space"> </span><a href="mailto:devel+owner@edk2.groups.io"><span style="color:purple">devel+owner@edk2.groups.io</span></a><br> Unsubscribe:<span class="apple-converted-space"> </span><a href="https://edk2.groups.io/g/devel/unsub"><span style="color:purple">https://edk2.groups.io/g/devel/unsub</span></a><span class="apple-converted-space"> </span>[<a href="mailto:ray.ni@intel.com"><span style="color:purple">ray.ni@intel.com</span></a>]<br> -=-=-=-=-=-=<o:p></o:p></p> </blockquote> </blockquote> <p class="MsoNormal" style="margin-bottom:12.0pt"><br> <br> <br> <br> <br style="mso-special-character:line-break"> <br style="mso-special-character:line-break"> <o:p></o:p></p> </blockquote> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> </div> </blockquote> </div> <div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> </div> </blockquote> </div> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><o:p></o:p></p> </div> </div> </div> </blockquote> </div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> </span><o:p></o:p></p> </div> </div> </div> </blockquote> </div> </div> </div></blockquote></body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/68894">View/Reply Online (#68894)</a> | | <a target="_blank" href="https://groups.io/mt/78875596/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>