<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Mike,<div class=""><br class=""></div><div class="">That’s right. And due to that interface being vendor-specific, Intel controllers work fine. I am not positive more logic is needed since it is opt-in. These patches are not new, and so far they worked reliably on a broad amount of systems for several years.</div><div class=""><br class=""></div><div class="">From what it looks like, you are strongly opposed to getting this land into EDK II mainline, since it is too specific (at least that is how I understand your arguments). If this is the case, I guess we could abandon these changes.</div><div class=""><br class=""></div><div class="">Best regards,</div><div class="">Vitaly<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">15 дек. 2020 г., в 23:01, Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" class="">michael.d.kinney@intel.com</a>> написал(а):</div><br class="Apple-interchange-newline"><div class=""><meta charset="UTF-8" class=""><div class="WordSection1" style="page: WordSection1; caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Another issue with this approach is that the formal PCI definition of this class code is in the following spec.<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><a href="https://pcisig.com/sites/default/files/files/PCI_Code-ID_r_1_11__v24_Jan_2019.pdf" style="color: purple; text-decoration: underline;" class="">https://pcisig.com/sites/default/files/files/PCI_Code-ID_r_1_11__v24_Jan_2019.pdf</a><o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; text-indent: 0.5in;" class="">04h 00h RAID controller - vendor-specific interface<o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 14pt; font-family: "Courier New"; color: blue;" class="">#define</span><span style="font-size: 14pt; font-family: "Courier New";" class=""><span class=""> <span class="Apple-converted-space"> </span></span>PCI_CLASS_MASS_STORAGE_IDE<span class=""> <span class="Apple-converted-space"> </span></span>0x01<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 14pt; font-family: "Courier New"; color: blue;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 14pt; font-family: "Courier New"; color: blue;" class="">#define</span><span style="font-size: 14pt; font-family: "Courier New";" class=""><span class="Apple-converted-space"> </span>PCI_CLASS_MASS_STORAGE_SATADPA<span class=""> <span class="Apple-converted-space"> </span></span>0x06<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 14pt; font-family: "Courier New"; color: blue;" class="">#define</span><span style="font-size: 14pt; font-family: "Courier New";" class=""><span class=""> <span class="Apple-converted-space"> </span></span>PCI_IF_MASS_STORAGE_SATA<span class=""> <span class="Apple-converted-space"> </span></span>0x00<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 14pt; font-family: "Courier New"; color: blue;" class="">#define</span><span style="font-size: 14pt; font-family: "Courier New";" class=""><span class=""> <span class="Apple-converted-space"> </span></span>PCI_IF_MASS_STORAGE_AHCI<span class=""> <span class="Apple-converted-space"> </span></span>0x01<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 14pt; font-family: "Courier New"; color: blue;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 14pt; font-family: "Courier New"; color: blue;" class="">#define</span><span style="font-size: 14pt; font-family: "Courier New";" class=""><span class=""> <span class="Apple-converted-space"> </span></span>PCI_CLASS_MASS_STORAGE_RAID<span class=""> <span class="Apple-converted-space"> </span></span>0x04<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 14pt; font-family: "Courier New"; color: blue;" class="">#define</span><span style="font-size: 14pt; font-family: "Courier New";" class=""><span class="Apple-converted-space"> </span>IS_PCI_IDE(_p)<span class=""> <span class="Apple-converted-space"> </span></span>IS_CLASS2 (_p, PCI_CLASS_MASS_STORAGE, PCI_CLASS_MASS_STORAGE_IDE)<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 14pt; font-family: "Courier New"; color: blue;" class="">#define</span><span style="font-size: 14pt; font-family: "Courier New";" class=""><span class="Apple-converted-space"> </span>IS_PCI_SATADPA(_p) IS_CLASS2 (_p, PCI_CLASS_MASS_STORAGE, PCI_CLASS_MASS_STORAGE_SATADPA)<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 14pt; font-family: "Courier New"; color: blue;" class="">#define</span><span style="font-size: 14pt; font-family: "Courier New";" class=""><span class="Apple-converted-space"> </span>IS_PCI_RAID(_p)<span class=""> <span class="Apple-converted-space"> </span></span>IS_CLASS2 (_p, PCI_CLASS_MASS_STORAGE, PCI_CLASS_MASS_STORAGE_RAID)<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">So the IS_PCI_RAID() macro checks for the RAID class code and the PCI spec states that the interface is vendor specific.<span class=""> <span class="Apple-converted-space"> </span></span>There is no guarantee what so ever that the controller that passes IS_PCI_RAID() check has a SATA interface.<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">There are lost of risks in using this macro to see if it is a SATA controller (even if enabled by a PCD).<span class=""> <span class="Apple-converted-space"> </span></span>You need to add more logic to even know it is safe to assume SATA registers.<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Mike<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div><div class=""><div style="border-style: solid none none; border-top-width: 1pt; border-top-color: rgb(225, 225, 225); padding: 3pt 0in 0in;" class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><b class=""><span class="">From:</span></b><span class=""><span class="Apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class="">devel@edk2.groups.io</a><span class="Apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class="">devel@edk2.groups.io</a>><span class="Apple-converted-space"> </span><b class="">On Behalf Of<span class="Apple-converted-space"> </span></b>Vitaly Cheptsov<br class=""><b class="">Sent:</b><span class="Apple-converted-space"> </span>Tuesday, December 15, 2020 11:47 AM<br class=""><b class="">To:</b><span class="Apple-converted-space"> </span>Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class="">michael.d.kinney@intel.com</a>><br class=""><b class="">Cc:</b><span class="Apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class="">devel@edk2.groups.io</a>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" style="color: purple; text-decoration: underline;" class="">hao.a.wu@intel.com</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com" style="color: purple; text-decoration: underline;" class="">ray.ni@intel.com</a>>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com" style="color: purple; text-decoration: underline;" class="">jian.j.wang@intel.com</a>>; Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com" style="color: purple; text-decoration: underline;" class="">mateusz.albecki@intel.com</a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com" style="color: purple; text-decoration: underline;" class="">lersek@redhat.com</a>><br class=""><b class="">Subject:</b><span class="Apple-converted-space"> </span>Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode<o:p class=""></o:p></span></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Mike,<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">I understand that very well and thus the PCD rather than my original patch :)<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><o:p class=""> </o:p></span></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Best,<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Vitaly<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><br class=""><br class=""><o:p class=""></o:p></span></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><p class="MsoNormal" style="margin: 0in 0in 12pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span class="">On 15 Dec 2020, at 22:41, Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class="">michael.d.kinney@intel.com</a>> wrote:<o:p class=""></o:p></span></p></blockquote></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><span class="Apple-converted-space"> </span><o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Vitaly,</span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">I am concerned about platforms that use this driver with this change outside your use case.</span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Mike</span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div><div class=""><div style="border-style: solid none none; border-top-width: 1pt; border-top-color: rgb(225, 225, 225); padding: 3pt 0in 0in;" class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><b class=""><span class="">From:</span></b><span class=""><span class="Apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class="">devel@edk2.groups.io</a><span class="Apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class="">devel@edk2.groups.io</a>><span class="Apple-converted-space"> </span><b class="">On Behalf Of<span class="Apple-converted-space"> </span></b>Vitaly Cheptsov<br class=""><b class="">Sent:</b><span class="Apple-converted-space"> </span>Tuesday, December 15, 2020 11:40 AM<br class=""><b class="">To:</b><span class="Apple-converted-space"> </span>Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class="">michael.d.kinney@intel.com</a>><br class=""><b class="">Cc:</b><span class="Apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class="">devel@edk2.groups.io</a>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" style="color: purple; text-decoration: underline;" class="">hao.a.wu@intel.com</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com" style="color: purple; text-decoration: underline;" class="">ray.ni@intel.com</a>>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com" style="color: purple; text-decoration: underline;" class="">jian.j.wang@intel.com</a>>; Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com" style="color: purple; text-decoration: underline;" class="">mateusz.albecki@intel.com</a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com" style="color: purple; text-decoration: underline;" class="">lersek@redhat.com</a>><br class=""><b class="">Subject:</b><span class="Apple-converted-space"> </span>Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode</span><o:p class=""></o:p></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <o:p class=""></o:p></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">As long as we do not write to a RAID array it will not cause any issues, and we do not. So I do not see an issue here.</span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Vitaly</span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><br class=""><br class=""></span><o:p class=""></o:p></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><p class="MsoNormal" style="margin: 0in 0in 12pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span class="">On 15 Dec 2020, at 22:00, Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class="">michael.d.kinney@intel.com</a>> wrote:</span><o:p class=""></o:p></p></blockquote></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><span class="Apple-converted-space"> </span></span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">What about platforms that are in RAID mode and have configured a RAID set.<span class=""> <span class="Apple-converted-space"> </span></span>Your suggested change could potentially corrupt data on those different systems.</span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Mike</span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div><div style="border-style: none none none solid; border-left-width: 1.5pt; border-left-color: blue; padding: 0in 0in 0in 4pt;" class=""><div class=""><div style="border-style: solid none none; border-top-width: 1pt; border-top-color: rgb(225, 225, 225); padding: 3pt 0in 0in;" class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><b class=""><span class="">From:</span></b><span class=""><span class="Apple-converted-space"> </span>Vitaly Cheptsov <<a href="mailto:cheptsov@ispras.ru" style="color: purple; text-decoration: underline;" class="">cheptsov@ispras.ru</a>><span class="Apple-converted-space"> </span><br class=""><b class="">Sent:</b><span class="Apple-converted-space"> </span>Tuesday, December 15, 2020 10:56 AM<br class=""><b class="">To:</b><span class="Apple-converted-space"> </span>Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class="">michael.d.kinney@intel.com</a>><br class=""><b class="">Cc:</b><span class="Apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class="">devel@edk2.groups.io</a>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" style="color: purple; text-decoration: underline;" class="">hao.a.wu@intel.com</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com" style="color: purple; text-decoration: underline;" class="">ray.ni@intel.com</a>>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com" style="color: purple; text-decoration: underline;" class="">jian.j.wang@intel.com</a>>; Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com" style="color: purple; text-decoration: underline;" class="">mateusz.albecki@intel.com</a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com" style="color: purple; text-decoration: underline;" class="">lersek@redhat.com</a>><br class=""><b class="">Subject:</b><span class="Apple-converted-space"> </span>Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode</span><o:p class=""></o:p></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <o:p class=""></o:p></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Not correct, these systems do not have hard RAID support or anything alike. It is standard G45 from what I remember. I believe the vendor simply left the firmware supplier defaults or something alike as there is a way to use IDE mode but nothing for AHCI.</span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Vitaly</span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><br class=""><br class=""></span><o:p class=""></o:p></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><p class="MsoNormal" style="margin: 0in 0in 12pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span class="">On 15 Dec 2020, at 21:09, Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class="">michael.d.kinney@intel.com</a>> wrote:</span><o:p class=""></o:p></p></blockquote></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><span class="Apple-converted-space"> </span></span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">So those types of systems must have a RAID enabled FW driver.<span class=""> <span class="Apple-converted-space"> </span></span>Right?<span class=""> <span class="Apple-converted-space"> </span></span>So the drives could be configured as a RAID set and using the patch you suggest below could corrupt data.</span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">It is difficult to support a change that could corrupt data.</span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Mike</span><o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div><div style="border-style: none none none solid; border-left-width: 1.5pt; border-left-color: blue; padding: 0in 0in 0in 4pt;" class=""><div class=""><div style="border-style: solid none none; border-top-width: 1pt; border-top-color: rgb(225, 225, 225); padding: 3pt 0in 0in;" class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><b class=""><span class="">From:</span></b><span class=""><span class="Apple-converted-space"> </span>Vitaly Cheptsov <<a href="mailto:cheptsov@ispras.ru" style="color: purple; text-decoration: underline;" class="">cheptsov@ispras.ru</a>><span class="Apple-converted-space"> </span><br class=""><b class="">Sent:</b><span class="Apple-converted-space"> </span>Tuesday, December 15, 2020 9:44 AM<br class=""><b class="">To:</b><span class="Apple-converted-space"> </span>Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class="">michael.d.kinney@intel.com</a>><br class=""><b class="">Cc:</b><span class="Apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class="">devel@edk2.groups.io</a>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" style="color: purple; text-decoration: underline;" class="">hao.a.wu@intel.com</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com" style="color: purple; text-decoration: underline;" class="">ray.ni@intel.com</a>>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com" style="color: purple; text-decoration: underline;" class="">jian.j.wang@intel.com</a>>; Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com" style="color: purple; text-decoration: underline;" class="">mateusz.albecki@intel.com</a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com" style="color: purple; text-decoration: underline;" class="">lersek@redhat.com</a>><br class=""><b class="">Subject:</b><span class="Apple-converted-space"> </span>Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode</span><o:p class=""></o:p></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Unfortunately not. That is basically the issue. When there is a preference, it is possible to ask the user to set it. However, for certain Dell machines, we have an issue with, it is not possible to select AHCI mode in the firmware preferences, and these users end up with unconfigurable RAID.</span><o:p class=""></o:p></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Best regards,</span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Vitaly</span><o:p class=""></o:p></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><br class=""><br class=""></span><o:p class=""></o:p></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">15 дек. 2020 г., в 20:41, Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class="">michael.d.kinney@intel.com</a>> написал(а):</span><o:p class=""></o:p></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">But do the systems allow the user to configure the FW that runs earlier? <span class="apple-converted-space"> </span>Can you require to users to configure their platforms correctly?</span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Thanks,</span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Mike</span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div><div class=""><div style="border-style: solid none none; border-top-width: 1pt; border-top-color: rgb(225, 225, 225); padding: 3pt 0in 0in;" class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><b class=""><span class="">From:</span></b><span class="apple-converted-space"><span class=""> </span></span><span class=""><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a><span class="apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a>><span class="apple-converted-space"> </span><b class="">On Behalf Of<span class="apple-converted-space"> </span></b>Vitaly Cheptsov<br class=""><b class="">Sent:</b><span class="apple-converted-space"> </span>Tuesday, December 15, 2020 9:34 AM<br class=""><b class="">To:</b><span class="apple-converted-space"> </span>Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">michael.d.kinney@intel.com</span></a>><br class=""><b class="">Cc:</b><span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">hao.a.wu@intel.com</span></a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">ray.ni@intel.com</span></a>>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">jian.j.wang@intel.com</span></a>>; Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">mateusz.albecki@intel.com</span></a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">lersek@redhat.com</span></a>><br class=""><b class="">Subject:</b><span class="apple-converted-space"> </span>Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode</span><o:p class=""></o:p></div></div></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Hi Michael,</span><o:p class=""></o:p></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">I believe Intel SATA controllers have non-standard lockdown bits, which do not let you reconfigure them as soon as the initialisation is over. Since we start much later (outside of the firmware), we can no longer control this.</span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Best regards,</span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Vitaly</span><o:p class=""></o:p></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><br class=""><br class=""><br class=""></span><o:p class=""></o:p></div></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">15 дек. 2020 г., в 19:58, Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">michael.d.kinney@intel.com</span></a>> написал(а):</span><o:p class=""></o:p></div></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Hi Vitaly,</span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Can you please explain why the controller can not be configured in a non-RAID mode?</span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Thanks,</span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Mike</span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div><div class=""><div style="border-style: solid none none; border-top-width: 1pt; border-top-color: rgb(225, 225, 225); padding: 3pt 0in 0in;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><b class=""><span class="">From:</span></b><span class="apple-converted-space"><span class=""> </span></span><span class=""><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a><span class="apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a>><span class="apple-converted-space"> </span><b class="">On Behalf Of<span class="apple-converted-space"> </span></b>Vitaly Cheptsov<br class=""><b class="">Sent:</b><span class="apple-converted-space"> </span>Tuesday, December 15, 2020 12:58 AM<br class=""><b class="">To:</b><span class="apple-converted-space"> </span>Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">hao.a.wu@intel.com</span></a>>;<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a><br class=""><b class="">Cc:</b><span class="apple-converted-space"> </span>Ni, Ray <<a href="mailto:ray.ni@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">ray.ni@intel.com</span></a>>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">jian.j.wang@intel.com</span></a>>; Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">mateusz.albecki@intel.com</span></a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">lersek@redhat.com</span></a>>; Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">michael.d.kinney@intel.com</span></a>><br class=""><b class="">Subject:</b><span class="apple-converted-space"> </span>Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode</span><o:p class=""></o:p></div></div></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Hello,</span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">1. Could you help to change the BZ tracker <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3118" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">https://bugzilla.tianocore.org/show_bug.cgi?id=3118</span></a> to a "Tiano Feature Requests"?<br class="">For me, it looks more like a feature request.</span><o:p class=""></o:p></div></div></div></blockquote><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Sure, done.</span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">2. Could you help to include 'AtaAtapiPassThru' in the BZ tracker subject for better reference?</span><o:p class=""></o:p></div></div></div></blockquote><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Also done.</span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">3. For Patch 2/2, is there any reason to clear the bits:<br class="">EFI_ATA_PASS_THRU_ATTRIBUTES_PHYSICAL<br class="">EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL<br class="">If the drives are intended to be used as non-RAID devices, I think both the ATTRIBUTES_PHYSICAL & ATTRIBUTES_LOGICAL should be set for the controller according to the UEFI Spec.</span><o:p class=""></o:p></div></div></div></blockquote><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">I am not quite positive why this was needed (the patch was prepared a few months ago), but I will make a comment in V2 when we test it on real hardware. I think it was required to take the right path in the driver.</span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">DuetPkg was removed from edk2.<br class="">If the change is specially for DUET use case, I am afraid we cannot accept this change.</span><o:p class=""></o:p></div></div></div></blockquote><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">This is not the DuetPkg from EDK II, but ours[1]. Thus your claim does not apply.</span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">I agree it would be better to configure the platform so the SATA controller is in its non-RAID mode.</span><o:p class=""></o:p></div></div></div></blockquote><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Agree, but in this case it is not feasible.</span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">If the controller is in RAID mode, then the OS that is booted may have a SATA RAID driver<br class="">that can configure the drives in RAID mode. Then, if the UEFI FW treats it as non RAID, it<br class="">may not be bootable, and configuration actions in UEFI may corrupt data on the RAID configured<br class="">drives. For this reason, I am not in favor of adding a PCD.</span><o:p class=""></o:p></div></div></div></blockquote><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Actually some operating systems have to introduce workarounds for this as well, and no, in this particular case the OS does not treat the drive as RAID either.</span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">If there are no other review comments besides the attributes, I will proceed with V2 in the coming days.</span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Best regards,</span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Vitaly</span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">[1] <a href="https://github.com/acidanthera/OpenCorePkg" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">https://github.com/acidanthera/OpenCorePkg</span></a></span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><br class=""><br class=""><br class=""><br class=""></span><o:p class=""></o:p></div></div></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">15 дек. 2020 г., в 06:54, Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">michael.d.kinney@intel.com</span></a>> написал(а):</span><o:p class=""></o:p></div></div></div></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div><div class=""><div class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">I agree it would be better to configure the platform so the SATA controller is in its non-RAID mode.<br class=""><br class="">If the controller is in RAID mode, then the OS that is booted may have a SATA RAID driver<br class="">that can configure the drives in RAID mode. Then, if the UEFI FW treats it as non RAID, it<br class="">may not be bootable, and configuration actions in UEFI may corrupt data on the RAID configured<br class="">drives. For this reason, I am not in favor of adding a PCD.<br class=""><br class="">Mike<br class=""><br class=""><br class=""><br class=""><br class=""></span><o:p class=""></o:p></div></div></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">-----Original Message-----<br class="">From:<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a><span class="apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a>> On Behalf Of Wu, Hao A<br class="">Sent: Monday, December 14, 2020 5:53 PM<br class="">To: Ni, Ray <<a href="mailto:ray.ni@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">ray.ni@intel.com</span></a>>;<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a>;<span class="apple-converted-space"> </span><a href="mailto:cheptsov@ispras.ru" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">cheptsov@ispras.ru</span></a><br class="">Cc: Wang, Jian J <<a href="mailto:jian.j.wang@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">jian.j.wang@intel.com</span></a>>; Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">mateusz.albecki@intel.com</span></a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">lersek@redhat.com</span></a>><br class="">Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode<br class=""><br class=""><br class=""><br class=""><br class=""></span><o:p class=""></o:p></div></div></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">-----Original Message-----<br class="">From: Ni, Ray <<a href="mailto:ray.ni@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">ray.ni@intel.com</span></a>><br class="">Sent: Tuesday, December 15, 2020 9:45 AM<br class="">To:<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a>;<span class="apple-converted-space"> </span><a href="mailto:cheptsov@ispras.ru" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">cheptsov@ispras.ru</span></a><br class="">Cc: Wang, Jian J <<a href="mailto:jian.j.wang@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">jian.j.wang@intel.com</span></a>>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">hao.a.wu@intel.com</span></a>>;<br class="">Albecki, Mateusz <<a href="mailto:mateusz.albecki@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">mateusz.albecki@intel.com</span></a>>; Laszlo Ersek<br class=""><<a href="mailto:lersek@redhat.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">lersek@redhat.com</span></a>><br class="">Subject: RE: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe:<br class="">Add support for drives in RAID mode<br class=""><br class="">DuetPkg was removed from edk2.<br class="">If the change is specially for DUET use case, I am afraid we cannot accept this<br class="">change.<br class=""><br class="">Hao,<br class="">Can this change benefit a general use case?</span><o:p class=""></o:p></div></div></div></blockquote><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><br class=""><br class="">Hello Ray,<br class=""><br class="">My understanding to the proposed PCD is that drives behind a RAID mode SATA controller can be configured to working in<br class="">non-RAID mode (acting like individual drives).<br class=""><br class="">As for the DuetPkg, below is a previous comment from Vitaly:<br class="">"there is no firmware preference for that (Hao: configure the controller to non-RAID mode). The firmware does not support<br class="">UEFI, and we are running through DuetPkg."<br class=""><br class="">Best Regards,<br class="">Hao Wu<br class=""><br class=""><br class=""><br class=""><br class=""><br class=""></span><o:p class=""></o:p></div></div></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""><br class="">Thanks,<br class="">Ray<br class=""><br class=""><br class=""><br class=""><br class=""></span><o:p class=""></o:p></div></div></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">-----Original Message-----<br class="">From:<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a><span class="apple-converted-space"> </span><<a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a>> On Behalf Of Vitaly<br class="">Cheptsov<br class="">Sent: Friday, December 11, 2020 5:25 PM<br class="">To:<span class="apple-converted-space"> </span><a href="mailto:devel@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel@edk2.groups.io</span></a><br class="">Cc: Vitaly Cheptsov <<a href="mailto:cheptsov@ispras.ru" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">cheptsov@ispras.ru</span></a>>; Wang, Jian J<br class=""><<a href="mailto:jian.j.wang@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">jian.j.wang@intel.com</span></a>>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">hao.a.wu@intel.com</span></a>>; Albecki,<br class="">Mateusz <<a href="mailto:mateusz.albecki@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">mateusz.albecki@intel.com</span></a>>; Laszlo Ersek <<a href="mailto:lersek@redhat.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">lersek@redhat.com</span></a>><br class="">Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe:</span><o:p class=""></o:p></div></div></div></blockquote><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="">Add<br class=""><br class=""><br class=""><br class=""></span><o:p class=""></o:p></div></div></div><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class=""><p class="MsoNormal" style="margin: 0in 0in 12pt; font-size: 11pt; font-family: Calibri, sans-serif;">support for drives in RAID mode<br class=""><br class="">REF:<span class="apple-converted-space"> </span><a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3118" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">https://bugzilla.tianocore.org/show_bug.cgi?id=3118</span></a><br class=""><br class="">This resolves the problem of using drivers connected to Intel G33<br class="">builtin SATA controller when run from DuetPkg when it can only be<br class="">configured in RAID mode through the firmware settings.<br class=""><br class="">Cc: Jian J Wang <<a href="mailto:jian.j.wang@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">jian.j.wang@intel.com</span></a>><br class="">Cc: Hao A Wu <<a href="mailto:hao.a.wu@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">hao.a.wu@intel.com</span></a>><br class="">Cc: Mateusz Albecki <<a href="mailto:mateusz.albecki@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">mateusz.albecki@intel.com</span></a>><br class="">Cc: Laszlo Ersek <<a href="mailto:lersek@redhat.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">lersek@redhat.com</span></a>><br class="">Signed-off-by: Vitaly Cheptsov <<a href="mailto:cheptsov@ispras.ru" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">cheptsov@ispras.ru</span></a>><br class="">---<br class="">MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c | 4 ++--<br class="">1 file changed, 2 insertions(+), 2 deletions(-)<br class=""><br class="">diff --git a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c<br class="">b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c<br class="">index ab06e2833c..301335c967 100644<br class="">--- a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c<br class="">+++ b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c<br class="">@@ -324,7 +324,7 @@ SataControllerSupported (<br class=""> return EFI_UNSUPPORTED;<br class=""> }<br class=""><br class="">- if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData)) {<br class="">+ if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData) ||<br class="">+ IS_PCI_RAID (&PciData)) {<br class=""> return EFI_SUCCESS;<br class=""> }<br class=""><br class="">@@ -465,7 +465,7 @@ SataControllerStart (<br class=""> if (IS_PCI_IDE (&PciData)) {<br class=""> Private->IdeInit.ChannelCount = IDE_MAX_CHANNEL;<br class=""> Private->DeviceCount = IDE_MAX_DEVICES;<br class="">- } else if (IS_PCI_SATADPA (&PciData)) {<br class="">+ } else if (IS_PCI_SATADPA (&PciData) || IS_PCI_RAID (&PciData)) {<br class=""> //<br class=""> // Read Ports Implemented(PI) to calculate max port number (0 based).<br class=""> //<br class="">--<br class="">2.24.3 (Apple Git-128)<br class=""><br class=""><br class=""><br class="">-=-=-=-=-=-=<br class=""><a href="http://groups.io/" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">Groups.io</span></a><span class="apple-converted-space"> </span>Links: You receive all messages sent to this group.<br class="">View/Reply Online (#68707):<br class=""><a href="https://edk2.groups.io/g/devel/message/68707" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">https://edk2.groups.io/g/devel/message/68707</span></a><br class="">Mute This Topic:<span class="apple-converted-space"> </span><a href="https://groups.io/mt/78875596/1712937" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">https://groups.io/mt/78875596/1712937</span></a><br class="">Group Owner:<span class="apple-converted-space"> </span><a href="mailto:devel+owner@edk2.groups.io" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">devel+owner@edk2.groups.io</span></a><br class="">Unsubscribe:<span class="apple-converted-space"> </span><a href="https://edk2.groups.io/g/devel/unsub" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">https://edk2.groups.io/g/devel/unsub</span></a><span class="apple-converted-space"> </span>[<a href="mailto:ray.ni@intel.com" style="color: purple; text-decoration: underline;" class=""><span style="color: purple;" class="">ray.ni@intel.com</span></a>]<br class="">-=-=-=-=-=-=<o:p class=""></o:p></p></blockquote></blockquote><p class="MsoNormal" style="margin: 0in 0in 12pt; font-size: 11pt; font-family: Calibri, sans-serif;"><br class=""><br class=""><br class=""><br class=""><br class=""><br class=""><o:p class=""></o:p></p></blockquote><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div></div></blockquote></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div></div></blockquote></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div></blockquote></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class=""> </span><o:p class=""></o:p></div></div></div></div></blockquote></div></div></blockquote></div></blockquote><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""></o:p></span></div></div></div></div></blockquote></div><br class=""></div></body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/68947">View/Reply Online (#68947)</a> | | <a target="_blank" href="https://groups.io/mt/78875596/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>