<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=gb2312"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> Thanks, Bob! <o:p> </o:p> - Bret <o:p></o:p> <o:p> </o:p> <div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:bob.c.feng@intel.com">Feng, Bob C</a> Sent: Tuesday, December 22, 2020 5:35 PM To: <a href="mailto:hi@senzilla.io">D. Olsson</a>; <a href="mailto:devel@edk2.groups.io"> devel@edk2.groups.io</a>; <a href="mailto:Bret.Barkelew@microsoft.com">Bret Barkelew</a>; <a href="mailto:gaoliming@byosoft.com.cn">gaoliming</a>; <a href="mailto:fengyunhua@byosoft.com.cn"> 'Yunhua Feng'</a> Subject: [EXTERNAL] RE: [edk2-devel] [edk2/master PATCH 1/1] GenFds: Compatibility with Python 3.9 </div> <o:p> </o:p> Add a new BZ for recording the python3.9 related patches.<o:p></o:p> <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3136&data=04%7C01%7Cbret.barkelew%40microsoft.com%7C8a90baffee5548fa016608d8a6e318a7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637442841595129557%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=G37mPlomk6wDKGmmsUfjV%2BGNnFr%2FTXfg0XnrhORxf6I%3D&reserved=0">https://bugzilla.tianocore.org/show_bug.cgi?id=3136</a><o:p></o:p> <o:p> </o:p> And I’ll update this patch <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F67511&data=04%7C01%7Cbret.barkelew%40microsoft.com%7C8a90baffee5548fa016608d8a6e318a7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637442841595139510%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=TN1spRuLYK8gTZo%2Fml2co%2BZVpIxDtRiW78us2mff1q0%3D&reserved=0"> https://edk2.groups.io/g/devel/message/67511</a> commit message to add this BZ when I push it.<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Bob<o:p></o:p> <o:p> </o:p> From: D. Olsson <hi@senzilla.io> Sent: Wednesday, December 23, 2020 6:32 AM To: devel@edk2.groups.io; bret.barkelew@microsoft.com; Feng, Bob C <bob.c.feng@intel.com>; gaoliming <gaoliming@byosoft.com.cn>; 'Yunhua Feng' <fengyunhua@byosoft.com.cn> Subject: Re: [edk2-devel] [edk2/master PATCH 1/1] GenFds: Compatibility with Python 3.9<o:p></o:p> <o:p> </o:p> <div> I have not created any additional entries on Bugzilla or GitHub for this specific patch. But I have seen plenty of related patches in the mailing list.<o:p></o:p> </div> <div> <o:p> </o:p> </div> <div id="protonmail_signature_block"> <div> <div> D. Olsson<o:p></o:p> </div> <div> PGP: 8204A8CD<o:p></o:p> </div> </div> </div> <div> <o:p> </o:p> </div> <div> <o:p> </o:p> </div> On Tue, Dec 22, 2020 at 22:59, Bret Barkelew via groups.io <<a href="mailto:bret.barkelew=microsoft.com@groups.io">bret.barkelew=microsoft.com@groups.io</a>> wrote:<o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> Do any of these reports have active Bugzilla or GitHub issues associated with them?<o:p></o:p> <o:p></o:p> Trying to track patch completion in Mu, since we’ve already implemented the “frombytes” solution.<o:p></o:p> <o:p></o:p> - Bret <o:p></o:p> <o:p></o:p> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:bob.c.feng=intel.com@groups.io">Bob Feng via groups.io</a> Sent: Monday, December 21, 2020 5:58 PM To: <a href="mailto:gaoliming@byosoft.com.cn">gaoliming</a>; <a href="mailto:devel@edk2.groups.io"> devel@edk2.groups.io</a>; <a href="mailto:hi@senzilla.io">hi@senzilla.io</a>; <a href="mailto:fengyunhua@byosoft.com.cn"> 'Yunhua Feng'</a> Subject: [EXTERNAL] Re: [edk2-devel] [edk2/master PATCH 1/1] GenFds: Compatibility with Python 3.9<o:p></o:p> </div> <o:p></o:p> This patch won't work for python2 Let's review this patch. <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F67511&data=04%7C01%7Cbret.barkelew%40microsoft.com%7C8a90baffee5548fa016608d8a6e318a7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637442841595139510%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=TN1spRuLYK8gTZo%2Fml2co%2BZVpIxDtRiW78us2mff1q0%3D&reserved=0">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F67511&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C6fa4f0d34ca34df5a21a08d8a61d1c0f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637441991250372790%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=q0kpLCthainyd0V8u%2FgJoCkx1SD4N0SLITWXBqAmLAk%3D&reserved=0</a> Thanks, Bob -----Original Message----- From: gaoliming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>> Sent: Tuesday, December 22, 2020 8:47 AM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a href="mailto:hi@senzilla.io"> hi@senzilla.io</a>; 'Yunhua Feng' <<a href="mailto:fengyunhua@byosoft.com.cn">fengyunhua@byosoft.com.cn</a>>; Feng, Bob C <<a href="mailto:bob.c.feng@intel.com">bob.c.feng@intel.com</a>> Cc: 'Liming Gao' <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>> Subject: 回复: [edk2-devel] [edk2/master PATCH 1/1] GenFds: Compatibility with Python 3.9 Yunhua and Bob: Can you review this patch this week? More and more people reports Python39 fail in BaseTools. Thanks Liming > -----邮件原件----- > 发件人: <a href="mailto:bounce+27952+69235+4905953+8761045@groups.io">bounce+27952+69235+4905953+8761045@groups.io</a> > <<a href="mailto:bounce+27952+69235+4905953+8761045@groups.io">bounce+27952+69235+4905953+8761045@groups.io</a>> 代表 D. Olsson via > groups.io > 发送时间: 2020年12月19日 4:15 > 收件人: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> > 抄送: Dick Olsson <<a href="mailto:hi@senzilla.io">hi@senzilla.io</a>> > 主题: [edk2-devel] [edk2/master PATCH 1/1] GenFds: Compatibility with > Python 3.9 > > Python 3.9 removed the tostring() and fromstring() methods: > <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.python.org%2F3%2Fwhatsnew%2F3.9.html%23removed&data=04%7C01%7Cbret.barkelew%40microsoft.com%7C8a90baffee5548fa016608d8a6e318a7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637442841595149474%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=DJrm5NYCLT6sFDikpdQXemdQ16cNNtO3Seyq1xVVKLE%3D&reserved=0"> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.python.org%2F3%2Fwhatsnew%2F3.9.html%23removed&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C6fa4f0d34ca34df5a21a08d8a61d1c0f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637441991250372790%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Zjbwllc0trGUL%2FSgSnB4Ivmkzu2B1l5AEgbWKf4L77g%3D&reserved=0</a> > > Signed-off-by: Dick Olsson <<a href="mailto:hi@senzilla.io">hi@senzilla.io</a>> > --- > BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py > b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py > index dc1727c466..124dc43199 100644 > --- a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py > +++ b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py > @@ -463,12 +463,12 @@ class GenFdsGlobalVariable: > GenFdsGlobalVariable.SecCmdList.append(' > '.join(Cmd).strip()) > else: > SectionData = array('B', [0, 0, 0, 0]) > - SectionData.fromstring(Ui.encode("utf_16_le")) > + SectionData.frombytes(Ui.encode("utf_16_le")) > SectionData.append(0) > SectionData.append(0) > Len = len(SectionData) > > GenFdsGlobalVariable.SectionHeader.pack_into(SectionData, 0, Len & > 0xff, (Len >> 8) & 0xff, (Len >> 16) & 0xff, 0x15) > - SaveFileOnChange(Output, SectionData.tostring()) > + SaveFileOnChange(Output, SectionData.tobytes()) > > elif Ver: > Cmd += ("-n", Ver) > -- > 2.25.1 > > > > > > <o:p></o:p> <o:p></o:p> </div> <div> </o:p> </div> </blockquote> <div> <o:p> </o:p> </div> <o:p> </o:p> <o:p> </o:p> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/69392">View/Reply Online (#69392)</a> | | <a target="_blank" href="https://groups.io/mt/79140937/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>