<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> Jiewen, <o:p> </o:p> Good point. Will update this in v2 patches. <o:p> </o:p> Thanks, Kun <o:p> </o:p> <div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:jiewen.yao@intel.com">Yao, Jiewen</a> Sent: Sunday, December 27, 2020 16:14 To: <a href="mailto:kun.q@outlook.com">Kun Qin</a>; <a href="mailto:devel@edk2.groups.io"> devel@edk2.groups.io</a> Cc: <a href="mailto:ard.biesheuvel@arm.com">Ard Biesheuvel</a>; <a href="mailto:sami.mujawar@arm.com"> Sami Mujawar</a>; <a href="mailto:supreeth.venkatesh@arm.com">Supreeth Venkatesh</a> Subject: RE: [PATCH v1 03/15] StandaloneMmPkg: StandaloneMmCoreMemoryAllocationLib: Fix compiler warning </div> <o:p> </o:p> Since below code is using (UINTN)MmramRangeCount, MmInitializeMemoryServices ((UINTN)MmramRangeCount, (VOID *)(UINTN)MmramRanges); I recommend to UINTN for MmramRangeCount, and use (UINTN) cast. > -----Original Message----- > From: Kun Qin <kun.q@outlook.com> > Sent: Saturday, December 19, 2020 2:50 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; Sami Mujawar > <sami.mujawar@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>; Supreeth > Venkatesh <supreeth.venkatesh@arm.com> > Subject: [PATCH v1 03/15] StandaloneMmPkg: > StandaloneMmCoreMemoryAllocationLib: Fix compiler warning > > Assigning MmramRangeCount from MmCorePrivate (UINT64) to local > variable > MmramRangeCount (UINT32) will cause compilation failure due to "warning > C4244: '=': conversion from 'UINT64' to 'UINT32', possible loss of data". > This changes defines local MmramRangeCount as UINT64 type. > > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com> > Cc: Sami Mujawar <sami.mujawar@arm.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com> > > Signed-off-by: Kun Qin <kun.q@outlook.com> > --- > > StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Stan > daloneMmCoreMemoryAllocationLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Sta > ndaloneMmCoreMemoryAllocationLib.c > b/StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Sta > ndaloneMmCoreMemoryAllocationLib.c > index eb3d772e18c5..798d546a2037 100644 > --- > a/StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Sta > ndaloneMmCoreMemoryAllocationLib.c > +++ > b/StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Sta > ndaloneMmCoreMemoryAllocationLib.c > @@ -841,7 +841,7 @@ MemoryAllocationLibConstructor ( > VOID *HobStart; > EFI_MMRAM_HOB_DESCRIPTOR_BLOCK *MmramRangesHobData; > EFI_MMRAM_DESCRIPTOR *MmramRanges; > - UINT32 MmramRangeCount; > + UINT64 MmramRangeCount; > EFI_HOB_GUID_TYPE *MmramRangesHob; > > HobStart = GetHobList (); > -- > 2.28.0.windows.1<o:p></o:p> <o:p> </o:p> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/69472">View/Reply Online (#69472)</a> | | <a target="_blank" href="https://groups.io/mt/79068286/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>