<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> A PR is created. <a href="https://github.com/tianocore/edk2/pull/1376">https://github.com/tianocore/edk2/pull/1376</a> <o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng Sent: Tuesday, January 19, 2021 9:58 PM To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; gaoliming@byosoft.com.cn Subject: Re: [edk2-devel] 回复: [edk2-devel] [Patch 0/2] Convert Split tool to python<o:p></o:p> </div> </div> <o:p> </o:p> A reminder that if the user has the windows bat script that calls Split in it，it needs to change to "call Split" because Split will be a bat script but not an executable file.<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Bob<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> On Behalf Of Bob Feng Sent: Tuesday, January 19, 2021 9:29 AM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a href="mailto:gaoliming@byosoft.com.cn"> gaoliming@byosoft.com.cn</a> Subject: Re: [edk2-devel] 回复: [edk2-devel] [Patch 0/2] Convert Split tool to python<o:p></o:p> </div> </div> <o:p> </o:p> That’s is good suggestion. <o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Bob<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> On Behalf Of gaoliming Sent: Tuesday, January 19, 2021 9:10 AM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; Feng, Bob C <<a href="mailto:bob.c.feng@intel.com">bob.c.feng@intel.com</a>> Subject: 回复: [edk2-devel] 回复: [edk2-devel] [Patch 0/2] Convert Split tool to python<o:p></o:p> </div> </div> <o:p> </o:p> Bob:<o:p></o:p> The code logic is fine. This is a big change. I suggest to update tool version from 1.0 to 2.0. With this change, Reviewed-by: Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>><o:p></o:p> <o:p> </o:p> Thanks<o:p></o:p> Liming<o:p></o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> 发件人: <a href="mailto:bounce+27952+70509+4905953+8761045@groups.io">bounce+27952+70509+4905953+8761045@groups.io</a> <<a href="mailto:bounce+27952+70509+4905953+8761045@groups.io">bounce+27952+70509+4905953+8761045@groups.io</a>> 代表 Bob Feng 发送时间: 2021年1月19日 7:57 收件人: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a> 主题: Re: [edk2-devel] 回复: [edk2-devel] [Patch 0/2] Convert Split tool to python<o:p></o:p> </div> </div> <o:p> </o:p> Liming,<o:p></o:p> <o:p> </o:p> I have sent the patch V3 that is to move the unit test to tests/Split folder.<o:p></o:p> <o:p> </o:p> Do you have any other concerns about this patch?<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Bob<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Feng, Bob C Sent: Friday, January 15, 2021 9:50 AM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a> Cc: Feng, Bob C <<a href="mailto:bob.c.feng@intel.com">bob.c.feng@intel.com</a>> Subject: RE: [edk2-devel] 回复: [edk2-devel] [Patch 0/2] Convert Split tool to python<o:p></o:p> </div> </div> <o:p> </o:p> Hi Liming,<o:p></o:p> <o:p> </o:p> 1. The test framework can be used for both incremental test and functionality test. We can do more discussion when I send out this framework for review.<o:p></o:p> 2. Yes, I agree to add a sub folder under the test folder. I’ll update the patch.<o:p></o:p> <o:p> </o:p> Is there any other comments before I send the patch V2?<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Bob<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> On Behalf Of gaoliming Sent: Friday, January 15, 2021 9:13 AM To: Feng, Bob C <<a href="mailto:bob.c.feng@intel.com">bob.c.feng@intel.com</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> Subject: 回复: [edk2-devel] 回复: [edk2-devel] [Patch 0/2] Convert Split tool to python<o:p></o:p> </div> </div> <o:p> </o:p> Bob:<o:p></o:p> Thanks for your planning sharing. For BaseTools test, I still have some questions. <o:p></o:p> <o:p> </o:p> <![if !supportLists]>1. <![endif]>For test framework, is it the incremental test framework or the functionality test framework or both? <o:p></o:p> <![if !supportLists]>2. <![endif]>For BaseTools\Source\Python\tests\test_split.py, it creates new directory ‘tests’ for test case scripts, and use test_split.py for split tool. So, new tool test script will follow the same style. Besides, split tool is simple. It may not have its special test case. But, Fce/FMMT are too complex. They need the different bios images as their test cases. Then, where are those test cases placed into? I would prefer to place the test script and its test cases into the same directory. So, I would propose to create the subdirectory in ‘tests’ for each tool test, such as Split for this case. Then, every tool can place its test script and test case into its own directory. <o:p></o:p> <o:p> </o:p> Thanks<o:p></o:p> Liming<o:p></o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> 发件人: <a href="mailto:tosubbounce+27952+0+0+0@groups.io">tosubbounce+27952+0+0+0@groups.io</a> <<a href="mailto:tosubbounce+27952+0+0+0@groups.io">tosubbounce+27952+0+0+0@groups.io</a>> 代表 Bob Feng 发送时间: 2021年1月14日 10:46 收件人: gaoliming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> 主题: Re: [edk2-devel] 回复: [edk2-devel] [Patch 0/2] Convert Split tool to python<o:p></o:p> </div> </div> <o:p> </o:p> Good questions. I answer them inline. Thanks, Bob On Thu, Jan 14, 2021 at 08:53 AM, gaoliming wrote:<o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Bob: Have you plan to convert all C tools to Python tools? Or only some ones?<o:p></o:p> </blockquote> I am still investigating the feasibility of converting the C tools to Python tools. Some C tools are simple but some are complex. I hope all the C tools can be converted to Python tools so that all the tools can be moved to the BaseTools separate repo. I think we can file some BZs to track the progress of the C tools conversion. And I hope there could be more volunteers to be involved in this work. Here are the discussions about the benefit and process of moving BaseTools out of the edk2 repo for reference.<o:p></o:p> <div> <a href="https://edk2.groups.io/g/devel/topic/76572200#64993" target="_blank">https://edk2.groups.io/g/devel/topic/76572200#64993</a> <o:p></o:p> </div> <div> <a href="https://edk2.groups.io/g/rfc/topic/74009714#270" target="_blank">https://edk2.groups.io/g/rfc/topic/74009714#270</a> <o:p></o:p> </div> <div> <a href="https://edk2.groups.io/g/devel/topic/73069134#58048" target="_blank">https://edk2.groups.io/g/devel/topic/73069134#58048</a><o:p></o:p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Can you share your planning for the changes in BaseTools?<o:p></o:p> </blockquote> Except for this patch, my current work for Basetools are: 1. Re-write the FMMT/FCE with Python and propose to add these 2 tools to the edk2 BaseTools. 2. Prepare to publish the Basetools incremental build regression test cases and test framework.<o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> And, I see you also add unittest for new split tool. Can you introduce the unittest framework for python tool? If so, new added tool can follow the same way to add unittest.<o:p></o:p> </blockquote> The unittest is the python build-in library for the unit test. <a href="https://docs.python.org/3/library/unittest.html" target="_blank">https://docs.python.org/3/library/unittest.html</a> I provide the unit test is to help you to review this patch. From the unit test case, it will be easy to see if this tool's behavior is as expected. I think for the python code development, we can try our best to follow this document. <a href="https://edk2-docs.gitbook.io/edk-ii-python-development-process-specification/" target="_blank">https://edk2-docs.gitbook.io/edk-ii-python-development-process-specification/</a> <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Thanks Liming<o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> -----邮件原件----- 发件人: <a href="mailto:bounce+27952+70232+4905953+8761045@groups.io"> bounce+27952+70232+4905953+8761045@groups.io</a> <<a href="mailto:bounce+27952+70232+4905953+8761045@groups.io">bounce+27952+70232+4905953+8761045@groups.io</a>> 代表 Bob Feng 发送时间: 2021年1月13日 17:56 收件人: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> 主题: [edk2-devel] [Patch 0/2] Convert Split tool to python There are 2 reasons to convert Split tool from C to Python. 1. We are in the process of moving the Basetools Python code to a separate repository. But there still are many C tools under edk2/BaseTools. To make all Basetools be in the separate repo, we can convert the C tools to Python tools. 2. The original Split tool is very slow. This python tool can reduce 90% time Bob Feng (2): BaseTools: Convert Split tool to python BaseTools: Add unittest for Split tool BaseTools/Source/C/Split/Split.c | 466 -------------------- BaseTools/BinWrappers/PosixLike/Split | 31 +- BaseTools/BinWrappers/WindowsLike/Split.bat | 3 + BaseTools/Source/C/GNUmakefile | 1 - BaseTools/Source/C/Makefile | 1 - BaseTools/Source/C/Split/GNUmakefile | 17 - BaseTools/Source/C/Split/Makefile | 16 - BaseTools/Source/Python/Split/Split.py | 203 +++++++++ BaseTools/Source/Python/Split/__init__.py | 10 + BaseTools/Source/Python/tests/test_split.py | 101 +++++ 10 files changed, 325 insertions(+), 524 deletions(-) delete mode 100644 BaseTools/Source/C/Split/Split.c create mode 100644 BaseTools/BinWrappers/WindowsLike/Split.bat delete mode 100644 BaseTools/Source/C/Split/GNUmakefile delete mode 100644 BaseTools/Source/C/Split/Makefile create mode 100644 BaseTools/Source/Python/Split/Split.py create mode 100644 BaseTools/Source/Python/Split/__init__.py create mode 100644 BaseTools/Source/Python/tests/test_split.py -- 2.29.1.windows.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70232): <a href="https://edk2.groups.io/g/devel/message/70232" target="_blank"> https://edk2.groups.io/g/devel/message/70232</a> Mute This Topic: <a href="https://groups.io/mt/79647273/4905953" target="_blank"> https://groups.io/mt/79647273/4905953</a> Group Owner: <a href="mailto:devel+owner@edk2.groups.io">devel+owner@edk2.groups.io</a> Unsubscribe: <a href="https://edk2.groups.io/g/devel/unsub" target="_blank">https://edk2.groups.io/g/devel/unsub</a> [gaoliming@byosoft.com.cn] -=-=-=-=-=-=<o:p></o:p> </blockquote> </blockquote> </div> <div> </o:p> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/70612">View/Reply Online (#70612)</a> | | <a target="_blank" href="https://groups.io/mt/79999334/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>