<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style></style></head><body lang=ZH-CN link=blue vlink=purple style='word-wrap:break-word'><div class=WordSection1>I suggest to send patch v2. <o:p></o:p><o:p> </o:p>Thanks<o:p></o:p>Liming<o:p></o:p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'>发件人: bounce+27952+71849+4905953+8761045@groups.io <bounce+27952+71849+4905953+8761045@groups.io> 代表 Bret Barkelew 发送时间: 2021年2月20日 1:10 收件人: Laszlo Ersek <lersek@redhat.com> 抄送: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io 主题: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM dependency<o:p></o:p></div></div><o:p> </o:p><div>Good note. Is there an easy way to resubmit? Just edit the patch as is, or does there need to be a v2?<o:p></o:p></div><o:p> </o:p><div><div>On Fri, Feb 19, 2021 at 6:30 AM Laszlo Ersek <<a href="mailto:lersek@redhat.com">lersek@redhat.com</a>> wrote:<o:p></o:p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'>On 02/18/21 05:07, Bret Barkelew wrote: > I'm not opposed to moving to 2.15.03 for consistency, but we'll have to > publish a new package. This one is already pushed to Nuget. Thanks for the answers. From Liming's answer, I understand we don't try to keep CI strictly in sync with edk2's (internal) BaseTools. So the patch should be fine; however, I think the subject line could be clarified. "BaseTools: Update the NASM dependency" doesn't make it clear that the CI builds are targeted primarily. Thanks Laszlo > > On Wed, Feb 17, 2021 at 7:39 PM gaoliming <<a href="mailto:gaoliming@byosoft.com.cn" target="_blank">gaoliming@byosoft.com.cn</a>> wrote: > >> Laszlo: >> >>> -----邮件原件----- >>> 发件人: <a href="mailto:bounce%2B27952%2B71686%2B4905953%2B8761045@groups.io" target="_blank">bounce+27952+71686+4905953+8761045@groups.io</a> >>> <<a href="mailto:bounce%2B27952%2B71686%2B4905953%2B8761045@groups.io" target="_blank">bounce+27952+71686+4905953+8761045@groups.io</a>> 代表 Laszlo Ersek >>> 发送时间: 2021年2月16日 5:00 >>> 收件人: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>; <a href="mailto:bret@corthon.com" target="_blank">bret@corthon.com</a> >>> 主题: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM >>> dependency >>> >>> Hi Bret, >>> >>> On 02/12/21 21:49, Bret Barkelew wrote: >>>> This is primarily used by CI builds, but may also be used by platforms. >>>> >>>> Update NASM to support newer structures and features, as agreed in >> recent >>>> community meetings: >>>> <a href="https://edk2.groups.io/g/devel/message/71289" target="_blank">https://edk2.groups.io/g/devel/message/71289</a> >>>> --- >>>> BaseTools/Bin/nasm_ext_dep.yaml | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml >>> b/BaseTools/Bin/nasm_ext_dep.yaml >>>> index 60b1f71b56aa..56703d4c18e7 100644 >>>> --- a/BaseTools/Bin/nasm_ext_dep.yaml >>>> +++ b/BaseTools/Bin/nasm_ext_dep.yaml >>>> @@ -13,6 +13,6 @@ >>>> "type": "nuget", >>>> "name": "mu_nasm", >>>> "source": "<a href="https://api.nuget.org/v3/index.json" target="_blank">https://api.nuget.org/v3/index.json</a>", >>>> - "version": "2.14.02", >>>> + "version": "2.15.5", >>>> "flags": ["set_path", "host_specific"] >>>> } >>>> >>> >>> (1) I'm confused by the "patchlevel" number being "5" and not "05", in >>> the "2.15.5" version. Per >>> <<a href="https://edk2.groups.io/g/devel/message/71045" target="_blank">https://edk2.groups.io/g/devel/message/71045</a>>, my understanding has >>> been that the latest release is "2.15.05". >>> >>> (2) The minimum required version, according to >>> <<a href="https://edk2.groups.io/g/devel/message/71070" target="_blank">https://edk2.groups.io/g/devel/message/71070</a>>, is "2.15.01". In the >>> RHEL build environments that matter to me, I can satisfy a NASM >>> dependency up to 2.15.03, at this time, but not beyond. And this matters >>> because... >>> >> I understand CI environment tries to use the latest tool version for >> verification. >> >>> (3) ... arguably, the NASM requirement in >>> "BaseTools/Conf/tools_def.template" should be updated too, in the same >>> patch: >>> >>> # - NASM 2.10 or later for use with the GCC toolchain family >>> # - NASM 2.12.01 or later for use with all other toolchain families >>> >> This is edk2 build environment requirement. It will be updated when the >> source code change is added. >> >> Thanks >> Liming >>> Thanks >>> Laszlo >>> >>> >>> >>> >>> >> >> >> >> > <o:p></o:p></blockquote></div><div></o:p></div></div></div></body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/71867">View/Reply Online (#71867)</a> | | <a target="_blank" href="https://groups.io/mt/80773839/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>