<div dir="ltr"><div>hi Sami,</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 22 Feb 2021 at 19:40, Ard Biesheuvel <<a href="mailto:ardb@kernel.org">ardb@kernel.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu <<a href="mailto:sughosh.ganu@linaro.org" target="_blank">sughosh.ganu@linaro.org</a>> wrote:<br>
><br>
> The following patch series adds support for using the Firmware<br>
> Framework(FF-A) as a transport mechanism for requesting services from<br>
> the Secure Partition Manager(SPM). This is done through a Pcd which<br>
> can be used to enable the FF-A mechanism or to use the earlier used<br>
> SVC calls.<br>
><br>
> The patches have been pushed to my github repository[1]<br>
><br>
> Ran the CI tests through the github draft pull request, and all the CI<br>
> test pass. Ran the PatchCheck script, with no errors.<br>
><br>
> Changes since V4:<br>
> * Define all variable Pcd's under the [Pcd] section instead of<br>
> [FixedPcd], as suggested by Liming Gao<br>
><br>
> Changes since V3:<br>
> * Put the PcdFfaEnable under the PcdsFeatureFlag.AARCH64 section to<br>
> avoid build breakage for the X64 StandaloneMm builds.<br>
> * Put the macro definitions for the SPM major and minor versions in a<br>
> separate patch, as suggested by Sami.<br>
> * Separated out the declaration of the SPM major and minor version<br>
> macros in the earlier patch as was suggested by Sami.<br>
> * Put the macro definitions for the SPM major and minor versions with<br>
> FF-A support in a separate patch, as suggested by Sami.<br>
> * Declare the PcdFfaEnable Pcd Feature flag under FeaturePcd.AARCH64<br>
> to avoid build break for the X64 build of StandaloneMm.<br>
> * Change the patch header to have the ArmPkg prefix instead of<br>
> StandaloneMmMmuLib as suggested by Sami.<br>
><br>
> Changes since V2:<br>
> * Added a STATIC storage class specifier for mSpmMajorVer and<br>
> mSpmMinorVer variables<br>
> * Added a STATIC storage class specifier for mSpmMajorVerFfa and<br>
> mSpmMinorVerFfa variables<br>
> * Add braces for if/else statements<br>
> * Add a check for EFI_NOT_FOUND as a possible return value from<br>
> LocateStandaloneMmCorePeCoffData in _ModuleEntryPoint function<br>
> * Check for the return value in Arg0 after the Direct Request call to<br>
> handle errors returned<br>
> * Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS<br>
> response won't be expected in return to a Direct Request call to get<br>
> the memory attributes<br>
> * Check for the return value in Arg0 after the Direct Request call to<br>
> handle errors returned<br>
> * Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS<br>
> response won't be expected in return to a Direct Request call to set<br>
> the memory attributes<br>
><br>
> Changes since V1:<br>
> Handled review comments from Sami Mujawar<br>
><br>
> [1] - <a href="https://github.com/sughoshg/edk2/tree/implement_ffa_svc_optional_v5" rel="noreferrer" target="_blank">https://github.com/sughoshg/edk2/tree/implement_ffa_svc_optional_v5</a><br>
><br>
><br>
> Achin Gupta (7):<br>
> ArmPkg/IndustryStandard: Add barebones FF-A header<br>
> ArmPkg/ArmSvcLib: Return x4-x7 in output parameters<br>
> StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry<br>
> point<br>
> StandaloneMmPkg: Add option to use FF-A calls for communication with<br>
> SPM<br>
> ArmPkg: Use FF-A header file in Standalone MM Arm MMU library<br>
> ArmPkg: Allow FF-A calls to get memory region's attributes<br>
> ArmPkg: Allow FF-A calls to set memory region's attributes<br>
><br>
> Ilias Apalodimas (2):<br>
> MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase<br>
> to Pcd<br>
> StandaloneMmPkg: Allow sending FFA Direct Request message to<br>
> StandaloneMm<br>
><br>
> Sughosh Ganu (5):<br>
> ArmPkg: Introduce support for PcdFfaEnable<br>
> ArmPkg: Add macros for SPM version<br>
> StandaloneMmPkg: Use macros for SPM version check<br>
> ArmPkg: Add macros for SPM version with FF-A support enabled<br>
> StandaloneMmPkg: Add option to use FF-A calls for getting SPM version<br>
><br>
<br>
Unfortunately, I won't be able to do a detailed review of this series,<br>
but I have discussed these patches before with Sami off-list, and<br>
based on that and on my earlier review of v3:<br>
<br>
Acked-by: Ard Biesheuvel <<a href="mailto:ardb@kernel.org" target="_blank">ardb@kernel.org</a>><br>
<br>
for the series, where necessary.<br></blockquote><div><br></div><div>Can you please merge this patch series for the stable tag edk2-stable202102. I have created a bugzilla ticket for this feature addition[1]. Please let me know if anything else is needed. Thanks.</div><div><br></div><div>-sughosh</div><div><br></div><div>[1] - <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3230">https://bugzilla.tianocore.org/show_bug.cgi?id=3230</a></div></div></div>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/71981">View/Reply Online (#71981)</a> | | <a target="_blank" href="https://groups.io/mt/80750044/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>