<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> <p class="MsoNormal">Maurice,<o:p></o:p></p> <p class="MsoNormal">It’s doable <span style="font-family:"Segoe UI Emoji",sans-serif"> 😊</span><o:p></o:p></p> <p class="MsoNormal">I prefer to accept today’s below 4G limitation to maintain simple implementation.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Thanks,<o:p></o:p></p> <p class="MsoNormal">Ray<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Ma, Maurice <maurice.ma@intel.com> <br> <b>Sent:</b> Tuesday, February 23, 2021 3:26 PM<br> <b>To:</b> Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; fanjianfeng@byosoft.com.cn; Patrick Rudolph <patrick.rudolph@9elements.com>; Dong, Guo <guo.dong@intel.com>; Dong, Eric <eric.dong@intel.com><br> <b>Cc:</b> You, Benjamin <benjamin.you@intel.com><br> <b>Subject:</b> RE: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Could we decouple BSP and AP GDT in early waking up stage ? <o:p></o:p></p> <p class="MsoNormal">For example, AP uses temporary GDT (below 4GB) just for mode switching. Once AP is in the final stage, AP can reload GDT to match BSP. In this way, we don’t have assumption on the final GDT location.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Thanks<o:p></o:p></p> <p class="MsoNormal">Maurice<o:p></o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>> <br> <b>Sent:</b> Monday, February 22, 2021 21:22<br> <b>To:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a href="mailto:fanjianfeng@byosoft.com.cn"> fanjianfeng@byosoft.com.cn</a>; Ma, Maurice <<a href="mailto:maurice.ma@intel.com">maurice.ma@intel.com</a>>; Patrick Rudolph <<a href="mailto:patrick.rudolph@9elements.com">patrick.rudolph@9elements.com</a>>; Dong, Guo <<a href="mailto:guo.dong@intel.com">guo.dong@intel.com</a>>; Dong, Eric <<a href="mailto:eric.dong@intel.com">eric.dong@intel.com</a>><br> <b>Cc:</b> You, Benjamin <<a href="mailto:benjamin.you@intel.com">benjamin.you@intel.com</a>><br> <b>Subject:</b> RE: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">“<span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">But we could allocate room under 4G for GDT table directly in CpuDxe.<span lang="ZH-CN">”</span><o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">The GDT pre-allocated is re-used by AP. Why do you suggest CpuDxe allocate GDT?<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Thanks,<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Ray<o:p></o:p></span></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> <b>On Behalf Of </b>Jeff Fan<br> <b>Sent:</b> Tuesday, February 23, 2021 11:43 AM<br> <b>To:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>>; Ma, Maurice <<a href="mailto:maurice.ma@intel.com">maurice.ma@intel.com</a>>; Patrick Rudolph <<a href="mailto:patrick.rudolph@9elements.com">patrick.rudolph@9elements.com</a>>; Dong, Guo <<a href="mailto:guo.dong@intel.com">guo.dong@intel.com</a>>; Dong, Eric <<a href="mailto:eric.dong@intel.com">eric.dong@intel.com</a>><br> <b>Cc:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; You, Benjamin <<a href="mailto:benjamin.you@intel.com">benjamin.you@intel.com</a>><br> <b>Subject:</b> Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Ray,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Yes. You are right. Acutally, x64 IDT table cannot work correctly on protected mode. :-)<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">But for GDT location, I agree it should be located under 4G space to support AP mode changing. But we could allocate room under 4G for GDT table directly in CpuDxe.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Thanks,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Jeff<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"><o:p> </o:p></span></p> </div> <blockquote style="margin-left:6.0pt;margin-top:5.0pt;margin-bottom:5.0pt;margin-right:inherit"> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> <o:p></o:p></span></p> </div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> <div> <div> <p class="MsoNormal" style="background:#EFEFEF"><b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">From:</span></b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black"> <a href="mailto:ray.ni@intel.com">Ni, Ray</a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="background:#EFEFEF"><b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">Date:</span></b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black"> 2021-02-23 10:52<o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="background:#EFEFEF"><b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">To:</span></b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black"> <a href="mailto:fanjianfeng@byosoft.com.cn">fanjianfeng@byosoft.com.cn</a>; <a href="mailto:devel@edk2.groups.io">devel</a>; <a href="mailto:maurice.ma@intel.com"> Ma, Maurice</a>; <a href="mailto:patrick.rudolph@9elements.com">Patrick Rudolph</a>; <a href="mailto:guo.dong@intel.com">Dong, Guo</a>; <a href="mailto:eric.dong@intel.com"> Dong, Eric</a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="background:#EFEFEF"><b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">CC:</span></b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black"> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a href="mailto:benjamin.you@intel.com">You, Benjamin</a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="background:#EFEFEF"><b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">Subject:</span></b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black"> Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA<o:p></o:p></span></p> </div> </div> </div> <div> <div> <p class="MsoNormal"><span style="color:black">Jeff,<o:p></o:p></span></p> <p class="MsoNormal"><span style="color:black">You are right that BSP’s GDT and IDT tables are under 4G memory.<o:p></o:p></span></p> <p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p> <p class="MsoNormal"><span style="color:black">It’s because when AP wakes up, it needs the GDT for entering protected mode. AP cannot access above 4G memory without entering to long mode.<o:p></o:p></span></p> <p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p> <p class="MsoNormal"><span style="color:black">I do agree that the 64bit IDT is not proper for AP when entering protected mode. As long as there is no exception in the short time frame (load 64bit IDT, before entering long mode), it’s still ok.<o:p></o:p></span></p> <p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p> <p class="MsoNormal"><span style="color:black">Thanks,<o:p></o:p></span></p> <p class="MsoNormal"><span style="color:black">Ray<o:p></o:p></span></p> <p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> <a href="mailto:fanjianfeng@byosoft.com.cn">fanjianfeng@byosoft.com.cn</a> <<a href="mailto:fanjianfeng@byosoft.com.cn">fanjianfeng@byosoft.com.cn</a>> <br> <b>Sent:</b> Tuesday, February 23, 2021 8:50 AM<br> <b>To:</b> devel <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>; Ma, Maurice <<a href="mailto:maurice.ma@intel.com">maurice.ma@intel.com</a>>; Patrick Rudolph <<a href="mailto:patrick.rudolph@9elements.com">patrick.rudolph@9elements.com</a>>; Dong, Guo <<a href="mailto:guo.dong@intel.com">guo.dong@intel.com</a>>; Dong, Eric <<a href="mailto:eric.dong@intel.com">eric.dong@intel.com</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>><br> <b>Cc:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; You, Benjamin <<a href="mailto:benjamin.you@intel.com">benjamin.you@intel.com</a>><br> <b>Subject:</b> Re: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">we will save the current BSP's GDT and IDT for APs at first time APs are waken by BSP as below. APs will start from real mode to protected mode and then to long mode. During protected mode, BSP's GDT/IDT table are working on APs.</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">In UefiCpuPkg\Library\MpInitLib\MpLib.c, </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> //</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> // Get the BSP's data of GDT and IDT</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> //</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> AsmReadGdtr ((IA32_DESCRIPTOR *) &ExchangeInfo->GdtrProfile);</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> AsmReadIdtr ((IA32_DESCRIPTOR *) &ExchangeInfo->IdtrProfile);</span><span style="color:black"><o:p></o:p></span></p> </div> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">It seems to be one bug we have assumption on GDT table and IDT table located under 4G memory space.</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Could Ray&Eric help me to confirm it?</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Jeff</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> </span><span style="color:black"><o:p></o:p></span></p> </div> <blockquote style="margin-left:6.0pt;margin-top:5.0pt;margin-bottom:5.0pt;margin-right:inherit"> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> <div> <div> <p class="MsoNormal" style="background:#EFEFEF"><b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">From:</span></b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black"> </span><span style="color:black"><a href="mailto:maurice.ma@intel.com"><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif">Ma, Maurice</span></a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="background:#EFEFEF"><b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">Date:</span></b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black"> 2021-02-23 00:49</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="background:#EFEFEF"><b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">To:</span></b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black"> </span><span style="color:black"><a href="mailto:patrick.rudolph@9elements.com"><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif">Patrick Rudolph</span></a></span><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">; </span><span style="color:black"><a href="mailto:guo.dong@intel.com"><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif">Dong, Guo</span></a></span><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">; </span><span style="color:black"><a href="mailto:eric.dong@intel.com"><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif">Dong, Eric</span></a></span><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">; </span><span style="color:black"><a href="mailto:ray.ni@intel.com"><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif">Ni, Ray</span></a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="background:#EFEFEF"><b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">CC:</span></b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black"> </span><span style="color:black"><a href="mailto:devel@edk2.groups.io"><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif">devel@edk2.groups.io</span></a></span><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">; </span><span style="color:black"><a href="mailto:benjamin.you@intel.com"><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif">You, Benjamin</span></a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="background:#EFEFEF"><b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black">Subject:</span></b><span style="font-size:9.0pt;font-family:"Tahoma",sans-serif;color:black"> Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA</span><span style="color:black"><o:p></o:p></span></p> </div> </div> </div> <div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Hi, Ray and Eric,</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Is there any reason why the GDT base was typecast to UINT32 in CpuDxe driver ? </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">In x64 long mode, the GDT base is actually 64bit. Typecasting will zero out the high 32bit address.</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">To me the correct code seems to be something like: </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">gdtPtr.Base = (UINTN)(VOID*) gdt;</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Thanks</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">Maurice</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> -----Original Message-----</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> From: Patrick Rudolph <</span><span style="color:black"><a href="mailto:patrick.rudolph@9elements.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">patrick.rudolph@9elements.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> Sent: Monday, February 22, 2021 7:43</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> To: Dong, Guo <</span><span style="color:black"><a href="mailto:guo.dong@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">guo.dong@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> Cc: </span><span style="color:black"><a href="mailto:devel@edk2.groups.io"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">devel@edk2.groups.io</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">; Ma, Maurice <</span><span style="color:black"><a href="mailto:maurice.ma@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">maurice.ma@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">>; You,</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> Benjamin <</span><span style="color:black"><a href="mailto:benjamin.you@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">benjamin.you@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry:</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> Remove 4GB memory WA</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> Hi Guo,</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> I tested on 078400ee15e7b250e4dfafd840c2e0c19835e16b and run it in</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> QEMU.</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> The problem seems to be here, as gdt is allocated > 4GiB:</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> gdtPtr.Base = (UINT32)(UINTN)(VOID*) gdt;</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> Regards,</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> Patrick</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> On Mon, Feb 22, 2021 at 3:59 PM Dong, Guo <</span><span style="color:black"><a href="mailto:guo.dong@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">guo.dong@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> wrote:</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > Hi Patrick,</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > Please make sure you are using latest master when testing this patch.</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > That issue should be fix be this patch:</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > UefiCpuPkg/CpuDxe: Fix boot error (commit:</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > ebfe2d3eb5ac7fd92d74011edb31303a181920c7)</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > And there is similar fix in another place as below:</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > UefiCpuPkg/MpInitLib: Fix a hang in above 4GB case (commit:</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > edd74ad3ad79b855f76d9cf60a96c405cb3e863b)</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > Thanks,</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > Guo</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > -----Original Message-----</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > From: </span><span style="color:black"><a href="mailto:devel@edk2.groups.io"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">devel@edk2.groups.io</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> <</span><span style="color:black"><a href="mailto:devel@edk2.groups.io"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">devel@edk2.groups.io</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> On Behalf Of</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > Patrick Rudolph</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > Sent: Monday, February 22, 2021 7:04 AM</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > To: </span><span style="color:black"><a href="mailto:devel@edk2.groups.io"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">devel@edk2.groups.io</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">; Ma, Maurice <</span><span style="color:black"><a href="mailto:maurice.ma@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">maurice.ma@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > Cc: Dong, Guo <</span><span style="color:black"><a href="mailto:guo.dong@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">guo.dong@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">>; You, Benjamin</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > <</span><span style="color:black"><a href="mailto:benjamin.you@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">benjamin.you@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry:</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > Remove 4GB memory WA</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > This patch breaks booting on master.</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > In CpuDxe.efi / InitGlobalDescriptorTable as the GDT pointer is</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > casted to 32bits.</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > Regards,</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > Patrick</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > On Fri, Feb 19, 2021 at 3:12 AM Ma, Maurice <</span><span style="color:black"><a href="mailto:maurice.ma@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">maurice.ma@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> wrote:</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > Reviewed-by: Maurice Ma <</span><span style="color:black"><a href="mailto:maurice.ma@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">maurice.ma@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > Regards</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > Maurice</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > -----Original Message-----</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > From: Dong, Guo <</span><span style="color:black"><a href="mailto:guo.dong@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">guo.dong@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > Sent: Sunday, February 14, 2021 21:13</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > To: </span><span style="color:black"><a href="mailto:devel@edk2.groups.io"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">devel@edk2.groups.io</span></a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > Cc: Ma, Maurice <</span><span style="color:black"><a href="mailto:maurice.ma@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">maurice.ma@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">>; You, Benjamin</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > <</span><span style="color:black"><a href="mailto:benjamin.you@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">benjamin.you@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry:</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > Remove 4GB memory WA</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > Previous it would hang in CpuDxe if DXE drivers are dispatched above</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> 4GB.</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > Now remove the work around since the fixed in CpuDxe are merged.</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > Signed-off-by: Guo Dong <</span><span style="color:black"><a href="mailto:guo.dong@intel.com"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif">guo.dong@intel.com</span></a></span><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > ---</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 5 -----</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > 1 file changed, 5 deletions(-)</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > index 805f5448d9..c403b0a80a 100644</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > @@ -40,11 +40,6 @@ MemInfoCallback (</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE |</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE;</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > - if (Base >= BASE_4GB ) {</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > - // Remove tested attribute to avoid DXE core to dispatch driver to</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > memory above 4GB</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > - Attribue &= ~EFI_RESOURCE_ATTRIBUTE_TESTED;</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > - }</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > -</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > BuildResourceDescriptorHob (Type, Attribue,</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > (EFI_PHYSICAL_ADDRESS)Base, Size);</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > DEBUG ((DEBUG_INFO , "buildhob: base = 0x%lx, size = 0x%lx,</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > type = 0x%x\n", Base, Size, Type));</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > --</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > > > 2.16.2.windows.1</span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > > </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> > ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black">> ></span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> </span><span style="color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Microsoft YaHei UI",sans-serif;color:black"> </span><span style="color:black"><o:p></o:p></span></p> </div> </div> </blockquote> </div> </div> </div> </blockquote> <div> <p class="MsoNormal"></o:p></span></p> </div> </div> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/72043">View/Reply Online (#72043)</a> | | <a target="_blank" href="https://groups.io/mt/80647875/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>