<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> </head> <body> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="auto"> Hi Ard,</div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="auto"> <br> </div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="auto"> Yes. This patch with fix the build failure reported by the CI.</div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="auto"> <br> </div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="auto"> Regards,</div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="auto"> <br> </div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="auto"> Sami Mujawar</div> <div id="id-ff9c31a6-a240-41eb-a78b-dfce5d786137" class="ms-outlook-mobile-reference-message"> <div style="font-family: sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg"><strong>From:</strong> Ard Biesheuvel <ardb@kernel.org><br> <strong>Sent:</strong> Friday, 26 February 2021, 6:46 pm<br> <strong>To:</strong> Sughosh Ganu; Liming Gao (Byosoft address)<br> <strong>Cc:</strong> devel@edk2.groups.io; Sami Mujawar; Ard Biesheuvel; Leif Lindholm; Matteo Carlini; Ben Adderson; nd<br> <strong>Subject:</strong> Re: [edk2-devel] [PATCH v2 1/1] ArmPkg: Fix uninitialised variable in ArmMmuStandaloneMmLib<br> </div> <br> <meta name="Generator" content="Microsoft Exchange Server"> <style></style><font size="2"><span style="font-size:11pt;"> <div class="PlainText">On Fri, 26 Feb 2021 at 11:58, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:<br> ><br> ><br> > On Thu, 25 Feb 2021 at 22:41, Sami Mujawar <sami.mujawar@arm.com> wrote:<br> >><br> >> The following patches added support for StandaloneMM using FF-A:<br> >> 9da5ee116a28 ArmPkg: Allow FF-A calls to set memory region's attributes<br> >> 0e43e02b9bd8 ArmPkg: Allow FF-A calls to get memory region's attributes<br> >><br> >> However, in the error handling logic for the Get/Set Memory attributes,<br> >> the CLANG compiler reports that a status variable could be used without<br> >> initialisation. This issue is a false positive and is not seen with GCC.<br> >><br> >> The Get/Set Memory attributes operation is atomic and therefore an<br> >> FFA_INTERRUPT or FFA_SUCCESS response is not expected in response<br> >> to FFA_MSG_SEND_DIRECT_REQ. So the remaining cases that could occur<br> >> are:<br> >> - the target sends FFA_MSG_SEND_DIRECT_RESP with a success or<br> >> failure code.<br> >> or<br> >> - FFA_MSG_SEND_DIRECT_REQ transmission failure.<br> >><br> >> Therefore,<br> >> - reorder the error handling conditions such that it prevents the<br> >> uninitialised variable issue being flagged by CLANG.<br> >> - move the repetitive code to a static helper function and add<br> >> documentation at the appropriate places.<br> >> - fix error handling in functions that invoke GetMemoryPermissions().<br> >><br> >> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com><br> >> ---<br> >> The changes can be seen at:<br> >> <a href="https://github.com/samimujawar/edk2/tree/1657_stmm_ffa_fix_unused_var_v2"> https://github.com/samimujawar/edk2/tree/1657_stmm_ffa_fix_unused_var_v2</a><br> ><br> ><br> > Tested the changes on the StandaloneMm image on the Qemu platform.<br> ><br> > Tested-by: Sughosh Ganu <sughosh.ganu@linaro.org><br> > Reviewed-by: Sughosh Ganu <sughosh.ganu@linaro.org><br> ><br> <br> Thanks. Sami, can you confirm that this patch fixes the CI failure I<br> reported to you in private? If so, I intend to merge this during the<br> freeze (assuming Liming is ok with that)<br> </div> </span></font><br> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/72238">View/Reply Online (#72238)</a> | | <a target="_blank" href="https://groups.io/mt/80906907/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>