<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Ethin I’m not sure what issue you are hitting with VFR? When you built the C build tools it should have built the VFR compiler that matches the code?<div> </div><div>Did you run edksetup.bat Rebuild?<div> <div dir="ltr"></div><div dir="ltr"> <blockquote type="cite">On Mar 31, 2021, at 10:05 PM, Ethin Probst <harlydavidsen@gmail.com> wrote: </blockquote></div><blockquote type="cite"><div dir="ltr">Hello there, Some good advice, and thank you! I might add it to the other virtIO* drivers if I can figure out a good template for that. One thing I'm running into right now is that my build setup is currently unable to build MdeModulePkg (which is required to build OVMF, according to the readme). I've reported it on the bugzilla; its issue 3289. This doesn't appear to occur on Linux, however, which is odd. Are there any suggestions that you guys have for improving my proposal? I didn't want to write too much or go overboard, like explaining how the sound driver would work and such, since I assumed -- while writing it -- that anyone who wanted to know those inner details would go read the VirtIO specification. But I'd appreciate any extra feedback before I submit my final version; I haven't made any changes since my initial proposal as of yet. On 3/31/21, Nate DeSimone <nathaniel.l.desimone@intel.com> wrote: <blockquote type="cite">Another option is to put the protocol definition in MdeModulePkg and mark it </blockquote><blockquote type="cite">with the EDKII_ prefix. For my last “code first” UEFI spec contribution I </blockquote><blockquote type="cite">did this with the PPI that added up getting added. </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">Thanks, </blockquote><blockquote type="cite">Nate </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">From: <devel@edk2.groups.io> on behalf of "Andrew Fish via groups.io" </blockquote><blockquote type="cite"><afish=apple.com@groups.io> </blockquote><blockquote type="cite">Reply-To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "afish@apple.com" </blockquote><blockquote type="cite"><afish@apple.com> </blockquote><blockquote type="cite">Date: Tuesday, March 30, 2021 at 10:54 PM </blockquote><blockquote type="cite">To: edk2-devel-groups-io <devel@edk2.groups.io>, "harlydavidsen@gmail.com" </blockquote><blockquote type="cite"><harlydavidsen@gmail.com> </blockquote><blockquote type="cite">Cc: Rafael Rodrigues Machado <rafaelrodrigues.machado@gmail.com> </blockquote><blockquote type="cite">Subject: Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021) </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">On Mar 30, 2021, at 5:01 PM, Ethin Probst </blockquote><blockquote type="cite"><harlydavidsen@gmail.com<mailto:harlydavidsen@gmail.com>> wrote: </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">I'm wondering where exactly I should add the VirtIO sound protocol. I </blockquote><blockquote type="cite">just familiarized myself with the build system and am about to test it </blockquote><blockquote type="cite">by building OVMF if possible, but I'm wondering where I should </blockquote><blockquote type="cite">actually put the protocol and all that stuff. Maybe there's </blockquote><blockquote type="cite">documentation I've missed as well. </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">Ethin, </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">For the driver I’d match the patter of OVMF [1] and use </blockquote><blockquote type="cite">OvmfPkg/VirtioSoundDxe/. Maybe even use one of the other drivers as a </blockquote><blockquote type="cite">template. </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">The protocol is more of a public thing. I think eventually we would like to </blockquote><blockquote type="cite">publish the protocol in the UEFI Spec (I can help with that part) and that </blockquote><blockquote type="cite">would mean we put the Protocol definition in MdePkg/Include/Protocol, but we </blockquote><blockquote type="cite">don’t want to do that before it is standardized as that causes compatibility </blockquote><blockquote type="cite">issues. So this is a “code first project” (code prototype and then </blockquote><blockquote type="cite">contribute to the UEFI Forum for inclusion in the specification) so we need </blockquote><blockquote type="cite">to follow some code first rules that I don’t remember of the top of my head? </blockquote><blockquote type="cite">So why not start out the protocol definition OvmfPkg/Include/Protocol. You </blockquote><blockquote type="cite">can also add a test application looks like you can just use the root [2] of </blockquote><blockquote type="cite">OVMF for that. That way the project is not blocked. </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">We can have a conversation on the mailing list about better places to put </blockquote><blockquote type="cite">stuff, and it should be easy enough to move stuff around if everything else </blockquote><blockquote type="cite">is working. </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">[1] find OvmfPkg -iname '*Virtio*.inf' </blockquote><blockquote type="cite">OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf </blockquote><blockquote type="cite">OvmfPkg/VirtioScsiDxe/VirtioScsi.inf </blockquote><blockquote type="cite">OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf </blockquote><blockquote type="cite">OvmfPkg/Library/VirtioLib/VirtioLib.inf </blockquote><blockquote type="cite">OvmfPkg/VirtioGpuDxe/VirtioGpu.inf </blockquote><blockquote type="cite">OvmfPkg/VirtioBlkDxe/VirtioBlk.inf </blockquote><blockquote type="cite">OvmfPkg/Virtio10Dxe/Virtio10.inf </blockquote><blockquote type="cite">OvmfPkg/VirtioNetDxe/VirtioNet.inf </blockquote><blockquote type="cite">OvmfPkg/VirtioRngDxe/VirtioRng.inf </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">[2] /Volumes/Case/edk2-github/OvmfPkg>git grep APPLICATION -- *.inf | grep </blockquote><blockquote type="cite">MODULE_TYPE </blockquote><blockquote type="cite">EnrollDefaultKeys/EnrollDefaultKeys.inf:13: MODULE_TYPE </blockquote><blockquote type="cite">= UEFI_APPLICATION </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">Thanks, </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">Andrew Fish </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">On 3/30/21, Ethin Probst via groups.io<http://groups.io/> </blockquote><blockquote type="cite"><harlydavidsen=gmail.com@groups.io<mailto:harlydavidsen=gmail.com@groups.io>> </blockquote><blockquote type="cite">wrote: </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">I agree. Plus, it gives me a chance to finally learn the EDK2 build </blockquote><blockquote type="cite">system and how it works! I've been working on a hobby OS as a side </blockquote><blockquote type="cite">project and, though learning from other code examples from OSes is </blockquote><blockquote type="cite">fun, I have to say that learning from the firmware code like from </blockquote><blockquote type="cite">SeaBIOS has been some of the most enlightening and interesting times </blockquote><blockquote type="cite">thus far. </blockquote><blockquote type="cite">Thanks for the link to your code, Rafael; once I get virtIO support </blockquote><blockquote type="cite">in, I can work on HDA support, though I might tackle USB support </blockquote><blockquote type="cite">second and HDA third. We'll see, but VirtIO definitely is coming </blockquote><blockquote type="cite">first. </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">As I said before, I look forward to working with all of you wonderful </blockquote><blockquote type="cite">people! </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">On 3/30/21, Rafael Rodrigues Machado </blockquote><blockquote type="cite"><rafaelrodrigues.machado@gmail.com<mailto:rafaelrodrigues.machado@gmail.com>> </blockquote><blockquote type="cite">wrote: </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">This would be amazing so people can continue my work related to </blockquote><blockquote type="cite">accessibility at BIOS. Something desired by the blind people since the </blockquote><blockquote type="cite">90's </blockquote><blockquote type="cite">Just for reference, this is what I have done: </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">https://github.com/RafaelRMachado/Msc_UefiHda_PreOs_Accessibility </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">Thanks </blockquote><blockquote type="cite">Rafael </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">Em seg, 29 de mar de 2021 20:24, Ethin Probst <harlydavidsen@gmail.com> </blockquote><blockquote type="cite">escreveu: </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">Hello everyone, </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">This is the first time I've ever contributed to EDK2. As part of GSoC </blockquote><blockquote type="cite">2021, I have submitted a proposal to implement a UEFI audio output </blockquote><blockquote type="cite">protocol that will utilize the VirtIO sound driver. I've already </blockquote><blockquote type="cite">submitted a draft proposal, and apologize if I've done things out of </blockquote><blockquote type="cite">order. This is my first time doing GSoC 2021, and contributing to EDK2 </blockquote><blockquote type="cite">felt like a really fun thing to do! </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">I look forward to working with you guys on this and any future projects! </blockquote><blockquote type="cite">:-) </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">-- </blockquote><blockquote type="cite">Signed, </blockquote><blockquote type="cite">Ethin D. Probst </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">-- </blockquote><blockquote type="cite">Signed, </blockquote><blockquote type="cite">Ethin D. Probst </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite">-- </blockquote><blockquote type="cite">Signed, </blockquote><blockquote type="cite">Ethin D. Probst </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote><blockquote type="cite"> </blockquote> -- Signed, Ethin D. Probst </div></blockquote></div></div></body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/73690">View/Reply Online (#73690)</a> | | <a target="_blank" href="https://groups.io/mt/81710286/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>