<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
I don't know... the ACPI spec is weird.</div>
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
<a href="https://uefi.org/specs/ACPI/6.4/06_Device_Configuration/Device_Configuration.html#dma-direct-memory-access" id="LPlnk">https://uefi.org/specs/ACPI/6.4/06_Device_Configuration/Device_Configuration.html#dma-direct-memory-access</a><br>
</div>
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
...lists ResourceConsumer for _DMA.</div>
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Consolas, Courier, monospace; font-size: 12pt; color: rgb(0, 0, 0);">
A</div>
<div class="_Entity _EType_OWALinkPreview _EId_OWALinkPreview _EReadonly_1"></div>
<br>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Jeremy Linton <jeremy.linton@arm.com><br>
<b>Sent:</b> Thursday, April 8, 2021 12:58 AM<br>
<b>To:</b> devel@edk2.groups.io <devel@edk2.groups.io><br>
<b>Cc:</b> ard.biesheuvel@arm.com <ard.biesheuvel@arm.com>; leif@nuviainc.com <leif@nuviainc.com>; pete@akeo.ie <pete@akeo.ie>; samer.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud@arm.com>; Andrei Warkentin <awarkentin@vmware.com>; Jeremy Linton <jeremy.linton@arm.com><br>
<b>Subject:</b> [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Bridge devices should be marked as producers so that their<br>
children can consume the resources. In linux if this isn't<br>
true then the translation gets ignored and the DMA values<br>
are incorrect. This fixes DMA on all the devices that<br>
need a translation.<br>
<br>
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com><br>
---<br>
 Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +-<br>
 Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +-<br>
 2 files changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl b/Platform/RaspberryPi/AcpiTables/Dsdt.asl<br>
index d116f965e1..32cd5fc9f9 100644<br>
--- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl<br>
+++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl<br>
@@ -205,7 +205,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "RPIFDN", "RPI", 2)<br>
         // Only the first GB is available.<br>
<br>
         // Bus 0xC0000000 -> CPU 0x00000000.<br>
<br>
         //<br>
<br>
-        QWordMemory (ResourceConsumer,<br>
<br>
+        QWordMemory (ResourceProducer,<br>
<br>
           ,<br>
<br>
           MinFixed,<br>
<br>
           MaxFixed,<br>
<br>
diff --git a/Platform/RaspberryPi/AcpiTables/Emmc.asl b/Platform/RaspberryPi/AcpiTables/Emmc.asl<br>
index 179dd3ecdb..0fbc2a79ea 100644<br>
--- a/Platform/RaspberryPi/AcpiTables/Emmc.asl<br>
+++ b/Platform/RaspberryPi/AcpiTables/Emmc.asl<br>
@@ -32,7 +32,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4EMMC", 2)<br>
       }<br>
<br>
 <br>
<br>
       Name (_DMA, ResourceTemplate() {<br>
<br>
-        QWordMemory (ResourceConsumer,<br>
<br>
+        QWordMemory (ResourceProducer,<br>
<br>
           ,<br>
<br>
           MinFixed,<br>
<br>
           MaxFixed,<br>
<br>
-- <br>
2.13.7<br>
<br>
</div>
</span></font></div>
</body>
</html>


 <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p>   You receive all messages sent to this group.    <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/73858">View/Reply Online (#73858)</a> |    |  <a target="_blank" href="https://groups.io/mt/81935645/1813853">Mute This Topic</a>  | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>    <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |  <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>  [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>