<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=gb2312"> <html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style></style></head><body lang=ZH-CN link=blue vlink="#954F72" style='word-wrap:break-word'><div class=WordSection1>Bret:<o:p></o:p> This fix is correct. I am interest that why the compiler doesn’t detect this issue. <o:p></o:p><o:p> </o:p>Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn><o:p></o:p><o:p> </o:p>Thanks<o:p></o:p>Liming<o:p></o:p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'>发件人: Bret Barkelew <Bret.Barkelew@microsoft.com> 发送时间: 2021年4月10日 2:34 收件人: devel@edk2.groups.io; bret@corthon.com; Liming Gao <gaoliming@byosoft.com.cn> 抄送: Jian J Wang <jian.j.wang@intel.com>; Hao A Wu <hao.a.wu@intel.com> 主题: RE: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib<o:p></o:p></div></div><o:p> </o:p>+ <a id=OWAAMEA661572DFC74983A7554CCF4CD8759B href="mailto:gaoliming@byosoft.com.cn">@Liming Gao</a><o:p></o:p><o:p> </o:p>- Bret <o:p></o:p><o:p> </o:p><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'>From: <a href="mailto:bret=corthon.com@groups.io">Bret Barkelew via groups.io</a> Sent: Friday, April 9, 2021 11:25 AM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> Cc: <a href="mailto:jian.j.wang@intel.com">Jian J Wang</a>; <a href="mailto:hao.a.wu@intel.com">Hao A Wu</a> Subject: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib<o:p></o:p></div><o:p> </o:p>DumpVariablePolicy() will return EFI_INVALID_PARAMETER if the Buffer pointer is NULL and the indirect Size is anything but 0. Since this TempSize was not being initialized it is very likely that this sequence would not return the total buffer size as expected. Bugzilla: <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3310&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C3d2f574a01a048aed60708d8fb84dcbb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637535895350828079%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=j6KmN6jcwoGJlunjspLawLJtYqCwGWw18pXNZVMNdC8%3D&reserved=0">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3310&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C3d2f574a01a048aed60708d8fb84dcbb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637535895350828079%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=j6KmN6jcwoGJlunjspLawLJtYqCwGWw18pXNZVMNdC8%3D&reserved=0</a> Cc: Jian J Wang <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>> Cc: Hao A Wu <<a href="mailto:hao.a.wu@intel.com">hao.a.wu@intel.com</a>> Signed-off-by: Bret Barkelew <<a href="mailto:bret.barkelew@microsoft.com">bret.barkelew@microsoft.com</a>> --- MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c index 14e1904e96d3..e50edb4ffc5a 100644 --- a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c +++ b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c @@ -216,6 +216,7 @@ VarCheckPolicyLibMmiHandler ( DumpParamsOut->TotalSize = 0; DumpParamsOut->PageSize = 0; DumpParamsOut->HasMore = FALSE; + TempSize = 0; SubCommandStatus = DumpVariablePolicy (NULL, &TempSize); if (SubCommandStatus == EFI_BUFFER_TOO_SMALL && TempSize > 0) { mCurrentPaginationCommand = VAR_CHECK_POLICY_COMMAND_DUMP; -- 2.28.0.windows.1 <o:p></o:p><o:p> </o:p></div></div></body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/73927">View/Reply Online (#73927)</a> | | <a target="_blank" href="https://groups.io/mt/82028626/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>