<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Tom,<div class=""> </div><div class="">The phases are defined by the UEFI Platform Initialization Specification [1] (PI Spec). Basically the UEFI Specification defines how to write EFI OS Loaders and Option ROMs and EFI is just defined in the context of how EFI services are passed into applications or drivers. The UEFI Platform Initialization Specification is how to write modular bits of the firmware that interoperate. So all PI systems produce UEFI, but not all UEFI systems are built out of PI. There are also some schemes that use the early parts of PI, but not all of it but this is confusing enough without talking about that. </div><div class=""> </div><div class="">[1] <a href="https://uefi.org/specifications" class="">https://uefi.org/specifications</a></div><div class=""> <div class="">Thanks,</div><div class=""> </div><div class="">Andrew Fish</div><div class=""> <div> <blockquote type="cite" class=""><div class="">On Apr 21, 2021, at 7:09 AM, Andrew Fish via <a href="http://groups.io" class="">groups.io</a> <<a href="mailto:afish=apple.com@groups.io" class="">afish=apple.com@groups.io</a>> wrote:</div> <div class=""><meta charset="UTF-8" class=""><a href="https://edk2-docs.gitbook.io/edk-ii-build-specification/2_design_discussion/23_boot_sequence" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://edk2-docs.gitbook.io/edk-ii-build-specification/2_design_discussion/23_boot_sequence</a><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div dir="ltr" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""></div><div dir="ltr" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""> <blockquote type="cite" class="">On Apr 20, 2021, at 11:34 PM, Eric van Tassell <<a href="mailto:evantass@amd.com" class="">evantass@amd.com</a>> wrote: </blockquote></div><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div dir="ltr" class=""> On 4/20/21 5:54 PM, Tom Lendacky wrote: <blockquote type="cite" class="">From: Tom Lendacky <<a href="mailto:thomas.lendacky@amd.com" class="">thomas.lendacky@amd.com</a>> </blockquote><blockquote type="cite" class="">BZ: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3345" class="">https://bugzilla.tianocore.org/show_bug.cgi?id=3345</a> </blockquote><blockquote type="cite" class="">The TPM support in OVMF performs MMIO accesses during the PEI phase. At </blockquote> where are the phases defined and how many other are there? <blockquote type="cite" class="">this point, MMIO ranges have not been marked un-encyrpted, so an SEV-ES </blockquote><blockquote type="cite" class="">guest will fail attempting to perform MMIO to an encrypted address. </blockquote><blockquote type="cite" class="">Read the PcdTpmBaseAddress and mark the specification defined range </blockquote><blockquote type="cite" class="">(0x5000 in length) as un-encrypted, to allow an SEV-ES guest to process </blockquote><blockquote type="cite" class="">the MMIO requests. </blockquote><blockquote type="cite" class="">Cc: Laszlo Ersek <<a href="mailto:lersek@redhat.com" class="">lersek@redhat.com</a>> </blockquote><blockquote type="cite" class="">Cc: Ard Biesheuvel <<a href="mailto:ardb+tianocore@kernel.org" class="">ardb+tianocore@kernel.org</a>> </blockquote><blockquote type="cite" class="">Cc: Jordan Justen <<a href="mailto:jordan.l.justen@intel.com" class="">jordan.l.justen@intel.com</a>> </blockquote><blockquote type="cite" class="">Cc: Brijesh Singh <<a href="mailto:brijesh.singh@amd.com" class="">brijesh.singh@amd.com</a>> </blockquote><blockquote type="cite" class="">Cc: James Bottomley <<a href="mailto:jejb@linux.ibm.com" class="">jejb@linux.ibm.com</a>> </blockquote><blockquote type="cite" class="">Cc: Jiewen Yao <<a href="mailto:jiewen.yao@intel.com" class="">jiewen.yao@intel.com</a>> </blockquote><blockquote type="cite" class="">Cc: Min Xu <<a href="mailto:min.m.xu@intel.com" class="">min.m.xu@intel.com</a>> </blockquote><blockquote type="cite" class="">Signed-off-by: Tom Lendacky <<a href="mailto:thomas.lendacky@amd.com" class="">thomas.lendacky@amd.com</a>> </blockquote><blockquote type="cite" class="">--- </blockquote><blockquote type="cite" class=""> OvmfPkg/PlatformPei/PlatformPei.inf | 1 + </blockquote><blockquote type="cite" class=""> OvmfPkg/PlatformPei/AmdSev.c | 19 +++++++++++++++++++ </blockquote><blockquote type="cite" class=""> 2 files changed, 20 insertions(+) </blockquote><blockquote type="cite" class="">diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf b/OvmfPkg/PlatformPei/PlatformPei.inf </blockquote><blockquote type="cite" class="">index 6ef77ba7bb21..de60332e9390 100644 </blockquote><blockquote type="cite" class="">--- a/OvmfPkg/PlatformPei/PlatformPei.inf </blockquote><blockquote type="cite" class="">+++ b/OvmfPkg/PlatformPei/PlatformPei.inf </blockquote><blockquote type="cite" class="">@@ -113,6 +113,7 @@ [Pcd] </blockquote><blockquote type="cite" class=""> [FixedPcd] </blockquote><blockquote type="cite" class=""> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress </blockquote><blockquote type="cite" class="">+ gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress </blockquote><blockquote type="cite" class=""> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS </blockquote><blockquote type="cite" class=""> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory </blockquote><blockquote type="cite" class=""> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType </blockquote><blockquote type="cite" class="">diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c </blockquote><blockquote type="cite" class="">index dddffdebda4b..d524929f9e10 100644 </blockquote><blockquote type="cite" class="">--- a/OvmfPkg/PlatformPei/AmdSev.c </blockquote><blockquote type="cite" class="">+++ b/OvmfPkg/PlatformPei/AmdSev.c </blockquote><blockquote type="cite" class="">@@ -141,6 +141,7 @@ AmdSevInitialize ( </blockquote><blockquote type="cite" class=""> ) </blockquote><blockquote type="cite" class=""> { </blockquote><blockquote type="cite" class=""> UINT64 EncryptionMask; </blockquote><blockquote type="cite" class="">+ UINT64 TpmBaseAddress; </blockquote><blockquote type="cite" class=""> RETURN_STATUS PcdStatus; </blockquote><blockquote type="cite" class=""> // </blockquote><blockquote type="cite" class="">@@ -206,6 +207,24 @@ AmdSevInitialize ( </blockquote><blockquote type="cite" class=""> } </blockquote><blockquote type="cite" class=""> } </blockquote><blockquote type="cite" class=""> + // </blockquote><blockquote type="cite" class="">+ // PEI TPM support will perform MMIO accesses, be sure this range is not </blockquote><blockquote type="cite" class="">+ // marked encrypted. </blockquote><blockquote type="cite" class="">+ // </blockquote><blockquote type="cite" class="">+ TpmBaseAddress = PcdGet64 (PcdTpmBaseAddress); </blockquote><blockquote type="cite" class="">+ if (TpmBaseAddress != 0) { </blockquote><blockquote type="cite" class="">+ RETURN_STATUS DecryptStatus; </blockquote><blockquote type="cite" class="">+ </blockquote><blockquote type="cite" class="">+ DecryptStatus = MemEncryptSevClearPageEncMask ( </blockquote><blockquote type="cite" class="">+ 0, </blockquote><blockquote type="cite" class="">+ TpmBaseAddress, </blockquote><blockquote type="cite" class="">+ EFI_SIZE_TO_PAGES (0x5000), </blockquote><blockquote type="cite" class="">+ FALSE </blockquote><blockquote type="cite" class="">+ ); </blockquote><blockquote type="cite" class="">+ </blockquote><blockquote type="cite" class="">+ ASSERT_RETURN_ERROR (DecryptStatus); </blockquote><blockquote type="cite" class="">+ } </blockquote><blockquote type="cite" class="">+ </blockquote><blockquote type="cite" class=""> // </blockquote><blockquote type="cite" class=""> // Check and perform SEV-ES initialization if required. </blockquote><blockquote type="cite" class=""> // </blockquote> </div></blockquote></div></blockquote></div> </div></div></body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/74337">View/Reply Online (#74337)</a> | | <a target="_blank" href="https://groups.io/mt/82247968/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>