<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-GB" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> Hi Pierre,<o:p></o:p> <o:p> </o:p> This patch looks good to me.<o:p></o:p> <o:p> </o:p> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com><o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> <o:p> </o:p> Sami Mujawar<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com> Date: Wednesday, 21 April 2021 at 13:21 To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com> Subject: [PATCH v1 05/12] ArmPkg: Correct small typos<o:p></o:p> </div> <div> From: Pierre Gondois <Pierre.Gondois@arm.com> The 'cspell' CI test detected some small typos in ArmPkg. Correct them. Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com> --- ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 2 +- ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 2 +- ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 4 ++-- ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c | 6 +++--- .../StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c | 2 +- .../SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 2 +- .../Type13/MiscNumberOfInstallableLanguagesFunction.c | 6 +++--- 7 files changed, 12 insertions(+), 12 deletions(-) diff --git a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c index 6c58d2b49317..54fad23cb42d 100644 --- a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c +++ b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c @@ -345,7 +345,7 @@ EfiAttributeToArmAttribute ( break; case EFI_MEMORY_WC: - // Map to normal non-cachable + // Map to normal non-cacheable ArmAttributes = TT_DESCRIPTOR_SECTION_CACHE_POLICY_NON_CACHEABLE; // TEX [2:0]= 001 = 0x2, B=0, C=0 break; diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c index 6a06b38ab949..c5036b7b5c70 100644 --- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c +++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c @@ -51,7 +51,7 @@ EFI_FILE gSemihostFsFile = { }; // -// Device path for semi-hosting. It contains our autogened Caller ID GUID. +// Device path for semi-hosting. It contains our auto-generated Caller ID GUID. // typedef struct { VENDOR_DEVICE_PATH Guid; diff --git a/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c b/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c index 940e4bc797f2..6b9d7eba90b9 100644 --- a/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c +++ b/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c @@ -124,7 +124,7 @@ UpdatePageEntries ( } else if ((Attributes & EFI_MEMORY_WC) != 0) { // modify cacheability attributes EntryMask |= TT_DESCRIPTOR_PAGE_CACHE_POLICY_MASK; - // map to normal non-cachable + // map to normal non-cacheable EntryValue |= TT_DESCRIPTOR_PAGE_CACHE_POLICY_NON_CACHEABLE; // TEX [2:0]= 001 = 0x2, B=0, C=0 } else if ((Attributes & EFI_MEMORY_WT) != 0) { // modify cacheability attributes @@ -254,7 +254,7 @@ UpdateSectionEntries ( } else if ((Attributes & EFI_MEMORY_WC) != 0) { // modify cacheability attributes EntryMask |= TT_DESCRIPTOR_SECTION_CACHE_POLICY_MASK; - // map to normal non-cachable + // map to normal non-cacheable EntryValue |= TT_DESCRIPTOR_SECTION_CACHE_POLICY_NON_CACHEABLE; // TEX [2:0]= 001 = 0x2, B=0, C=0 } else if ((Attributes & EFI_MEMORY_WT) != 0) { // modify cacheability attributes diff --git a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c index e35bcee38098..b6a07dd46608 100644 --- a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c +++ b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c @@ -37,11 +37,11 @@ SerialPortInitialize ( /** Write data to serial device. - @param Buffer Point of data buffer which need to be writed. + @param Buffer Point of data buffer which need to be written. @param NumberOfBytes Number of output bytes which are cached in Buffer. @retval 0 Write data failed. - @retval !0 Actual number of bytes writed to serial device. + @retval !0 Actual number of bytes written to serial device. **/ @@ -103,7 +103,7 @@ SerialPortWrite ( /** Read data from serial device and save the datas in buffer. - @param Buffer Point of data buffer which need to be writed. + @param Buffer Point of data buffer which need to be written. @param NumberOfBytes Number of output bytes which are cached in Buffer. @retval 0 Read data failed. diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c index 31672ae5cf4d..dd014beec873 100644 --- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c +++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c @@ -102,7 +102,7 @@ SendMemoryPermissionRequest ( // Check error response from Callee. if ((*RetVal & BIT31) != 0) { - // Bit 31 set means there is an error retured + // Bit 31 set means there is an error returned // See [1], Section 13.5.5.1 MM_SP_MEMORY_ATTRIBUTES_GET_AARCH64 and // Section 13.5.5.2 MM_SP_MEMORY_ATTRIBUTES_SET_AARCH64. switch (*RetVal) { diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c index 137bd941d0b1..29449b871902 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c @@ -23,7 +23,7 @@ SMBIOS_MISC_TABLE_DATA(SMBIOS_TABLE_TYPE3, MiscChassisManufacturer) = { 0, // Length, 0 // Handle }, - 1, // Manufactrurer + 1, // Manufacturer MiscChassisTypeMainServerChassis, // Type 2, // Version 3, // SerialNumber diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c index 19b60ed71f8c..7c941b5c0709 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c @@ -23,9 +23,9 @@ /** Get next language from language code list (with separator ';'). - @param LangCode Input: point to first language in the list. On - Otput: point to next language in the list, or - NULL if no more language in the list. + @param LangCode Input: point to first language in the list. On + Output: point to next language in the list, or + NULL if no more language in the list. @param Lang The first language in the list. **/ -- 2.17.1<o:p></o:p> </div> </div> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/74357">View/Reply Online (#74357)</a> | | <a target="_blank" href="https://groups.io/mt/82258506/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>