<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> I vote the latter. <o:p> </o:p> - Bret <o:p></o:p> <o:p> </o:p> <div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:rebecca=nuviainc.com@groups.io">Rebecca Cran via groups.io</a> Sent: Monday, April 26, 2021 2:29 PM To: <a href="mailto:Sami.Mujawar@arm.com">Sami Mujawar</a>; <a href="mailto:devel@edk2.groups.io"> devel@edk2.groups.io</a>; <a href="mailto:Samer.El-Haj-Mahmoud@arm.com">Samer El-Haj-Mahmoud</a>; <a href="mailto:Ard.Biesheuvel@arm.com">Ard Biesheuvel</a>; <a href="mailto:leif@nuviainc.com"> leif@nuviainc.com</a> Cc: <a href="mailto:rfc@edk2.groups.io">rfc@edk2.groups.io</a>; <a href="mailto:jiewen.yao@intel.com"> Yao, Jiewen</a>; <a href="mailto:rahul1.kumar@intel.com">Rahul Kumar</a>; <a href="mailto:nd@arm.com"> nd</a>; <a href="mailto:Jose.Marinho@arm.com">Jose Marinho</a> Subject: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe </div> <o:p> </o:p> Hi Sami, I've been looking through the design document again, and was wondering if the work I previously did will just slot in? Were you thinking the "RngLib|RNDR" would go into ArmPkg (since it's not labeled as being in BaseRngLib)? Or would it still make sense to refactor MdePkg/Library/BaseRngLib to support both x86 (using RDRAND) and aarch64 (using RNDR)? -- Rebecca Cran On 4/22/21 3:30 AM, Sami Mujawar wrote: > Hi Rebecca, > > I have been working on the following modules (See slide 11 in “EDKII - > Proposed update to RNG implementation.pdf > <<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&reserved=0%3e”">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&reserved=0>”</a>): > > 1. TrngLib|FwTrnglib (Arm Firmware TRNG) > 2. DrbgLib stack – with support for DrbgAlgorithmLib|CRT_DRBG & > AesLib|ArmAesInstructionLib. > > I plan to post patches for (a) in the next fortnight. Following this I > plan to update the proposal with the interface definitions for the > various library interfaces in the DrbgLib Stack. > > I have not looked at RngLib|RNDR as I believe you were interested in > implementing the part. Kindly let me know if you plan to implement this > and the platform you would be using for testing. It looks like the > FVP_Base_AEMv8A-AEMv8A and the FVP-RevC models support RNDR, so these > could be used for testing as well. Please feel free to get in touch > should you need any help with the model parameters or if you face any > issues. > > Regards, > > Sami Mujawar > > *From: *Rebecca Cran <rebecca@nuviainc.com> > *Date: *Tuesday, 20 April 2021 at 21:04 > *To: *Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io > <devel@edk2.groups.io>, Samer El-Haj-Mahmoud > <Samer.El-Haj-Mahmoud@arm.com>, Ard Biesheuvel <Ard.Biesheuvel@arm.com>, > leif@nuviainc.com <leif@nuviainc.com> > *Cc: *rfc@edk2.groups.io <rfc@edk2.groups.io>, Jiewen Yao > <jiewen.yao@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>, nd > <nd@arm.com>, Jose Marinho <Jose.Marinho@arm.com> > *Subject: *Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to > RngDxe > > Hi Sami, > > I was wondering if you're still collecting feedback on the design, or if > you have a plan and schedule for the implementation? > > -- > Rebecca Cran > > On 1/15/21 7:51 PM, Sami Mujawar wrote: > > Hi All, > > > > I have shared some initial thoughts on the RNG implementation updates > at > <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&reserved=0"> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&reserved=0</a> > <<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&reserved=0">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520implementation.pdf&data=04%7C01%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Q8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&reserved=0</a>> > > > > Kindly let me know your feedback or if you have any queries. > > > > Regards, > > > > Sami Mujawar > > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Rebecca Cran via groups.io > > Sent: 14 January 2021 09:05 PM > > To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io; Samer > El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel > <Ard.Biesheuvel@arm.com>; leif@nuviainc.com > > Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul > Kumar <rahul1.kumar@intel.com>; nd <nd@arm.com> > > Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to > RngDxe > > > > On 12/10/20 4:26 AM, Sami Mujawar wrote: > > > >> I am working on the TRNG FW API interface and will share more details > >> for the discussion soon. > >> > >> We had some thoughts about streamlining the RngDxe implementations and > >> would like to share some diagrams for the discussion. > >> > >> My diagrams are in Visio that I can export as JPG images. However, I am > >> open to switching to any other suggested tool. > > > > Hi Sami, > > > > I don't see any further discussions on this. Have you made any progress > > with sharing the design documents or scheduling a review? > > > <o:p></o:p> <o:p> </o:p> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/74436">View/Reply Online (#74436)</a> | | <a target="_blank" href="https://groups.io/mt/82390164/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>