<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-GB" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Hi Adrian,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Thank you for this patch.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">The changes look good to me. Can you let me know which compiler toolchain flagged up this error/build crash, please?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Reviewed-by: Sami Mujawar <sami.mujawar@arm.com><o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Sami Mujawar<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Adrián Herrera via groups.io <adr.her.arc.95=gmail.com@groups.io><br>
<b>Date: </b>Saturday, 24 April 2021 at 03:58<br>
<b>To: </b>devel@edk2.groups.io <devel@edk2.groups.io><br>
<b>Cc: </b>Adrián Herrera <adr.her.arc.95@gmail.com><br>
<b>Subject: </b>[edk2-devel] [PATCH] Platform/ARM/VExpressPkg: Fix unused but set<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Remove unused but set variables in GetArmNameSpaceObject. These caused a<br>
build crash due to -Werror=unused-but-set-variable.<br>
<br>
Signed-off-by: Adrián Herrera <adr.her.arc.95@gmail.com><br>
---<br>
.../ConfigurationManagerDxe/ConfigurationManager.c | 6 ------<br>
1 file changed, 6 deletions(-)<br>
<br>
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c<br>
index e99fbb654f..d169cd2c5d 100644<br>
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c<br>
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c<br>
@@ -721,8 +721,6 @@ GetArmNameSpaceObject (<br>
UINTN Smmuv3Count;<br>
<br>
<br>
UINTN ItsGroupCount;<br>
<br>
<br>
UINTN ItsIdentifierArrayCount;<br>
<br>
<br>
- UINTN RootComplexCount;<br>
<br>
<br>
- UINTN DeviceIdMappingArrayCount;<br>
<br>
<br>
UINTN PciConfigSpaceCount;<br>
<br>
<br>
<br>
<br>
<br>
if ((This == NULL) || (CmObject == NULL)) {<br>
<br>
<br>
@@ -739,15 +737,11 @@ GetArmNameSpaceObject (<br>
Smmuv3Count = 1;<br>
<br>
<br>
ItsGroupCount = 1;<br>
<br>
<br>
ItsIdentifierArrayCount = ARRAY_SIZE (PlatformRepo->ItsIdentifierArray);<br>
<br>
<br>
- RootComplexCount = 1;<br>
<br>
<br>
- DeviceIdMappingArrayCount = ARRAY_SIZE (PlatformRepo->DeviceIdMapping);<br>
<br>
<br>
PciConfigSpaceCount = 1;<br>
<br>
<br>
} else {<br>
<br>
<br>
Smmuv3Count = 0;<br>
<br>
<br>
ItsGroupCount = 0;<br>
<br>
<br>
ItsIdentifierArrayCount = 0;<br>
<br>
<br>
- RootComplexCount = 0;<br>
<br>
<br>
- DeviceIdMappingArrayCount = 0;<br>
<br>
<br>
PciConfigSpaceCount = 0;<br>
<br>
<br>
}<br>
<br>
<br>
<br>
<br>
<br>
-- <br>
2.30.0<br>
<br>
<br>
<br>
<br>
<br>
<o:p></o:p></p>
</div>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/74427">View/Reply Online (#74427)</a> | | <a target="_blank" href="https://groups.io/mt/82327317/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>