<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-GB" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> Hi Adrian,<o:p></o:p> <o:p> </o:p> I think the mailing list discussions here should be sufficient.<o:p></o:p> However, it would be great if you can test that the earlier patch works and reply with a tested-by.<o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> <o:p> </o:p> Sami Mujawar<o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Adrián Herrera Arcila <adr.her.arc.95@gmail.com> Date: Tuesday, 27 April 2021 at 10:48 To: Sami Mujawar <Sami.Mujawar@arm.com> Cc: devel@edk2.groups.io <devel@edk2.groups.io>, Joey Gouly <Joey.Gouly@arm.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, leif@nuviainc.com <leif@nuviainc.com>, nd <nd@arm.com> Subject: Re: [edk2-devel] [PATCH] ArmPkg/ArmGicLib: fix maximum interrupts supported<o:p></o:p> </div> <div> Hi Sami,<o:p></o:p> <div> <o:p> </o:p> </div> <div> That patch provides the same solution. I'll be sure to check the mailing list before sending the next time.<o:p></o:p> </div> <div> Any benefit on marking this as duplicate? If so, how could I do it?<o:p></o:p> <div> <o:p> </o:p> </div> <div> Thank you,<o:p></o:p> </div> <div> Adrián.<o:p></o:p> </div> </div> </div> <o:p> </o:p> <div> <div> On Mon, 26 Apr 2021 at 08:56, Sami Mujawar <<a href="mailto:Sami.Mujawar@arm.com">Sami.Mujawar@arm.com</a>> wrote:<o:p></o:p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <div> <div> Hi Adrian,<o:p></o:p> <o:p></o:p> I believe there is already a similar patch on the mailing list at <a href="https://edk2.groups.io/g/devel/message/72596" target="_blank">https://edk2.groups.io/g/devel/message/72596</a>. This patch is pending review and tested-by.<o:p></o:p> Can you check if this patch covers the problems you describe, please?<o:p></o:p> <o:p></o:p> Regards,<o:p></o:p> <o:p></o:p> Sami Mujawar<o:p></o:p> <o:p></o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> on behalf of Adrián Herrera via <a href="http://groups.io" target="_blank">groups.io</a> <adr.her.arc.95=<a href="mailto:gmail.com@groups.io" target="_blank">gmail.com@groups.io</a>> Date: Saturday, 24 April 2021 at 03:57 To: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> Cc: Adrián Herrera <<a href="mailto:adr.her.arc.95@gmail.com" target="_blank">adr.her.arc.95@gmail.com</a>> Subject: [edk2-devel] [PATCH] ArmPkg/ArmGicLib: fix maximum interrupts supported<o:p></o:p> </div> <div> The maximum number of interrupts supported is determined as 32 * (GICD_TYPER.ITLinesNumber + 1). When GICD_TYPER.ITLinesNumber = 0b11111, the maximum number of interrupts supported is 1024. However, both GICv2 and GICv3 reserve INTIDs 1020-1023 for special purposes. This results in runtime crashes because: (1) ArmGicLib functions do not guard against special interrupts. (2) ArmGicGetMaxNumInterrupts number includes special interrupts. (2) ArmGicV*Dxe relies on ArmGicGetMaxNumInterrupts, and thus programs special interrupts through ArmGicLib. ArmGicGetMaxNumInterrupts now does not include special interrupts, that is, it reports 1020 instead of 1024 when GICD_TYPER.ITLinesNumber = 0b11111. This avoids the overhead of guarding ArmGicLib functions while not requiring to modify the drivers code. Signed-off-by: Adrián Herrera <<a href="mailto:adr.her.arc.95@gmail.com" target="_blank">adr.her.arc.95@gmail.com</a>> --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmGicLib.c index 6b01c88206..dff1401e9c 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -120,7 +120,10 @@ ArmGicGetMaxNumInterrupts ( IN INTN GicDistributorBase ) { - return 32 * ((MmioRead32 (GicDistributorBase + ARM_GIC_ICDICTR) & 0x1F) + 1); + UINT32 ITLinesNumber; + + ITLinesNumber = MmioRead32 (GicDistributorBase + ARM_GIC_ICDICTR) & 0x1F; + return MIN (32 * (ITLinesNumber+ 1), 1020); } VOID -- 2.30.0 <o:p></o:p> </div> </div> </div> </blockquote> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/74448">View/Reply Online (#74448)</a> | | <a target="_blank" href="https://groups.io/mt/82327316/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>